X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;ds=inline;f=lily%2Ftuplet-bracket.cc;h=1f313e84a93482ccb492b92d37438b2f58b58481;hb=d393626a5a05ae79713f94714cd203dc8ba2dd14;hp=76983e959e1083a346f50a8e93c31722a387a3e7;hpb=72b030aeed611d4a24ed6ade7fcc570cceac4c0d;p=lilypond.git diff --git a/lily/tuplet-bracket.cc b/lily/tuplet-bracket.cc index 76983e959e..1f313e84a9 100644 --- a/lily/tuplet-bracket.cc +++ b/lily/tuplet-bracket.cc @@ -31,7 +31,7 @@ #include "warn.hh" #include "font-interface.hh" #include "stencil.hh" -#include "paper-def.hh" +#include "output-def.hh" #include "text-item.hh" #include "tuplet-bracket.hh" #include "stem.hh" @@ -63,7 +63,7 @@ Tuplet_bracket::parallel_beam (Grob *me, Link_array const &cols, bool *equ ugh: code dup. */ Grob *s1 = Note_column::get_stem (cols[0]); - Grob *s2 = Note_column::get_stem (cols.top()); + Grob *s2 = Note_column::get_stem (cols.top ()); Grob*b1 = s1 ? Stem::get_beam (s1) : 0; Grob*b2 = s2 ? Stem::get_beam (s2) : 0; @@ -77,14 +77,14 @@ Tuplet_bracket::parallel_beam (Grob *me, Link_array const &cols, bool *equ Link_array beam_stems = Pointer_group_interface__extract_grobs (b1, (Grob*)0, "stems"); - if (beam_stems.size() == 0) + if (beam_stems.size () == 0) { programming_error ("Beam under tuplet bracket has no stems!"); *equally_long = 0; return 0; } - *equally_long = (beam_stems[0] == s1 && beam_stems.top() == s2); + *equally_long = (beam_stems[0] == s1 && beam_stems.top () == s2); return b1; } @@ -111,15 +111,15 @@ Tuplet_bracket::print (SCM smob) { - SCM lp = me->get_grob_property ("left-position"); - SCM rp = me->get_grob_property ("right-position"); + SCM lp = me->get_property ("left-position"); + SCM rp = me->get_property ("right-position"); - if (!gh_number_p (rp) || !gh_number_p (lp)) + if (!scm_is_number (rp) || !scm_is_number (lp)) after_line_breaking (smob); } - Real ly = robust_scm2double (me->get_grob_property ("left-position"), 0); - Real ry = robust_scm2double (me->get_grob_property ("right-position"), 0); + Real ly = robust_scm2double (me->get_property ("left-position"), 0); + Real ry = robust_scm2double (me->get_property ("right-position"), 0); bool equally_long = false; Grob * par_beam = parallel_beam (me, columns, &equally_long); @@ -132,18 +132,18 @@ Tuplet_bracket::print (SCM smob) /* Fixme: the type of this prop is sucky. */ - SCM bracket = me->get_grob_property ("bracket-visibility"); - if (gh_boolean_p (bracket)) + SCM bracket = me->get_property ("bracket-visibility"); + if (scm_is_bool (bracket)) { - bracket_visibility = gh_scm2bool (bracket); + bracket_visibility = ly_scm2bool (bracket); } else if (bracket == ly_symbol2scm ("if-no-beam")) bracket_visibility = !par_beam; - SCM numb = me->get_grob_property ("number-visibility"); - if (gh_boolean_p (numb)) + SCM numb = me->get_property ("number-visibility"); + if (scm_is_bool (numb)) { - number_visibility = gh_scm2bool (numb); + number_visibility = ly_scm2bool (numb); } else if (numb == ly_symbol2scm ("if-no-beam")) number_visibility = !par_beam; @@ -154,26 +154,27 @@ Tuplet_bracket::print (SCM smob) Tuplet brackets are normally not broken, but we shouldn't crash if they are. */ - commonx = commonx->common_refpoint (sp->get_bound(LEFT), X_AXIS); - commonx = commonx->common_refpoint (sp->get_bound(RIGHT), X_AXIS); + commonx = commonx->common_refpoint (sp->get_bound (LEFT), X_AXIS); + commonx = commonx->common_refpoint (sp->get_bound (RIGHT), X_AXIS); Direction dir = get_grob_direction (me); Grob * lgr = get_x_bound_grob (columns[0], dir); - Grob * rgr = get_x_bound_grob (columns.top(), dir); - Real x0 = lgr->extent (commonx,X_AXIS)[LEFT]; - Real x1 = rgr->extent (commonx,X_AXIS)[RIGHT]; - + Grob * rgr = get_x_bound_grob (columns.top (), dir); + + Real x0 = robust_relative_extent (lgr, commonx, X_AXIS)[LEFT]; + Real x1 = robust_relative_extent (rgr, commonx, X_AXIS)[RIGHT]; Real w = x1 -x0; - SCM number = me->get_grob_property ("text"); + SCM number = me->get_property ("text"); - Paper_def *pap = me->get_paper (); - if (gh_string_p (number) && number_visibility) + Output_def *pap = me->get_layout (); + Stencil num; + if (scm_is_string (number) && number_visibility) { - SCM properties = Font_interface::font_alist_chain (me); - SCM snum = Text_item::interpret_markup (pap->self_scm (), properties, number); - Stencil num = *unsmob_stencil (snum); + SCM properties = Font_interface::text_font_alist_chain (me); + SCM snum = Text_interface::interpret_markup (pap->self_scm (), properties, number); + num = *unsmob_stencil (snum); num.align_to (X_AXIS, CENTER); num.translate_axis (w/2, X_AXIS); num.align_to (Y_AXIS, CENTER); @@ -198,29 +199,36 @@ Tuplet_bracket::print (SCM smob) if (bracket_visibility) { Real ss = Staff_symbol_referencer::staff_space (me); - Real gap = robust_scm2double (me->get_grob_property ("gap"), 1.0) - * ss; + Real gap=0.; + + if (!num.extent (X_AXIS).is_empty ()) + gap = num.extent (X_AXIS).length () + 1.0; - SCM fl = me->get_grob_property ("bracket-flare"); - SCM eh = me->get_grob_property ("edge-height"); - SCM sp = me->get_grob_property ("shorten-pair"); + SCM fl = me->get_property ("bracket-flare"); + SCM eh = me->get_property ("edge-height"); + SCM sp = me->get_property ("shorten-pair"); Direction d = LEFT; Drul_array height, flare, shorten; do { flare[d] = height[d] = shorten[d] = 0.0; if (is_number_pair (fl)) - flare[d] += ss * gh_scm2double (index_get_cell (fl, d)); + flare[d] += ss * scm_to_double (index_get_cell (fl, d)); if (is_number_pair (eh)) - height[d] += - dir * ss *gh_scm2double (index_get_cell (eh, d)); + height[d] += - dir * ss *scm_to_double (index_get_cell (eh, d)); if (is_number_pair (sp)) - shorten[d] += ss *gh_scm2double (index_get_cell (sp, d)); + shorten[d] += ss *scm_to_double (index_get_cell (sp, d)); } while (flip (&d) != LEFT); Stencil brack = make_bracket (me, Y_AXIS, Offset (w, ry - ly), - height, gap, + height, + /* + 0.1 = more space at right due to italics + TODO: use italic correction of font. + */ + Interval (-0.5, 0.5) * gap + 0.1, flare, shorten); mol.add_stencil (brack); } @@ -241,11 +249,11 @@ Tuplet_bracket::make_bracket (Grob *me, // for line properties. Axis protusion_axis, Offset dz, Drul_array height, - Real gap, + Interval gap, Drul_array flare, Drul_array shorten) { - Drul_array corners (Offset(0,0), dz); + Drul_array corners (Offset (0,0), dz); Real length = dz.length (); Drul_array gap_corners; @@ -260,14 +268,11 @@ Tuplet_bracket::make_bracket (Grob *me, // for line properties. straight_corners[d] += - d * shorten[d] /length * dz; } while (flip (&d) != LEFT); - /* - UGH: the shortening factor is magic. - */ - gap = gap flare_corners = straight_corners; @@ -280,10 +285,10 @@ Tuplet_bracket::make_bracket (Grob *me, // for line properties. Stencil m; do { m.add_stencil (Line_interface::line (me, straight_corners[d], - gap_corners[d])); + gap_corners[d])); m.add_stencil (Line_interface::line (me, straight_corners[d], - flare_corners[d])); + flare_corners[d])); } while (flip (&d) != LEFT); return m; @@ -300,7 +305,7 @@ Tuplet_bracket::calc_position_and_height (Grob*me,Real *offset, Real * dy) Pointer_group_interface__extract_grobs (me, (Grob*)0, "note-columns"); - SCM cols = me->get_grob_property ("note-columns"); + SCM cols = me->get_property ("note-columns"); Grob * commony = common_refpoint_of_list (cols, me, Y_AXIS); Grob * commonx = common_refpoint_of_list (cols, me, X_AXIS); @@ -354,10 +359,9 @@ Tuplet_bracket::calc_position_and_height (Grob*me,Real *offset, Real * dy) Grob * lgr = get_x_bound_grob (columns[0], dir); - Grob * rgr = get_x_bound_grob (columns.top(), dir); - Real x0 = lgr->extent (commonx,X_AXIS)[LEFT]; - Real x1 = rgr->extent (commonx,X_AXIS)[RIGHT]; - + Grob * rgr = get_x_bound_grob (columns.top (), dir); + Real x0 = robust_relative_extent (lgr, commonx, X_AXIS)[LEFT]; + Real x1 = robust_relative_extent (rgr, commonx, X_AXIS)[RIGHT]; /* Slope. @@ -378,7 +382,7 @@ Tuplet_bracket::calc_position_and_height (Grob*me,Real *offset, Real * dy) } // padding - *offset += gh_scm2double (me->get_grob_property ("padding")) *dir; + *offset += scm_to_double (me->get_property ("padding")) *dir; /* @@ -414,14 +418,14 @@ Tuplet_bracket::before_line_breaking (SCM smob) Pointer_group_interface__extract_grobs (me, (Grob*)0, "note-columns"); - for (int i = columns.size(); i--;) + for (int i = columns.size (); i--;) { Grob * s =Note_column::get_stem (columns[i]); Grob * b = s ? Stem::get_beam (s): 0; if (b) me->add_dependency (b); } - return SCM_UNDEFINED; + return SCM_UNSPECIFIED; } MAKE_SCHEME_CALLBACK (Tuplet_bracket,after_line_breaking,1); @@ -441,7 +445,7 @@ Tuplet_bracket::after_line_breaking (SCM smob) if (dynamic_cast (me)->is_broken ()) { me->warning (_("Killing tuplet bracket across linebreak.")); - me->suicide(); + me->suicide (); return SCM_UNSPECIFIED; } @@ -466,38 +470,38 @@ Tuplet_bracket::after_line_breaking (SCM smob) } else { - SCM ps = par_beam->get_grob_property ("positions"); + SCM ps = par_beam->get_property ("positions"); - Real lp = gh_scm2double (gh_car (ps)); - Real rp = gh_scm2double (gh_cdr (ps)); + Real lp = scm_to_double (scm_car (ps)); + Real rp = scm_to_double (scm_cdr (ps)); /* duh. magic. */ - offset = lp + dir * (0.5 + gh_scm2double (me->get_grob_property ("padding"))); + offset = lp + dir * (0.5 + scm_to_double (me->get_property ("padding"))); dy = rp- lp; } - SCM lp = me->get_grob_property ("left-position"); - SCM rp = me->get_grob_property ("right-position"); + SCM lp = me->get_property ("left-position"); + SCM rp = me->get_property ("right-position"); - if (gh_number_p (lp) && !gh_number_p (rp)) + if (scm_is_number (lp) && !scm_is_number (rp)) { - rp = gh_double2scm (gh_scm2double (lp) + dy); + rp = scm_make_real (scm_to_double (lp) + dy); } - else if (gh_number_p (rp) && !gh_number_p (lp)) + else if (scm_is_number (rp) && !scm_is_number (lp)) { - lp = gh_double2scm (gh_scm2double (rp) - dy); + lp = scm_make_real (scm_to_double (rp) - dy); } - else if (!gh_number_p (rp) && !gh_number_p (lp)) + else if (!scm_is_number (rp) && !scm_is_number (lp)) { - lp = gh_double2scm (offset); - rp = gh_double2scm (offset +dy); + lp = scm_make_real (offset); + rp = scm_make_real (offset +dy); } - me->set_grob_property ("left-position", lp); - me->set_grob_property ("right-position", rp); + me->set_property ("left-position", lp); + me->set_property ("right-position", rp); return SCM_UNSPECIFIED; } @@ -509,10 +513,10 @@ Tuplet_bracket::after_line_breaking (SCM smob) Direction Tuplet_bracket::get_default_dir (Grob*me) { - Drul_array dirs(0,0); - for (SCM s = me->get_grob_property ("note-columns"); gh_pair_p (s); s = ly_cdr (s)) + Drul_array dirs (0,0); + for (SCM s = me->get_property ("note-columns"); scm_is_pair (s); s = scm_cdr (s)) { - Grob * nc = unsmob_grob (ly_car (s)); + Grob * nc = unsmob_grob (scm_car (s)); Direction d = Note_column::dir (nc); if (d) dirs[d]++; @@ -537,5 +541,5 @@ Tuplet_bracket::add_column (Grob*me, Item*n) ADD_INTERFACE (Tuplet_bracket,"tuplet-bracket-interface", "A bracket with a number in the middle, used for tuplets.", - "note-columns bracket-flare edge-height shorten-pair padding gap left-position right-position bracket-visibility number-visibility thickness direction"); + "note-columns bracket-flare edge-height shorten-pair padding left-position right-position bracket-visibility number-visibility thickness direction");