make site::aptrepo a proper type

[dsa-puppet.git] / modules / site / manifests / aptrepo.pp

diff --git a/modules/site/manifests/aptrepo.pp b/modules/site/manifests/aptrepo.pp
index b1c825dcc638d8edf8a817ceb0f5e396d0198dc5..c97fade0ea3f6660273676bf628de545a750b186 100644 (file)
--- a/modules/site/manifests/aptrepo.pp
+++ b/modules/site/manifests/aptrepo.pp
@@ -1,39 +1,53 @@
-define site::aptrepo ($key = undef, $template = undef, $config = undef, $ensure = present) {
-
-       if $key {
-               exec { "apt-key-update-${name}":
-                       command     => "apt-key add /etc/apt/trusted-keys.d/${name}",
-                       refreshonly => true,
-               }
-
-               file { "/etc/apt/trusted-keys.d/${name}":
-                       source => $key,
-                       mode   => '0664',
-                       notify => Exec["apt-key-update-${name}"]
-               }
-       }
+define site::aptrepo (
+       $url,
+       $suite,
+       $components=[],
+       $key = undef,
+       $keyid = undef,
+       $ensure = present
+) {
 
        case $ensure {
-               present: {}
-               absent:  {}
-               default: { err ( "Unknown ensure value: '$ensure'" ) }
-       }
+               present: {
+                       if $key {
+                               exec { "apt-key-update-${name}":
+                                       command     => "apt-key add /etc/apt/trusted-keys.d/${name}.asc",
+                                       refreshonly => true,
+                               }
 
-       if ! ($template or $config) {
-               err ( "Can't find configuration for ${name}" )
+                               file { "/etc/apt/trusted-keys.d/${name}.asc":
+                                       source => $key,
+                                       mode   => '0664',
+                                       notify => Exec["apt-key-update-${name}"]
+                               }
+                       }
+               }
+               absent:  {
+                       if ($keyid) and ($key) {
+                               file { "/etc/apt/trusted-keys.d/${name}.asc":
+                                       ensure => absent,
+                                       notify => Exec["apt-key-del-${keyid}"]
+                               }
+                               exec { "apt-key-del-${keyid}":
+                                       command     => "apt-key del ${keyid}",
+                                       refreshonly => true,
+                               }
+                       } elsif $key {
+                               file { "/etc/apt/trusted-keys.d/${name}.asc":
+                                       ensure => absent,
+                               }
+                       } elsif $keyid {
+                               exec { "apt-key-del-${keyid}":
+                                       command     => "apt-key del ${keyid}",
+                               }
+                       }
+               }
+               default: { fail ( "Unknown ensure value: '$ensure'" ) }
        }
 
-       if $template {
-               file { "/etc/apt/sources.list.d/${name}.list":
+       file { "/etc/apt/sources.list.d/${name}.list":
                        ensure  => $ensure,
-                       content => template($template),
+                       content => template('site/aptrepo.erb'),
                        notify => Exec['apt-get update'],
-               }
-       } else {
-               file { "/etc/apt/sources.list.d/${name}.list":
-                       ensure => $ensure,
-                       source => $config,
-                       notify => Exec['apt-get update'],
-               }
        }
 }