Replace the target tarfile atomically

[dsa-puppet.git] / modules / porterbox / files / setup-dchroot

diff --git a/modules/porterbox/files/setup-dchroot b/modules/porterbox/files/setup-dchroot
index db098d1985205d06912c55dc902471ee51610bd5..6fa9e66c39648f56fcc28e878433b35a873c6275 100755 (executable)
--- a/modules/porterbox/files/setup-dchroot
+++ b/modules/porterbox/files/setup-dchroot
@@ -42,6 +42,7 @@ OPTIONS:
     -c         write config only
     -f         overwrite config and target tarball
     -k KEYRING use an alternate keyring [$keyring]
+    -s         use sbuild compatible naming scheme
     -h         this help
 EOF
 }
@@ -69,9 +70,16 @@ genschrootconf() {
         local suite="${suite}-${extra}"
     fi
 
+    if [ -n "$sbuildnames" ]; then
+        local name="${suite}-${arch}-sbuild"
+    else
+        local name="${suite}_${arch}-dchroot"
+    fi
+
+
 cat << EOF
-[${suite}_${arch}-dchroot]
-description=[${suite}_${arch}-dchroot] Debian $suite chroot for $arch
+[${name}]
+description=[${name}] Debian $suite chroot for $arch
 type=file
 file=$target
 groups=Debian,guest
@@ -123,10 +131,11 @@ configonly=""
 force=""
 basedir="/srv/chroot"
 keyring=/usr/share/keyrings/debian-archive-keyring.gpg
+sbuildnames=""
 declare -a cleanup
 trap do_cleanup EXIT
 
-while getopts "a:b:cfhk:m:" OPTION
+while getopts "a:b:cfhk:m:s" OPTION
 do
     case $OPTION in
         a)
@@ -151,6 +160,9 @@ do
         m)
             mirror="$OPTARG"
             ;;
+        s)
+            sbuildnames="1"
+            ;;
         *)
             usage >&2
             exit 1
@@ -219,4 +231,6 @@ chroot "$rootdir" apt-get install -y --no-install-recommends zsh locales-all bui
 rm -f "$rootdir/etc/apt/sources.list" "$rootdir/etc/apt/sources.list.d/*"
 umount "$rootdir/sys" || true
 
-(cd "$rootdir" && tar caf "$target" .)
+tartmp=$(tempfile --directory "$basedir" --suffix=".tar.gz")
+cleanup+=("rm -f $tartmp")
+(cd "$rootdir" && tar caf "$tartmp" . && mv "$tartmp" "$target")