/*
This file is part of LilyPond, the GNU music typesetter.
- Copyright (C) 2008--2011 Han-Wen Nienhuys <hanwen@lilypond.org>
+ Copyright (C) 2008--2012 Han-Wen Nienhuys <hanwen@lilypond.org>
LilyPond is free software: you can redistribute it and/or modify
{
if (!line_)
line_ = make_spanner ("DynamicLineSpanner",
- event ? event->self_scm () : SCM_EOL);
+ event ? event->self_scm () : SCM_EOL);
}
void
ended_.push_back (info.spanner ());
/* If the break flag is set, store the current spanner and let new dynamics
- * create a new spanner
+ * create a new spanner
*/
- bool spanner_broken = current_dynamic_spanner_ == info.spanner () &&
- to_boolean (current_dynamic_spanner_->get_property ("spanner-broken"));
+ bool spanner_broken = current_dynamic_spanner_ == info.spanner ()
+ && to_boolean (current_dynamic_spanner_->get_property ("spanner-broken"));
if (spanner_broken && line_)
{
if (ended_line_)
Dynamic_align_engraver::acknowledge_dynamic (Grob_info info)
{
Stream_event *cause = info.event_cause ();
+ // Check whether an existing line spanner has the same direction
+ if (line_ && cause)
+ {
+ Direction line_dir = get_grob_direction (line_);
+ Direction grob_dir = to_dir (cause->get_property ("direction"));
+
+ // If we have an explicit direction for the new dynamic grob
+ // that differs from the current line spanner, break the spanner
+ if (grob_dir && (line_dir != grob_dir))
+ {
+ if (!ended_line_)
+ ended_line_ = line_;
+ line_ = 0;
+ current_dynamic_spanner_ = 0;
+ }
+ }
+
create_line_spanner (cause);
if (Spanner::has_interface (info.grob ()))
{
if (cause)
{
- // TODO: Compare the direction of the existing spanner with
- // the new one and if they differ, create a new line
- // spanner.
if (Direction d = to_dir (cause->get_property ("direction")))
- set_grob_direction (line_, d);
+ set_grob_direction (line_, d);
}
}
Direction d = LEFT;
do
{
- if ((d == LEFT && !line->get_bound (LEFT)) ||
- (end && d == RIGHT && !line->get_bound (RIGHT)))
- {
- vector<Spanner *> const &spanners
- = (d == LEFT) ? started_ : ended_;
-
- Grob *bound = 0;
- if (scripts_.size ())
- bound = scripts_[0];
- else if (spanners.size ())
- bound = spanners[0]->get_bound (d);
- else
- {
- bound = unsmob_grob (get_property ("currentMusicalColumn"));
- programming_error ("started DynamicLineSpanner but have no left bound");
- }
-
- line->set_bound (d, bound);
- }
+ if ((d == LEFT && !line->get_bound (LEFT))
+ || (end && d == RIGHT && !line->get_bound (RIGHT)))
+ {
+ vector<Spanner *> const &spanners
+ = (d == LEFT) ? started_ : ended_;
+
+ Grob *bound = 0;
+ if (scripts_.size ())
+ bound = scripts_[0];
+ else if (spanners.size ())
+ bound = spanners[0]->get_bound (d);
+ else
+ {
+ bound = unsmob_grob (get_property ("currentMusicalColumn"));
+ programming_error ("started DynamicLineSpanner but have no left bound");
+ }
+
+ line->set_bound (d, bound);
+ }
}
while (flip (&d) != LEFT);
}
set<Spanner *>::iterator it = running_.find (sp);
if (it != running_.end ())
- running_.erase (it);
+ running_.erase (it);
else
- started_[i]->programming_error ("lost track of this dynamic spanner");
+ started_[i]->programming_error ("lost track of this dynamic spanner");
}
bool end = line_ && running_.empty ();
// is ended now
set_spanner_bounds (ended_line_, true);
set_spanner_bounds (line_, end);
- // If the flag is set to break the spanner after the current child, don't
+ // If the flag is set to break the spanner after the current child, don't
// add any more support points (needed e.g. for style=none, where the
// invisible spanner should NOT be shifted since we don't have a line).
- bool spanner_broken = current_dynamic_spanner_ &&
- to_boolean (current_dynamic_spanner_->get_property ("spanner-broken"));
+ bool spanner_broken = current_dynamic_spanner_
+ && to_boolean (current_dynamic_spanner_->get_property ("spanner-broken"));
for (vsize i = 0; line_ && !spanner_broken && i < support_.size (); i++)
Side_position_interface::add_support (line_, support_[i]);
}
ADD_TRANSLATOR (Dynamic_align_engraver,
- /* doc */
- "Align hairpins and dynamic texts on a horizontal line.",
+ /* doc */
+ "Align hairpins and dynamic texts on a horizontal line.",
- /* create */
- "DynamicLineSpanner ",
+ /* create */
+ "DynamicLineSpanner ",
- /* read */
- "currentMusicalColumn ",
+ /* read */
+ "currentMusicalColumn ",
- /* write */
- ""
- );
+ /* write */
+ ""
+ );