r501: * Began work on v4 support (and thus the large version number jump), and it

[debhelper.git] / dh_makeshlibs

diff --git a/dh_makeshlibs b/dh_makeshlibs
index 1888ee2d54f46112dc2e79cbcf4fc0451c94b68d..478c861b001c297833654edbbd304dfe0a7c238b 100755 (executable)
--- a/dh_makeshlibs
+++ b/dh_makeshlibs
@@ -11,7 +11,7 @@ use Debian::Debhelper::Dh_Lib;
 
 =head1 SYNOPSIS
 
-  dh_makeshlibs [debhelper options] [-mmajor] [-V[dependancies]] [-n]
+B<dh_makeshlibs> [S<I<debhelper options>>] [B<-m>I<major>] [B<-V>I<[dependancies]>] [B<-n>] [B<-X>I<item>]
 
 =head1 DESCRIPTION
 
@@ -19,7 +19,8 @@ dh_makeshlibs is a debhelper program that automatically scans for shared
 libraries, and generates a shlibs file for the libraries it finds.
 
 It also adds a call to ldconfig in the postinst and postrm scripts (in
-DH_COMPAT=3 mode and above only).
+DH_COMPAT=3 mode and above only) to any packages which it finds shared
+libraries in.
 
 =head1 OPTIONS
 
@@ -27,8 +28,10 @@ DH_COMPAT=3 mode and above only).
 
 =item B<-m>I<major>, B<--major=>I<major>
 
-Instead of trying to guess the major number of the library from the
-filename of the library, use the major number specified after the -m parameter.
+Instead of trying to guess the major number of the library with objdump,
+use the major number specified after the -m parameter. This is much less
+useful than it used to be, back in the bad old days when this program
+looked at library filenames rather than using objdump.
 
 =item B<-V>, B<-V>I<dependancies>
 
@@ -39,14 +42,25 @@ depend on any particular version of the package containing the shared
 library. It may be necessary for you to add some version dependancy
 information to the shlibs file. If -V is specified with no dependancy
 information, the current version of the package is plugged into a
-dependancy that looks like "packagename (>= packageversion)". If -V is specified with
-parameters, the parameters can be used to specify the exact dependancy
-information needed (be sure to include the package name).
+dependancy that looks like "packagename (>= packageversion)". If -V is
+specified with parameters, the parameters can be used to specify the exact
+dependancy information needed (be sure to include the package name).
+
+Beware of using -V without any parameters; this is a conservative setting
+that always ensures that other packages' shared library dependencies are at
+least as tight as they need to be, so that if the maintainer screws up then
+they won't break. The flip side is that packages might end up with
+dependencies that are too tight and so find it harder to be upgraded.
 
 =item B<-n>, B<--noscripts>
 
 Do not modify postinst/postrm scripts.
 
+=item B<-X>I<item>, B<--exclude=>I<item>
+
+Exclude files that contain "item" anywhere in their filename from
+being treated as shared libraries.
+
 =back
 
 =head1 EXAMPLES
@@ -68,14 +82,6 @@ file that looks something like:
 Generates a shlibs file that looks something like:
   libfoobar 1 libfoobar1 (>= 1.0)
 
-=head1 NOTES
-
-There is no guarantee that the program will get the shlibs file right. For
-example, it may not correctly guess the major number of your package. In
-cases like these (and perhaps in general, just to be safe), it is better to
-create a debian/shlibs file by hand, or force it to use the correct major
-number by specifying the -m parameter.
-
 =cut
 
 init();
@@ -88,21 +94,36 @@ foreach my $package (@{$dh{DOPACKAGES}}) {
 
        doit("rm", "-f", "$tmp/DEBIAN/shlibs");
 
-       open (FIND, "find $tmp -xtype f -name '*.so*' |");
+       # So, we look for files or links to existing files with names that
+       # match "*.so*". Matching *.so.* is not good enough because of
+       # broken crap like db3. And we only look at real files not
+       # symlinks, so we don't accidentually add shlibs data to -dev
+       # packages. This may have a few false positives, which is ok,
+       # because only if we can get a library name and a major number from
+       # objdump is anything actually added.
+       my $exclude='';
+       if (defined($dh{EXCLUDE_FIND}) && $dh{EXCLUDE_FIND} ne '') {
+               $exclude="! \\( $dh{EXCLUDE_FIND} \\) ";
+       }
+       open (FIND, "find $tmp -type f -name '*.so*' $exclude |");
        while (<FIND>) {
-               my $library;
-               my $major;
-       
-               chomp;
-               # The second evil regexp is for db3, whose author should
-               # be shot.
-               if (m#.*/([^/]*)\.so\.(\d*)\.?# || m#.*/([^/]*)-([^\s/]+)\.so$#) {
-                       $library = $1;
-                       $major = $2;
+               my ($library, $major);
+               my $objdump=`objdump -p $_`;
+               if ($objdump=~m/\s+SONAME\s+(.+)\.so\.(.+)/) {
+                       # proper soname format
+                       $library=$1;
+                       $major=$2;
                }
+               elsif ($objdump=~m/\s+SONAME\s+(.+)-(.+)\.so/) {
+                       # idiotic crap soname format
+                       $library=$1;
+                       $major=$2;
+               }
+
                if (defined($dh{M_PARAMS}) && $dh{M_PARAMS} ne '') {
                        $major=$dh{M_PARAMS};
                }
+               
                if (! -d "$tmp/DEBIAN") {
                        doit("install","-d","$tmp/DEBIAN");
                }
@@ -115,7 +136,14 @@ foreach my $package (@{$dh{DOPACKAGES}}) {
                                # Call isnative becuase it sets $dh{VERSION}
                                # as a side effect.
                                isnative($package);
-                               $deps="$package (>= $dh{VERSION})";
+                               my $version = $dh{VERSION};
+                               # Old compatability levels include the
+                               # debian revision, while new do not.
+                               if (! compat(3)) {
+                                       # Remove debian version, if any.
+                                       $version =~ s/-[^-]+$//;
+                               }
+                               $deps="$package (>= $version)";
                        }
                }
                if (defined($library) && defined($major) && defined($deps) &&