# specified or empty, defaults to the current directory.
# - builddir - specifies build directory to use. Path is relative to the
# current (top) directory. If undef or empty,
-# DEFAULT_BUILD_DIRECTORY directory will be used.
+# DEFAULT_BUILD_DIRECTORY directory will be used.
+# - parallel - max number of parallel processes to be spawned for building
+# sources (-1 = unlimited; 1 = no parallel)
# Derived class can override the constructor to initialize common object
# parameters. Do NOT use constructor to execute commands or otherwise
# configure/setup build environment. There is absolutely no guarantee the
my ($class, %opts)=@_;
my $this = bless({ sourcedir => '.',
- builddir => undef, }, $class);
+ builddir => undef,
+ parallel => undef,
+ cwd => Cwd::getcwd() }, $class);
if (exists $opts{sourcedir}) {
# Get relative sourcedir abs_path (without symlinks)
- my $curdir = Cwd::getcwd();
my $abspath = Cwd::abs_path($opts{sourcedir});
- if (! -d $abspath || $abspath !~ /^\Q$curdir\E/) {
+ if (! -d $abspath || $abspath !~ /^\Q$this->{cwd}\E/) {
error("invalid or non-existing path to the source directory: ".$opts{sourcedir});
}
- $this->{sourcedir} = File::Spec->abs2rel($abspath, $curdir);
+ $this->{sourcedir} = File::Spec->abs2rel($abspath, $this->{cwd});
}
if (exists $opts{builddir}) {
$this->_set_builddir($opts{builddir});
}
+ if (defined $opts{parallel}) {
+ $this->{parallel} = $opts{parallel};
+ }
return $this;
}
# unset the build directory.
sub _set_builddir {
my $this=shift;
- my $builddir=shift;
- $this->{builddir} = ($builddir) ? $builddir : $this->DEFAULT_BUILD_DIRECTORY;
-
- # Canonicalize. If build directory ends up the same as source directory, drop it
- if (defined $this->{builddir}) {
- $this->{builddir} = $this->_canonpath($this->{builddir});
- if ($this->{builddir} eq $this->get_sourcedir()) {
- $this->{builddir} = undef;
+ my $builddir=shift || $this->DEFAULT_BUILD_DIRECTORY;
+
+ if (defined $builddir) {
+ $builddir = $this->canonpath($builddir); # Canonicalize
+
+ # Sanitize $builddir
+ if ($builddir =~ m#^\.\./#) {
+ # We can't handle those as relative. Make them absolute
+ $builddir = File::Spec->catdir($this->{cwd}, $builddir);
+ }
+ elsif ($builddir =~ /\Q$this->{cwd}\E/) {
+ $builddir = File::Spec::abs2rel($builddir, $this->{cwd});
+ }
+
+ # If build directory ends up the same as source directory, drop it
+ if ($builddir eq $this->get_sourcedir()) {
+ $builddir = undef;
}
}
+ $this->{builddir} = $builddir;
+ return $builddir;
}
# This instance method is called to check if the build system is able
}
}
-# Derived class can call this method in its constructor to enforce
-# out of source building even if the user didn't request it. However,
-# if 'builddir' named parameter is passed, accept its value as the
-# build directory even if it matches the source directory (meaning out
-# of source is only prefered to in source, not enforced).
-sub enforce_out_of_source_building {
+# Derived class can call this method in its constructor to *prefer*
+# out of source building. Unless build directory has already been
+# specified building will proceed in the DEFAULT_BUILD_DIRECTORY or
+# the one specified in the 'builddir' named parameter (which may
+# match the source directory). Typically you should pass @_ from
+# the constructor to this call.
+sub prefer_out_of_source_building {
my $this=shift;
my %args=@_;
if (!defined $this->get_builddir()) {
- $this->_set_builddir($args{builddir});
- if (!defined $this->get_builddir() && !$args{builddir}) {
+ if (!$this->_set_builddir($args{builddir}) && !$args{builddir}) {
# If we are here, DEFAULT_BUILD_DIRECTORY matches
# the source directory, building might fail.
error("default build directory is the same as the source directory." .
# Enhanced version of File::Spec::canonpath. It collapses ..
# too so it may return invalid path if symlinks are involved.
# On the other hand, it does not need for the path to exist.
-sub _canonpath {
+sub canonpath {
my ($this, $path)=@_;
my @canon;
my $back=0;
return (@canon + $back > 0) ? join('/', ('..')x$back, @canon) : '.';
}
-# Given both $path and $base are relative to the same directory,
-# converts and returns path of $path being relative the $base.
+# Given both $path and $base are relative to the $root, converts and
+# returns path of $path being relative to the $base. If either $path or
+# $base is absolute, returns another $path (converted to) absolute.
sub _rel2rel {
my ($this, $path, $base, $root)=@_;
- $root = "/tmp" if !defined $root;
-
- return File::Spec->abs2rel(
- File::Spec->rel2abs($path, $root),
- File::Spec->rel2abs($base, $root)
- );
+ $root = $this->{cwd} unless defined $root;
+
+ if (File::Spec->file_name_is_absolute($path)) {
+ return $path;
+ }
+ elsif (File::Spec->file_name_is_absolute($base)) {
+ return File::Spec->rel2abs($path, $root);
+ }
+ else {
+ return File::Spec->abs2rel(
+ File::Spec->rel2abs($path, $root),
+ File::Spec->rel2abs($base, $root)
+ );
+ }
}
# Get path to the source directory
return $dir;
}
+sub get_parallel {
+ my $this=shift;
+ return $this->{parallel};
+}
+
# When given a relative path to the build directory, converts it
# to the path that is relative to the source directory. If $path is
# not given, returns a path to the build directory that is relative
my $this=shift;
if ($this->get_sourcedir() ne '.') {
my $sourcedir = $this->get_sourcedir();
- my $curdir = Cwd::getcwd();
$this->_cd($sourcedir);
doit(@_);
- $this->_cd($this->_rel2rel($curdir, $sourcedir, $curdir));
+ $this->_cd($this->_rel2rel($this->{cwd}, $sourcedir));
}
else {
doit(@_);
my $this=shift;
if ($this->get_buildpath() ne '.') {
my $buildpath = $this->get_buildpath();
- my $curdir = Cwd::getcwd();
$this->_cd($buildpath);
doit(@_);
- $this->_cd($this->_rel2rel($curdir, $buildpath, $curdir));
+ $this->_cd($this->_rel2rel($this->{cwd}, $buildpath));
}
else {
doit(@_);
my $only_empty=shift;
if ($this->get_builddir()) {
my $buildpath = $this->get_buildpath();
- if (-d $buildpath && ! $dh{NO_ACT}) {
- my @spdir = File::Spec->splitdir($this->get_build_rel2sourcedir());
+ if (-d $buildpath) {
+ my @dir = File::Spec->splitdir($this->get_build_rel2sourcedir());
my $peek;
- if (!$only_empty) {
+ if (not $only_empty) {
doit("rm", "-rf", $buildpath);
- pop @spdir;
+ pop @dir;
}
- # If build directory had 2 or more levels, delete empty
- # parent directories until the source directory level.
- while (($peek=pop(@spdir)) && $peek ne '.' && $peek ne '..') {
- last if ! rmdir($this->get_sourcepath(File::Spec->catdir(@spdir, $peek)));
+ # If build directory is relative and had 2 or more levels, delete
+ # empty parent directories until the source or top directory level.
+ if (not File::Spec->file_name_is_absolute($buildpath)) {
+ while (($peek=pop @dir) && $peek ne '.' && $peek ne '..') {
+ my $dir = $this->get_sourcepath(File::Spec->catdir(@dir, $peek));
+ doit("rmdir", "--ignore-fail-on-non-empty", $dir);
+ last if -d $dir;
+ }
}
}
return 1;