code review, added comments

[debhelper.git] / Debian / Debhelper / Buildsystem / cmake.pm

diff --git a/Debian/Debhelper/Buildsystem/cmake.pm b/Debian/Debhelper/Buildsystem/cmake.pm
index d7504d18784919cc2f930b4604a514b337ae8458..00f6be4d771ea0712dd7771fa3f9c0fec6e1d1ef 100644 (file)
--- a/Debian/Debhelper/Buildsystem/cmake.pm
+++ b/Debian/Debhelper/Buildsystem/cmake.pm
@@ -42,7 +42,12 @@ sub configure_impl {
        $self->_add_cmake_flag("CMAKE_SKIP_RPATH", "ON");
        $self->_add_cmake_flag("CMAKE_VERBOSE_MAKEFILE", "ON");
        # TODO: LDFLAGS
+       # XXX JEH why are we using a method and an object
+       # field to build up a simple one-time-use list?
+       #       my @flags;
+       #       push @flags, ... if $foo
 
+       # XXX JEH again a non-sequitor get_topdir. 
        doit("cmake", $self->get_topdir(), @{$self->{cmake_flags}}, @_);
 }