use MLDBM qw(DB_File Storable);
use Storable qw(dclone);
use Params::Validate qw(validate_with :types);
-use Debbugs::Common qw(make_list globify_scalar);
+use Debbugs::Common qw(make_list globify_scalar sort_versions);
use List::Util qw(min max);
In SCALAR context, only the corresponding source packages are
returned, concatenated with ', ' if necessary.
+If no source can be found, returns undef in scalar context, or the
+empty list in list context.
+
=over
=item binary -- binary package name(s) as a SCALAR or ARRAYREF
=cut
+# the two global variables below are used to tie the source maps; we
+# probably should be retying them in long lived processes.
our %_binarytosource;
+our %_sourcetobinary;
sub binary_to_source{
my %param = validate_with(params => \@_,
spec => {binary => {type => SCALAR|ARRAYREF,
}
# avoid autovivification
my $bin = $_binarytosource{$binary};
+ next unless defined $bin;
if (not @versions) {
- next unless defined $bin;
for my $ver (keys %{$bin}) {
for my $ar (keys %{$bin->{$ver}}) {
my $src = $bin->{$ver}{$ar};
tie %_sourcetobinary, MLDBM => $config{source_binary_map}, O_RDONLY or
die "Unable top open $gSourceBinaryMap for reading";
}
- for my $package (@package) {
- if (exists $_sourcetobinary{$package}) {
- push @source,[$package,$_] for keys %{$_sourcetobinary{$package}};
+ for my $maybe_sourcepkg (@binaries) {
+ if (exists $_sourcetobinary{$maybe_sourcepkg}) {
+ push @source,[$maybe_sourcepkg,$_] for keys %{$_sourcetobinary{$maybe_sourcepkg}};
}
}
# if @source is still empty here, it's probably a non-existant
if ($param{source_only}) {
my %uniq;
for my $s (@source) {
+ # we shouldn't need to do this, but do this temporarily to
+ # stop the warning.
+ next unless defined $s->[0];
$uniq{$s->[0]} = 1;
}
@result = sort keys %uniq;
=cut
-our %_sourcetobinary;
sub sourcetobinary {
my ($srcname, $srcver) = @_;
=item return_archs -- returns a version=>[archs] hash indicating which
architectures are at which versions.
+=item largest_source_version_only -- if there is more than one source
+version in a particular distribution, discards all versions but the
+largest in that distribution. Defaults to 1, as this used to be the
+way that the Debian archive worked.
+
=back
When called in scalar context, this function will return hashrefs or
return_archs => {type => BOOLEAN,
default => 0,
},
+ largest_source_version_only => {type => BOOLEAN,
+ default => 1,
+ },
},
);
my $versions;
}
my %versions;
for my $package (make_list($param{package})) {
+ my $source_only = 0;
+ if ($package =~ s/^src://) {
+ $source_only = 1;
+ }
my $version = $versions->{$package};
next unless defined $version;
for my $dist (make_list($param{dist})) {
make_list($param{arch}):
(grep {not $param{no_source_arch} or
$_ ne 'source'
- } keys %{$version->{$dist}})) {
+ } $source_only?'source':keys %{$version->{$dist}})) {
next unless defined $version->{$dist}{$arch};
- for my $ver (ref $version->{$dist}{$arch} ?
- keys %{$version->{$dist}{$arch}} :
- $version->{$dist}{$arch}
- ) {
+ my @vers = ref $version->{$dist}{$arch} eq 'HASH' ?
+ keys %{$version->{$dist}{$arch}} :
+ make_list($version->{$dist}{$arch});
+ if ($param{largest_source_version_only} and
+ $arch eq 'source' and @vers > 1) {
+ # order the versions, then pick the biggest version number
+ @vers = sort_versions(@vers);
+ @vers = $vers[-1];
+ }
+ for my $ver (@vers) {
my $f_ver = $ver;
if ($param{source}) {
($f_ver) = make_source_versions(package => $package,
my @bin_versions = sourcetobinary($1,$version);
if (not @bin_versions or
@{$bin_versions[0]} != 3) {
- print {$warnings} "The source $1 and version $2 do not appear to match any binary packages\n";
+ print {$warnings} "The source '$1' and version '$version' do not appear to match any binary packages\n";
}
next;
}
}
my @srcinfo = binary_to_source(binary => $pkg,
version => $version,
- arch => $arch);
+ length($arch)?(arch => $arch):());
if (not @srcinfo) {
# We don't have explicit information about the
# binary-to-source mapping for this version