=head1 NAME CodingStyle - standards while programming for GNU LilyPond =head1 DESCRIPTION Please use these standards while doing programming for GNU LilyPond Functions and methods do not return errorcodes, but use assert for checking status. =head2 Quote: A program should be light and agile, its subroutines connected like a strings of pearls. The spirit and intent of the program should be retained throughout. There should be neither too little nor too much, neither needless loops nor useless variables, neither lack of structure nor overwhelming rigidity. A program should follow the 'Law of Least Astonishment'. What is this law? It is simply that the program should always respond to the user in the way that astonishes him least. A program, no matter how complex, should act as a single unit. The program should be directed by the logic within rather than by outward appearances. If the program fails in these requirements, it will be in a state of disorder and confusion. The only way to correct this is to rewrite the program. -- Geoffrey James, "The Tao of Programming" =head2 FILES Definitions of classes that are only accessed via pointers (*) or references (&) shall not be included as include files. Include files in C++ always have the file name extension ".hh". Implementation files in C++ always have the file name extension ".cc". Inline definition files always have the file name extension ".icc". =head2 INDENTATION in emacs: (add-hook 'c-mode-hook '(lambda ()(setq c-basic-offset 4))) (add-hook 'c++-mode-hook '(lambda() (c-set-style "Stroustrup") ) ) If you like using font-lock, you can also add this to your F<.emacs>: (setq font-lock-maximum-decoration t) (setq c++-font-lock-keywords-3 (append c++-font-lock-keywords-3 '(("\\b\\([a-zA-Z_]+_\\)\\b" 1 font-lock-variable-name-face) ("\\b\\([A-Z]+[a-z_]+\\)\\b" 1 font-lock-type-face)) )) =head2 CLASSES and TYPES: This_is_a_class AClass_name (for Abbreviation_class_name) =head2 DATA MEMBERS Class::member() Type Class::member_type_ the C is a Hungarian notation postfix for C. See below =head2 BROKEN CODE Broken code (hardwired dependencies, hardwired constants, slow algorithms and obvious limitations) should be marked as such: either with a verbose TODO, or with a short "ugh" comment. =head2 COMMENTS The source is commented in the DOC++ style. Check out doc++ at http://www.zib.de/Visual/software/doc++/index.html /* C style comments for multiline comments. They come before the thing to document. [...] */ /** short description. Long class documentation. (Hungarian postfix) TODO Fix boring_member() */ class Class { /** short description. long description */ Data data_member_; /** short memo. long doco of member() @param description of arguments @return Rettype */ Rettype member(Argtype); /// memo only boring_member() { data_member_ = 121; // ugh } }; Unfortunately most of the code isn't really documented that good. =head2 CLASSNAMES (2) A lot of classes in GNU LilyPond start with 'P', this is to distinguish certain parts of GNU LilyPond: the P stands for Printer, and the P-classes are supposed to be more lowlevel than the others. Example: Staff uses PStaff, PScore and PCol to do the typesetting of symbols. Staff is the "brains" for PStaff NB: in PCursor (which is part of the library) P stands for PointerCursor =head2 MEMBERS (2) Standard methods: ///check that *this satisfies its invariants, abort if not. void OK() const /// print *this (and substructures) to debugging log void print() const /** protected member. Usually invoked by non-virtual XXXX() */ virtual do_XXXX() /**add some data to *this. Presence of these methods usually imply that it is not feasible to this via a constructor */ add( .. ) /// replace some data of *this set( .. ) =head1 HUNGARIAN NOTATION NAMING CONVENTION Proposed is a naming convention derived from the so-called I. =head2 Hungarian The Hungarian Notation was conceived by or at least got its name from, the hungarian programmer Charles Simonyi. It is a naming convention with the aim to make code more readable (for fellow programmers), and more accessible for programmers that are new to a project. The essence of the Hungarian Notation is that every identifier has a part which identifies its type (for functions this is the result type). This is particularly useful in object oriented programming, where a particular object implies a specific interface (a set of member functions, perhaps some redefined operators), and for accounting heap allocated memory pointers and links. =head2 Advantages Another fun quote from Microsoft Secrets: The Hungarian naming convention gives developers the ability to read other people's code relatively easily, with a minmum number of comments in the source code. Jon De Vann estimated that only about 1 percent of all lines in the Excel product code consist of comments, but the code is still very understandable due to the use of Hungarian: "if you look at our source code, you also notice very few comments. Hungarian gives us the ability to go in and read code..." Wow! If you use Hungarian you don't have to document your software! Just think of the hours I have wasted documenting while this "silver bullet" existed. I feel so stupid and ashamed! =head2 Disadvantages =over 5 =item * more keystrokes (disk space!) =item * it looks silly C =item * it looks like code from micro suckers =item * (which) might scare away some (otherwise good?) progammers, or make you a paria in the free software community =item * it has ambiguities =item * not very useful if not used consistently =item * usefullness in I (but how many classes is very large?) remains an issue. =back =head2 Proposal =over 5 =item * learn about cut and paste / use emacs or vi or lean to type using ten fingers =item * Use emacs dabbrev-expand, with dabbrev-case-fold-search set to nil. =item * use no, or pick less silly, abbrvs. =item * use non-ambiguous postfixes C =back Macros, Cs and Cs are all uppercase, with the parts of the names separated by underscores. =head2 Types =over 5 =item C unsigned char. (The postfix _by is ambiguous) =item C bool =item C bit =item C char =item C float =item C signed integer =item C string class =item C Zero terminated c string =item C unsigned integer =back =head2 User defined types /** Slur blah. blah. (slur) */ class Slur {}; Slur* slur_p = new Slur; =head2 Modifiers The following types modify the meaning of the prefix. These are precede the prefixes: =over 5 =item C array =item C user built array. =item C const. Note that the proper order C i.s.o. C =item C A const pointer. This would be equivalent to C<_c_l>, but since any "const" pointer has to be a link (you can't delete a const pointer), it is superfluous. =item C temporary pointer to object (link) =item C

pointer to newed object =item C reference =back =over 5 =item C Variable loop: an integer =item C Temporary variable: an unsigned integer =item C Variable test: a character =item C Variable first_name: a String class object =item C Variable last_name: a C array =item C Variable foo: an C that you must delete =item C Variable bar: an C that you must not delete =back Generally default arguments are taboo, except for nil pointers.