daklib/queue.py

   1 #!/usr/bin/env python
   2 # vim:set et sw=4:
   3
   4 """
   5 Queue utility functions for dak
   6
   7 @contact: Debian FTP Master <ftpmaster@debian.org>
   8 @copyright: 2001 - 2006 James Troup <james@nocrew.org>
   9 @copyright: 2009, 2010  Joerg Jaspert <joerg@debian.org>
  10 @license: GNU General Public License version 2 or later
  11 """
  12
  13 # This program is free software; you can redistribute it and/or modify
  14 # it under the terms of the GNU General Public License as published by
  15 # the Free Software Foundation; either version 2 of the License, or
  16 # (at your option) any later version.
  17
  18 # This program is distributed in the hope that it will be useful,
  19 # but WITHOUT ANY WARRANTY; without even the implied warranty of
  20 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  21 # GNU General Public License for more details.
  22
  23 # You should have received a copy of the GNU General Public License
  24 # along with this program; if not, write to the Free Software
  25 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  26
  27 ###############################################################################
  28
  29 import errno
  30 import os
  31 import stat
  32 import sys
  33 import time
  34 import apt_inst
  35 import apt_pkg
  36 import utils
  37 import commands
  38 import shutil
  39 import textwrap
  40 from types import *
  41 from sqlalchemy.sql.expression import desc
  42 from sqlalchemy.orm.exc import NoResultFound
  43
  44 import yaml
  45
  46 from dak_exceptions import *
  47 from changes import *
  48 from regexes import *
  49 from config import Config
  50 from holding import Holding
  51 from urgencylog import UrgencyLog
  52 from dbconn import *
  53 from summarystats import SummaryStats
  54 from utils import parse_changes, check_dsc_files, build_package_set
  55 from textutils import fix_maintainer
  56 from lintian import parse_lintian_output, generate_reject_messages
  57 from contents import UnpackedSource
  58
  59 ###############################################################################
  60
  61 def get_type(f, session):
  62     """
  63     Get the file type of C{f}
  64
  65     @type f: dict
  66     @param f: file entry from Changes object
  67
  68     @type session: SQLA Session
  69     @param session: SQL Alchemy session object
  70
  71     @rtype: string
  72     @return: filetype
  73
  74     """
  75     # Determine the type
  76     if f.has_key("dbtype"):
  77         file_type = f["dbtype"]
  78     elif re_source_ext.match(f["type"]):
  79         file_type = "dsc"
  80     elif f['architecture'] == 'source' and f["type"] == 'unreadable':
  81         utils.warn('unreadable source file (will continue and hope for the best)')
  82         return f["type"]
  83     else:
  84         file_type = f["type"]
  85         utils.fubar("invalid type (%s) for new.  Dazed, confused and sure as heck not continuing." % (file_type))
  86
  87     # Validate the override type
  88     type_id = get_override_type(file_type, session)
  89     if type_id is None:
  90         utils.fubar("invalid type (%s) for new.  Say wha?" % (file_type))
  91
  92     return file_type
  93
  94 ################################################################################
  95
  96 # Determine what parts in a .changes are NEW
  97
  98 def determine_new(filename, changes, files, warn=1, session = None, dsc = None, new = None):
  99     """
 100     Determine what parts in a C{changes} file are NEW.
 101
 102     @type filename: str
 103     @param filename: changes filename
 104
 105     @type changes: Upload.Pkg.changes dict
 106     @param changes: Changes dictionary
 107
 108     @type files: Upload.Pkg.files dict
 109     @param files: Files dictionary
 110
 111     @type warn: bool
 112     @param warn: Warn if overrides are added for (old)stable
 113
 114     @type dsc: Upload.Pkg.dsc dict
 115     @param dsc: (optional); Dsc dictionary
 116
 117     @type new: dict
 118     @param new: new packages as returned by a previous call to this function, but override information may have changed
 119
 120     @rtype: dict
 121     @return: dictionary of NEW components.
 122
 123     """
 124     # TODO: This should all use the database instead of parsing the changes
 125     # file again
 126     byhand = {}
 127     if new is None:
 128         new = {}
 129
 130     dbchg = get_dbchange(filename, session)
 131     if dbchg is None:
 132         print "Warning: cannot find changes file in database; won't check byhand"
 133
 134     # Try to get the Package-Set field from an included .dsc file (if possible).
 135     if dsc:
 136         for package, entry in build_package_set(dsc, session).items():
 137             if not new.has_key(package):
 138                 new[package] = entry
 139
 140     # Build up a list of potentially new things
 141     for name, f in files.items():
 142         # Keep a record of byhand elements
 143         if f["section"] == "byhand":
 144             byhand[name] = 1
 145             continue
 146
 147         pkg = f["package"]
 148         priority = f["priority"]
 149         section = f["section"]
 150         file_type = get_type(f, session)
 151         component = f["component"]
 152
 153         if file_type == "dsc":
 154             priority = "source"
 155
 156         if not new.has_key(pkg):
 157             new[pkg] = {}
 158             new[pkg]["priority"] = priority
 159             new[pkg]["section"] = section
 160             new[pkg]["type"] = file_type
 161             new[pkg]["component"] = component
 162             new[pkg]["files"] = []
 163         else:
 164             old_type = new[pkg]["type"]
 165             if old_type != file_type:
 166                 # source gets trumped by deb or udeb
 167                 if old_type == "dsc":
 168                     new[pkg]["priority"] = priority
 169                     new[pkg]["section"] = section
 170                     new[pkg]["type"] = file_type
 171                     new[pkg]["component"] = component
 172
 173         new[pkg]["files"].append(name)
 174
 175         if f.has_key("othercomponents"):
 176             new[pkg]["othercomponents"] = f["othercomponents"]
 177
 178     # Fix up the list of target suites
 179     cnf = Config()
 180     for suite in changes["suite"].keys():
 181         oldsuite = get_suite(suite, session)
 182         if not oldsuite:
 183             print "WARNING: Invalid suite %s found" % suite
 184             continue
 185
 186         if oldsuite.overridesuite:
 187             newsuite = get_suite(oldsuite.overridesuite, session)
 188
 189             if newsuite:
 190                 print "INFORMATION: Using overrides from suite %s instead of suite %s" % (
 191                     oldsuite.overridesuite, suite)
 192                 del changes["suite"][suite]
 193                 changes["suite"][oldsuite.overridesuite] = 1
 194             else:
 195                 print "WARNING: Told to use overridesuite %s for %s but it doesn't exist.  Bugger" % (
 196                     oldsuite.overridesuite, suite)
 197
 198     # Check for unprocessed byhand files
 199     if dbchg is not None:
 200         for b in byhand.keys():
 201             # Find the file entry in the database
 202             found = False
 203             for f in dbchg.files:
 204                 if f.filename == b:
 205                     found = True
 206                     # If it's processed, we can ignore it
 207                     if f.processed:
 208                         del byhand[b]
 209                     break
 210
 211             if not found:
 212                 print "Warning: Couldn't find BYHAND item %s in the database; assuming unprocessed"
 213
 214     # Check for new stuff
 215     for suite in changes["suite"].keys():
 216         for pkg in new.keys():
 217             ql = get_override(pkg, suite, new[pkg]["component"], new[pkg]["type"], session)
 218             if len(ql) > 0:
 219                 for file_entry in new[pkg]["files"]:
 220                     if files[file_entry].has_key("new"):
 221                         del files[file_entry]["new"]
 222                 del new[pkg]
 223
 224     if warn:
 225         for s in ['stable', 'oldstable']:
 226             if changes["suite"].has_key(s):
 227                 print "WARNING: overrides will be added for %s!" % s
 228         for pkg in new.keys():
 229             if new[pkg].has_key("othercomponents"):
 230                 print "WARNING: %s already present in %s distribution." % (pkg, new[pkg]["othercomponents"])
 231
 232     return new, byhand
 233
 234 ################################################################################
 235
 236 def check_valid(new, session = None):
 237     """
 238     Check if section and priority for NEW packages exist in database.
 239     Additionally does sanity checks:
 240       - debian-installer packages have to be udeb (or source)
 241       - non debian-installer packages can not be udeb
 242       - source priority can only be assigned to dsc file types
 243
 244     @type new: dict
 245     @param new: Dict of new packages with their section, priority and type.
 246
 247     """
 248     for pkg in new.keys():
 249         section_name = new[pkg]["section"]
 250         priority_name = new[pkg]["priority"]
 251         file_type = new[pkg]["type"]
 252
 253         section = get_section(section_name, session)
 254         if section is None:
 255             new[pkg]["section id"] = -1
 256         else:
 257             new[pkg]["section id"] = section.section_id
 258
 259         priority = get_priority(priority_name, session)
 260         if priority is None:
 261             new[pkg]["priority id"] = -1
 262         else:
 263             new[pkg]["priority id"] = priority.priority_id
 264
 265         # Sanity checks
 266         di = section_name.find("debian-installer") != -1
 267
 268         # If d-i, we must be udeb and vice-versa
 269         if     (di and file_type not in ("udeb", "dsc")) or \
 270            (not di and file_type == "udeb"):
 271             new[pkg]["section id"] = -1
 272
 273         # If dsc we need to be source and vice-versa
 274         if (priority == "source" and file_type != "dsc") or \
 275            (priority != "source" and file_type == "dsc"):
 276             new[pkg]["priority id"] = -1
 277
 278 ###############################################################################
 279
 280 # Used by Upload.check_timestamps
 281 class TarTime(object):
 282     def __init__(self, future_cutoff, past_cutoff):
 283         self.reset()
 284         self.future_cutoff = future_cutoff
 285         self.past_cutoff = past_cutoff
 286
 287     def reset(self):
 288         self.future_files = {}
 289         self.ancient_files = {}
 290
 291     def callback(self, member, data):
 292         if member.mtime > self.future_cutoff:
 293             self.future_files[Name] = MTime
 294         if member.mtime < self.past_cutoff:
 295             self.ancient_files[Name] = MTime
 296
 297 ###############################################################################
 298
 299 def prod_maintainer(notes, upload):
 300     cnf = Config()
 301
 302     # Here we prepare an editor and get them ready to prod...
 303     (fd, temp_filename) = utils.temp_filename()
 304     temp_file = os.fdopen(fd, 'w')
 305     for note in notes:
 306         temp_file.write(note.comment)
 307     temp_file.close()
 308     editor = os.environ.get("EDITOR","vi")
 309     answer = 'E'
 310     while answer == 'E':
 311         os.system("%s %s" % (editor, temp_filename))
 312         temp_fh = utils.open_file(temp_filename)
 313         prod_message = "".join(temp_fh.readlines())
 314         temp_fh.close()
 315         print "Prod message:"
 316         print utils.prefix_multi_line_string(prod_message,"  ",include_blank_lines=1)
 317         prompt = "[P]rod, Edit, Abandon, Quit ?"
 318         answer = "XXX"
 319         while prompt.find(answer) == -1:
 320             answer = utils.our_raw_input(prompt)
 321             m = re_default_answer.search(prompt)
 322             if answer == "":
 323                 answer = m.group(1)
 324             answer = answer[:1].upper()
 325     os.unlink(temp_filename)
 326     if answer == 'A':
 327         return
 328     elif answer == 'Q':
 329         end()
 330         sys.exit(0)
 331     # Otherwise, do the proding...
 332     user_email_address = utils.whoami() + " <%s>" % (
 333         cnf["Dinstall::MyAdminAddress"])
 334
 335     Subst = upload.Subst
 336
 337     Subst["__FROM_ADDRESS__"] = user_email_address
 338     Subst["__PROD_MESSAGE__"] = prod_message
 339     Subst["__CC__"] = "Cc: " + cnf["Dinstall::MyEmailAddress"]
 340
 341     prod_mail_message = utils.TemplateSubst(
 342         Subst,cnf["Dir::Templates"]+"/process-new.prod")
 343
 344     # Send the prod mail
 345     utils.send_mail(prod_mail_message)
 346
 347     print "Sent prodding message"
 348
 349 ################################################################################
 350
 351 def edit_note(note, upload, session, trainee=False):
 352     # Write the current data to a temporary file
 353     (fd, temp_filename) = utils.temp_filename()
 354     editor = os.environ.get("EDITOR","vi")
 355     answer = 'E'
 356     while answer == 'E':
 357         os.system("%s %s" % (editor, temp_filename))
 358         temp_file = utils.open_file(temp_filename)
 359         newnote = temp_file.read().rstrip()
 360         temp_file.close()
 361         print "New Note:"
 362         print utils.prefix_multi_line_string(newnote,"  ")
 363         prompt = "[D]one, Edit, Abandon, Quit ?"
 364         answer = "XXX"
 365         while prompt.find(answer) == -1:
 366             answer = utils.our_raw_input(prompt)
 367             m = re_default_answer.search(prompt)
 368             if answer == "":
 369                 answer = m.group(1)
 370             answer = answer[:1].upper()
 371     os.unlink(temp_filename)
 372     if answer == 'A':
 373         return
 374     elif answer == 'Q':
 375         end()
 376         sys.exit(0)
 377
 378     comment = NewComment()
 379     comment.package = upload.pkg.changes["source"]
 380     comment.version = upload.pkg.changes["version"]
 381     comment.comment = newnote
 382     comment.author  = utils.whoami()
 383     comment.trainee = trainee
 384     session.add(comment)
 385     session.commit()
 386
 387 ###############################################################################
 388
 389 # suite names DMs can upload to
 390 dm_suites = ['unstable', 'experimental']
 391
 392 def get_newest_source(source, session):
 393     'returns the newest DBSource object in dm_suites'
 394     ## the most recent version of the package uploaded to unstable or
 395     ## experimental includes the field "DM-Upload-Allowed: yes" in the source
 396     ## section of its control file
 397     q = session.query(DBSource).filter_by(source = source). \
 398         filter(DBSource.suites.any(Suite.suite_name.in_(dm_suites))). \
 399         order_by(desc('source.version'))
 400     return q.first()
 401
 402 def get_suite_version_by_source(source, session):
 403     'returns a list of tuples (suite_name, version) for source package'
 404     q = session.query(Suite.suite_name, DBSource.version). \
 405         join(Suite.sources).filter_by(source = source)
 406     return q.all()
 407
 408 def get_source_by_package_and_suite(package, suite_name, session):
 409     '''
 410     returns a DBSource query filtered by DBBinary.package and this package's
 411     suite_name
 412     '''
 413     return session.query(DBSource). \
 414         join(DBSource.binaries).filter_by(package = package). \
 415         join(DBBinary.suites).filter_by(suite_name = suite_name)
 416
 417 def get_suite_version_by_package(package, arch_string, session):
 418     '''
 419     returns a list of tuples (suite_name, version) for binary package and
 420     arch_string
 421     '''
 422     return session.query(Suite.suite_name, DBBinary.version). \
 423         join(Suite.binaries).filter_by(package = package). \
 424         join(DBBinary.architecture). \
 425         filter(Architecture.arch_string.in_([arch_string, 'all'])).all()
 426
 427 class Upload(object):
 428     """
 429     Everything that has to do with an upload processed.
 430
 431     """
 432     def __init__(self):
 433         self.logger = None
 434         self.pkg = Changes()
 435         self.reset()
 436
 437     ###########################################################################
 438
 439     def reset (self):
 440         """ Reset a number of internal variables."""
 441
 442         # Initialize the substitution template map
 443         cnf = Config()
 444         self.Subst = {}
 445         self.Subst["__ADMIN_ADDRESS__"] = cnf["Dinstall::MyAdminAddress"]
 446         if cnf.has_key("Dinstall::BugServer"):
 447             self.Subst["__BUG_SERVER__"] = cnf["Dinstall::BugServer"]
 448         self.Subst["__DISTRO__"] = cnf["Dinstall::MyDistribution"]
 449         self.Subst["__DAK_ADDRESS__"] = cnf["Dinstall::MyEmailAddress"]
 450
 451         self.rejects = []
 452         self.warnings = []
 453         self.notes = []
 454
 455         self.later_check_files = []
 456
 457         self.pkg.reset()
 458
 459     def package_info(self):
 460         """
 461         Format various messages from this Upload to send to the maintainer.
 462         """
 463
 464         msgs = (
 465             ('Reject Reasons', self.rejects),
 466             ('Warnings', self.warnings),
 467             ('Notes', self.notes),
 468         )
 469
 470         msg = ''
 471         for title, messages in msgs:
 472             if messages:
 473                 msg += '\n\n%s:\n%s' % (title, '\n'.join(messages))
 474         msg += '\n\n'
 475
 476         return msg
 477
 478     ###########################################################################
 479     def update_subst(self):
 480         """ Set up the per-package template substitution mappings """
 481
 482         cnf = Config()
 483
 484         # If 'dak process-unchecked' crashed out in the right place, architecture may still be a string.
 485         if not self.pkg.changes.has_key("architecture") or not \
 486            isinstance(self.pkg.changes["architecture"], dict):
 487             self.pkg.changes["architecture"] = { "Unknown" : "" }
 488
 489         # and maintainer2047 may not exist.
 490         if not self.pkg.changes.has_key("maintainer2047"):
 491             self.pkg.changes["maintainer2047"] = cnf["Dinstall::MyEmailAddress"]
 492
 493         self.Subst["__ARCHITECTURE__"] = " ".join(self.pkg.changes["architecture"].keys())
 494         self.Subst["__CHANGES_FILENAME__"] = os.path.basename(self.pkg.changes_file)
 495         self.Subst["__FILE_CONTENTS__"] = self.pkg.changes.get("filecontents", "")
 496
 497         # For source uploads the Changed-By field wins; otherwise Maintainer wins.
 498         if self.pkg.changes["architecture"].has_key("source") and \
 499            self.pkg.changes["changedby822"] != "" and \
 500            (self.pkg.changes["changedby822"] != self.pkg.changes["maintainer822"]):
 501
 502             self.Subst["__MAINTAINER_FROM__"] = self.pkg.changes["changedby2047"]
 503             self.Subst["__MAINTAINER_TO__"] = "%s, %s" % (self.pkg.changes["changedby2047"], self.pkg.changes["maintainer2047"])
 504             self.Subst["__MAINTAINER__"] = self.pkg.changes.get("changed-by", "Unknown")
 505         else:
 506             self.Subst["__MAINTAINER_FROM__"] = self.pkg.changes["maintainer2047"]
 507             self.Subst["__MAINTAINER_TO__"] = self.pkg.changes["maintainer2047"]
 508             self.Subst["__MAINTAINER__"] = self.pkg.changes.get("maintainer", "Unknown")
 509
 510         # Process policy doesn't set the fingerprint field and I don't want to make it
 511         # do it for now as I don't want to have to deal with the case where we accepted
 512         # the package into PU-NEW, but the fingerprint has gone away from the keyring in
 513         # the meantime so the package will be remarked as rejectable.  Urgh.
 514         # TODO: Fix this properly
 515         if self.pkg.changes.has_key('fingerprint'):
 516             session = DBConn().session()
 517             fpr = get_fingerprint(self.pkg.changes['fingerprint'], session)
 518             if fpr and self.check_if_upload_is_sponsored("%s@debian.org" % fpr.uid.uid, fpr.uid.name):
 519                 if self.pkg.changes.has_key("sponsoremail"):
 520                     self.Subst["__MAINTAINER_TO__"] += ", %s" % self.pkg.changes["sponsoremail"]
 521             session.close()
 522
 523         if cnf.has_key("Dinstall::TrackingServer") and self.pkg.changes.has_key("source"):
 524             self.Subst["__MAINTAINER_TO__"] += "\nBcc: %s@%s" % (self.pkg.changes["source"], cnf["Dinstall::TrackingServer"])
 525
 526         # Apply any global override of the Maintainer field
 527         if cnf.get("Dinstall::OverrideMaintainer"):
 528             self.Subst["__MAINTAINER_TO__"] = cnf["Dinstall::OverrideMaintainer"]
 529             self.Subst["__MAINTAINER_FROM__"] = cnf["Dinstall::OverrideMaintainer"]
 530
 531         self.Subst["__REJECT_MESSAGE__"] = self.package_info()
 532         self.Subst["__SOURCE__"] = self.pkg.changes.get("source", "Unknown")
 533         self.Subst["__VERSION__"] = self.pkg.changes.get("version", "Unknown")
 534         self.Subst["__SUITE__"] = ", ".join(self.pkg.changes["distribution"])
 535
 536     ###########################################################################
 537     def load_changes(self, filename):
 538         """
 539         Load a changes file and setup a dictionary around it. Also checks for mandantory
 540         fields  within.
 541
 542         @type filename: string
 543         @param filename: Changes filename, full path.
 544
 545         @rtype: boolean
 546         @return: whether the changes file was valid or not.  We may want to
 547                  reject even if this is True (see what gets put in self.rejects).
 548                  This is simply to prevent us even trying things later which will
 549                  fail because we couldn't properly parse the file.
 550         """
 551         Cnf = Config()
 552         self.pkg.changes_file = filename
 553
 554         # Parse the .changes field into a dictionary
 555         try:
 556             self.pkg.changes.update(parse_changes(filename))
 557         except CantOpenError:
 558             self.rejects.append("%s: can't read file." % (filename))
 559             return False
 560         except ParseChangesError as line:
 561             self.rejects.append("%s: parse error, can't grok: %s." % (filename, line))
 562             return False
 563         except ChangesUnicodeError:
 564             self.rejects.append("%s: changes file not proper utf-8" % (filename))
 565             return False
 566
 567         # Parse the Files field from the .changes into another dictionary
 568         try:
 569             self.pkg.files.update(utils.build_file_list(self.pkg.changes))
 570         except ParseChangesError as line:
 571             self.rejects.append("%s: parse error, can't grok: %s." % (filename, line))
 572             return False
 573         except UnknownFormatError as format:
 574             self.rejects.append("%s: unknown format '%s'." % (filename, format))
 575             return False
 576
 577         # Check for mandatory fields
 578         for i in ("distribution", "source", "binary", "architecture",
 579                   "version", "maintainer", "files", "changes", "description"):
 580             if not self.pkg.changes.has_key(i):
 581                 # Avoid undefined errors later
 582                 self.rejects.append("%s: Missing mandatory field `%s'." % (filename, i))
 583                 return False
 584
 585         # Strip a source version in brackets from the source field
 586         if re_strip_srcver.search(self.pkg.changes["source"]):
 587             self.pkg.changes["source"] = re_strip_srcver.sub('', self.pkg.changes["source"])
 588
 589         # Ensure the source field is a valid package name.
 590         if not re_valid_pkg_name.match(self.pkg.changes["source"]):
 591             self.rejects.append("%s: invalid source name '%s'." % (filename, self.pkg.changes["source"]))
 592
 593         # Split multi-value fields into a lower-level dictionary
 594         for i in ("architecture", "distribution", "binary", "closes"):
 595             o = self.pkg.changes.get(i, "")
 596             if o != "":
 597                 del self.pkg.changes[i]
 598
 599             self.pkg.changes[i] = {}
 600
 601             for j in o.split():
 602                 self.pkg.changes[i][j] = 1
 603
 604         # Fix the Maintainer: field to be RFC822/2047 compatible
 605         try:
 606             (self.pkg.changes["maintainer822"],
 607              self.pkg.changes["maintainer2047"],
 608              self.pkg.changes["maintainername"],
 609              self.pkg.changes["maintaineremail"]) = \
 610                    fix_maintainer (self.pkg.changes["maintainer"])
 611         except ParseMaintError as msg:
 612             self.rejects.append("%s: Maintainer field ('%s') failed to parse: %s" \
 613                    % (filename, self.pkg.changes["maintainer"], msg))
 614
 615         # ...likewise for the Changed-By: field if it exists.
 616         try:
 617             (self.pkg.changes["changedby822"],
 618              self.pkg.changes["changedby2047"],
 619              self.pkg.changes["changedbyname"],
 620              self.pkg.changes["changedbyemail"]) = \
 621                    fix_maintainer (self.pkg.changes.get("changed-by", ""))
 622         except ParseMaintError as msg:
 623             self.pkg.changes["changedby822"] = ""
 624             self.pkg.changes["changedby2047"] = ""
 625             self.pkg.changes["changedbyname"] = ""
 626             self.pkg.changes["changedbyemail"] = ""
 627
 628             self.rejects.append("%s: Changed-By field ('%s') failed to parse: %s" \
 629                    % (filename, self.pkg.changes["changed-by"], msg))
 630
 631         # Ensure all the values in Closes: are numbers
 632         if self.pkg.changes.has_key("closes"):
 633             for i in self.pkg.changes["closes"].keys():
 634                 if re_isanum.match (i) == None:
 635                     self.rejects.append(("%s: `%s' from Closes field isn't a number." % (filename, i)))
 636
 637         # chopversion = no epoch; chopversion2 = no epoch and no revision (e.g. for .orig.tar.gz comparison)
 638         self.pkg.changes["chopversion"] = re_no_epoch.sub('', self.pkg.changes["version"])
 639         self.pkg.changes["chopversion2"] = re_no_revision.sub('', self.pkg.changes["chopversion"])
 640
 641         # Check the .changes is non-empty
 642         if not self.pkg.files:
 643             self.rejects.append("%s: nothing to do (Files field is empty)." % (os.path.basename(self.pkg.changes_file)))
 644             return False
 645
 646         # Changes was syntactically valid even if we'll reject
 647         return True
 648
 649     ###########################################################################
 650
 651     def check_distributions(self):
 652         "Check and map the Distribution field"
 653
 654         Cnf = Config()
 655
 656         # Handle suite mappings
 657         for m in Cnf.ValueList("SuiteMappings"):
 658             args = m.split()
 659             mtype = args[0]
 660             if mtype == "map" or mtype == "silent-map":
 661                 (source, dest) = args[1:3]
 662                 if self.pkg.changes["distribution"].has_key(source):
 663                     del self.pkg.changes["distribution"][source]
 664                     self.pkg.changes["distribution"][dest] = 1
 665                     if mtype != "silent-map":
 666                         self.notes.append("Mapping %s to %s." % (source, dest))
 667                 if self.pkg.changes.has_key("distribution-version"):
 668                     if self.pkg.changes["distribution-version"].has_key(source):
 669                         self.pkg.changes["distribution-version"][source]=dest
 670             elif mtype == "map-unreleased":
 671                 (source, dest) = args[1:3]
 672                 if self.pkg.changes["distribution"].has_key(source):
 673                     for arch in self.pkg.changes["architecture"].keys():
 674                         if arch not in [ a.arch_string for a in get_suite_architectures(source) ]:
 675                             self.notes.append("Mapping %s to %s for unreleased architecture %s." % (source, dest, arch))
 676                             del self.pkg.changes["distribution"][source]
 677                             self.pkg.changes["distribution"][dest] = 1
 678                             break
 679             elif mtype == "ignore":
 680                 suite = args[1]
 681                 if self.pkg.changes["distribution"].has_key(suite):
 682                     del self.pkg.changes["distribution"][suite]
 683                     self.warnings.append("Ignoring %s as a target suite." % (suite))
 684             elif mtype == "reject":
 685                 suite = args[1]
 686                 if self.pkg.changes["distribution"].has_key(suite):
 687                     self.rejects.append("Uploads to %s are not accepted." % (suite))
 688             elif mtype == "propup-version":
 689                 # give these as "uploaded-to(non-mapped) suites-to-add-when-upload-obsoletes"
 690                 #
 691                 # changes["distribution-version"] looks like: {'testing': 'testing-proposed-updates'}
 692                 if self.pkg.changes["distribution"].has_key(args[1]):
 693                     self.pkg.changes.setdefault("distribution-version", {})
 694                     for suite in args[2:]:
 695                         self.pkg.changes["distribution-version"][suite] = suite
 696
 697         # Ensure there is (still) a target distribution
 698         if len(self.pkg.changes["distribution"].keys()) < 1:
 699             self.rejects.append("No valid distribution remaining.")
 700
 701         # Ensure target distributions exist
 702         for suite in self.pkg.changes["distribution"].keys():
 703             if not get_suite(suite.lower()):
 704                 self.rejects.append("Unknown distribution `%s'." % (suite))
 705
 706     ###########################################################################
 707
 708     def binary_file_checks(self, f, session):
 709         cnf = Config()
 710         entry = self.pkg.files[f]
 711
 712         # Extract package control information
 713         deb_file = utils.open_file(f)
 714         try:
 715             control = apt_pkg.ParseSection(apt_inst.debExtractControl(deb_file))
 716         except:
 717             self.rejects.append("%s: debExtractControl() raised %s." % (f, sys.exc_type))
 718             deb_file.close()
 719             # Can't continue, none of the checks on control would work.
 720             return
 721
 722         # Check for mandantory "Description:"
 723         deb_file.seek(0)
 724         try:
 725             apt_pkg.ParseSection(apt_inst.debExtractControl(deb_file))["Description"] + '\n'
 726         except:
 727             self.rejects.append("%s: Missing Description in binary package" % (f))
 728             return
 729
 730         deb_file.close()
 731
 732         # Check for mandatory fields
 733         for field in [ "Package", "Architecture", "Version" ]:
 734             if control.Find(field) == None:
 735                 # Can't continue
 736                 self.rejects.append("%s: No %s field in control." % (f, field))
 737                 return
 738
 739         # Ensure the package name matches the one give in the .changes
 740         if not self.pkg.changes["binary"].has_key(control.Find("Package", "")):
 741             self.rejects.append("%s: control file lists name as `%s', which isn't in changes file." % (f, control.Find("Package", "")))
 742
 743         # Validate the package field
 744         package = control.Find("Package")
 745         if not re_valid_pkg_name.match(package):
 746             self.rejects.append("%s: invalid package name '%s'." % (f, package))
 747
 748         # Validate the version field
 749         version = control.Find("Version")
 750         if not re_valid_version.match(version):
 751             self.rejects.append("%s: invalid version number '%s'." % (f, version))
 752
 753         # Ensure the architecture of the .deb is one we know about.
 754         default_suite = cnf.get("Dinstall::DefaultSuite", "unstable")
 755         architecture = control.Find("Architecture")
 756         upload_suite = self.pkg.changes["distribution"].keys()[0]
 757
 758         if      architecture not in [a.arch_string for a in get_suite_architectures(default_suite, session = session)] \
 759             and architecture not in [a.arch_string for a in get_suite_architectures(upload_suite, session = session)]:
 760             self.rejects.append("Unknown architecture '%s'." % (architecture))
 761
 762         # Ensure the architecture of the .deb is one of the ones
 763         # listed in the .changes.
 764         if not self.pkg.changes["architecture"].has_key(architecture):
 765             self.rejects.append("%s: control file lists arch as `%s', which isn't in changes file." % (f, architecture))
 766
 767         # Sanity-check the Depends field
 768         depends = control.Find("Depends")
 769         if depends == '':
 770             self.rejects.append("%s: Depends field is empty." % (f))
 771
 772         # Sanity-check the Provides field
 773         provides = control.Find("Provides")
 774         if provides:
 775             provide = re_spacestrip.sub('', provides)
 776             if provide == '':
 777                 self.rejects.append("%s: Provides field is empty." % (f))
 778             prov_list = provide.split(",")
 779             for prov in prov_list:
 780                 if not re_valid_pkg_name.match(prov):
 781                     self.rejects.append("%s: Invalid Provides field content %s." % (f, prov))
 782
 783         # If there is a Built-Using field, we need to check we can find the
 784         # exact source version
 785         built_using = control.Find("Built-Using")
 786         if built_using:
 787             try:
 788                 entry["built-using"] = []
 789                 for dep in apt_pkg.parse_depends(built_using):
 790                     bu_s, bu_v, bu_e = dep[0]
 791                     # Check that it's an exact match dependency and we have
 792                     # some form of version
 793                     if bu_e != "=" or len(bu_v) < 1:
 794                         self.rejects.append("%s: Built-Using contains non strict dependency (%s %s %s)" % (f, bu_s, bu_e, bu_v))
 795                     else:
 796                         # Find the source id for this version
 797                         bu_so = get_sources_from_name(bu_s, version=bu_v, session = session)
 798                         if len(bu_so) != 1:
 799                             self.rejects.append("%s: Built-Using (%s = %s): Cannot find source package" % (f, bu_s, bu_v))
 800                         else:
 801                             entry["built-using"].append( (bu_so[0].source, bu_so[0].version, ) )
 802
 803             except ValueError as e:
 804                 self.rejects.append("%s: Cannot parse Built-Using field: %s" % (f, str(e)))
 805
 806
 807         # Check the section & priority match those given in the .changes (non-fatal)
 808         if     control.Find("Section") and entry["section"] != "" \
 809            and entry["section"] != control.Find("Section"):
 810             self.warnings.append("%s control file lists section as `%s', but changes file has `%s'." % \
 811                                 (f, control.Find("Section", ""), entry["section"]))
 812         if control.Find("Priority") and entry["priority"] != "" \
 813            and entry["priority"] != control.Find("Priority"):
 814             self.warnings.append("%s control file lists priority as `%s', but changes file has `%s'." % \
 815                                 (f, control.Find("Priority", ""), entry["priority"]))
 816
 817         entry["package"] = package
 818         entry["architecture"] = architecture
 819         entry["version"] = version
 820         entry["maintainer"] = control.Find("Maintainer", "")
 821
 822         if f.endswith(".udeb"):
 823             self.pkg.files[f]["dbtype"] = "udeb"
 824         elif f.endswith(".deb"):
 825             self.pkg.files[f]["dbtype"] = "deb"
 826         else:
 827             self.rejects.append("%s is neither a .deb or a .udeb." % (f))
 828
 829         entry["source"] = control.Find("Source", entry["package"])
 830
 831         # Get the source version
 832         source = entry["source"]
 833         source_version = ""
 834
 835         if source.find("(") != -1:
 836             m = re_extract_src_version.match(source)
 837             source = m.group(1)
 838             source_version = m.group(2)
 839
 840         if not source_version:
 841             source_version = self.pkg.files[f]["version"]
 842
 843         entry["source package"] = source
 844         entry["source version"] = source_version
 845
 846         # Ensure the filename matches the contents of the .deb
 847         m = re_isadeb.match(f)
 848
 849         #  package name
 850         file_package = m.group(1)
 851         if entry["package"] != file_package:
 852             self.rejects.append("%s: package part of filename (%s) does not match package name in the %s (%s)." % \
 853                                 (f, file_package, entry["dbtype"], entry["package"]))
 854         epochless_version = re_no_epoch.sub('', control.Find("Version"))
 855
 856         #  version
 857         file_version = m.group(2)
 858         if epochless_version != file_version:
 859             self.rejects.append("%s: version part of filename (%s) does not match package version in the %s (%s)." % \
 860                                 (f, file_version, entry["dbtype"], epochless_version))
 861
 862         #  architecture
 863         file_architecture = m.group(3)
 864         if entry["architecture"] != file_architecture:
 865             self.rejects.append("%s: architecture part of filename (%s) does not match package architecture in the %s (%s)." % \
 866                                 (f, file_architecture, entry["dbtype"], entry["architecture"]))
 867
 868         # Check for existent source
 869         source_version = entry["source version"]
 870         source_package = entry["source package"]
 871         if self.pkg.changes["architecture"].has_key("source"):
 872             if source_version != self.pkg.changes["version"]:
 873                 self.rejects.append("source version (%s) for %s doesn't match changes version %s." % \
 874                                     (source_version, f, self.pkg.changes["version"]))
 875         else:
 876             # Check in the SQL database
 877             if not source_exists(source_package, source_version, suites = \
 878                 self.pkg.changes["distribution"].keys(), session = session):
 879                 # Check in one of the other directories
 880                 source_epochless_version = re_no_epoch.sub('', source_version)
 881                 dsc_filename = "%s_%s.dsc" % (source_package, source_epochless_version)
 882
 883                 byhand_dir = get_policy_queue('byhand', session).path
 884                 new_dir = get_policy_queue('new', session).path
 885
 886                 if os.path.exists(os.path.join(byhand_dir, dsc_filename)):
 887                     entry["byhand"] = 1
 888                 elif os.path.exists(os.path.join(new_dir, dsc_filename)):
 889                     entry["new"] = 1
 890                 else:
 891                     dsc_file_exists = False
 892                     # TODO: Don't hardcode this list: use all relevant queues
 893                     #       The question is how to determine what is relevant
 894                     for queue_name in ["embargoed", "unembargoed", "proposedupdates", "oldproposedupdates"]:
 895                         queue = get_policy_queue(queue_name, session)
 896                         if queue:
 897                             if os.path.exists(os.path.join(queue.path, dsc_filename)):
 898                                 dsc_file_exists = True
 899                                 break
 900
 901                     if not dsc_file_exists:
 902                         self.rejects.append("no source found for %s %s (%s)." % (source_package, source_version, f))
 903
 904         # Check the version and for file overwrites
 905         self.check_binary_against_db(f, session)
 906
 907     def source_file_checks(self, f, session):
 908         entry = self.pkg.files[f]
 909
 910         m = re_issource.match(f)
 911         if not m:
 912             return
 913
 914         entry["package"] = m.group(1)
 915         entry["version"] = m.group(2)
 916         entry["type"] = m.group(3)
 917
 918         # Ensure the source package name matches the Source filed in the .changes
 919         if self.pkg.changes["source"] != entry["package"]:
 920             self.rejects.append("%s: changes file doesn't say %s for Source" % (f, entry["package"]))
 921
 922         # Ensure the source version matches the version in the .changes file
 923         if re_is_orig_source.match(f):
 924             changes_version = self.pkg.changes["chopversion2"]
 925         else:
 926             changes_version = self.pkg.changes["chopversion"]
 927
 928         if changes_version != entry["version"]:
 929             self.rejects.append("%s: should be %s according to changes file." % (f, changes_version))
 930
 931         # Ensure the .changes lists source in the Architecture field
 932         if not self.pkg.changes["architecture"].has_key("source"):
 933             self.rejects.append("%s: changes file doesn't list `source' in Architecture field." % (f))
 934
 935         # Check the signature of a .dsc file
 936         if entry["type"] == "dsc":
 937             # check_signature returns either:
 938             #  (None, [list, of, rejects]) or (signature, [])
 939             (self.pkg.dsc["fingerprint"], rejects) = utils.check_signature(f)
 940             for j in rejects:
 941                 self.rejects.append(j)
 942
 943         entry["architecture"] = "source"
 944
 945     def per_suite_file_checks(self, f, suite, session):
 946         cnf = Config()
 947         entry = self.pkg.files[f]
 948
 949         # Skip byhand
 950         if entry.has_key("byhand"):
 951             return
 952
 953         # Check we have fields we need to do these checks
 954         oktogo = True
 955         for m in ['component', 'package', 'priority', 'size', 'md5sum']:
 956             if not entry.has_key(m):
 957                 self.rejects.append("file '%s' does not have field %s set" % (f, m))
 958                 oktogo = False
 959
 960         if not oktogo:
 961             return
 962
 963         # Handle component mappings
 964         for m in cnf.ValueList("ComponentMappings"):
 965             (source, dest) = m.split()
 966             if entry["component"] == source:
 967                 entry["original component"] = source
 968                 entry["component"] = dest
 969
 970         # Ensure the component is valid for the target suite
 971         if entry["component"] not in get_component_names(session):
 972             self.rejects.append("unknown component `%s' for suite `%s'." % (entry["component"], suite))
 973             return
 974
 975         # Validate the component
 976         if not get_component(entry["component"], session):
 977             self.rejects.append("file '%s' has unknown component '%s'." % (f, entry["component"]))
 978             return
 979
 980         # See if the package is NEW
 981         if not self.in_override_p(entry["package"], entry["component"], suite, entry.get("dbtype",""), f, session):
 982             entry["new"] = 1
 983
 984         # Validate the priority
 985         if entry["priority"].find('/') != -1:
 986             self.rejects.append("file '%s' has invalid priority '%s' [contains '/']." % (f, entry["priority"]))
 987
 988         # Determine the location
 989         location = cnf["Dir::Pool"]
 990         l = get_location(location, entry["component"], session=session)
 991         if l is None:
 992             self.rejects.append("[INTERNAL ERROR] couldn't determine location (Component: %s)" % entry["component"])
 993             entry["location id"] = -1
 994         else:
 995             entry["location id"] = l.location_id
 996
 997         # Check the md5sum & size against existing files (if any)
 998         entry["pool name"] = utils.poolify(self.pkg.changes["source"], entry["component"])
 999
1000         found, poolfile = check_poolfile(os.path.join(entry["pool name"], f),
1001                                          entry["size"], entry["md5sum"], entry["location id"])
1002
1003         if found is None:
1004             self.rejects.append("INTERNAL ERROR, get_files_id() returned multiple matches for %s." % (f))
1005         elif found is False and poolfile is not None:
1006             self.rejects.append("md5sum and/or size mismatch on existing copy of %s." % (f))
1007         else:
1008             if poolfile is None:
1009                 entry["files id"] = None
1010             else:
1011                 entry["files id"] = poolfile.file_id
1012
1013         # Check for packages that have moved from one component to another
1014         entry['suite'] = suite
1015         arch_list = [entry["architecture"], 'all']
1016         component = get_component_by_package_suite(self.pkg.files[f]['package'], \
1017             [suite], arch_list = arch_list, session = session)
1018         if component is not None:
1019             entry["othercomponents"] = component
1020
1021     def check_files(self, action=True):
1022         file_keys = self.pkg.files.keys()
1023         holding = Holding()
1024         cnf = Config()
1025
1026         if action:
1027             cwd = os.getcwd()
1028             os.chdir(self.pkg.directory)
1029             for f in file_keys:
1030                 ret = holding.copy_to_holding(f)
1031                 if ret is not None:
1032                     self.warnings.append('Could not copy %s to holding; will attempt to find in DB later' % f)
1033
1034             os.chdir(cwd)
1035
1036         # check we already know the changes file
1037         # [NB: this check must be done post-suite mapping]
1038         base_filename = os.path.basename(self.pkg.changes_file)
1039
1040         session = DBConn().session()
1041
1042         try:
1043             dbc = session.query(DBChange).filter_by(changesname=base_filename).one()
1044             # if in the pool or in a queue other than unchecked, reject
1045             if (dbc.in_queue is None) \
1046                    or (dbc.in_queue is not None
1047                        and dbc.in_queue.queue_name not in ["unchecked", "newstage"]):
1048                 self.rejects.append("%s file already known to dak" % base_filename)
1049         except NoResultFound as e:
1050             # not known, good
1051             pass
1052
1053         has_binaries = False
1054         has_source = False
1055
1056         for f, entry in self.pkg.files.items():
1057             # Ensure the file does not already exist in one of the accepted directories
1058             # TODO: Dynamically generate this list
1059             for queue_name in [ "byhand", "new", "proposedupdates", "oldproposedupdates", "embargoed", "unembargoed" ]:
1060                 queue = get_policy_queue(queue_name, session)
1061                 if queue and os.path.exists(os.path.join(queue.path, f)):
1062                     self.rejects.append("%s file already exists in the %s queue." % (f, queue_name))
1063
1064             if not re_taint_free.match(f):
1065                 self.rejects.append("!!WARNING!! tainted filename: '%s'." % (f))
1066
1067             # Check the file is readable
1068             if os.access(f, os.R_OK) == 0:
1069                 # When running in -n, copy_to_holding() won't have
1070                 # generated the reject_message, so we need to.
1071                 if action:
1072                     if os.path.exists(f):
1073                         self.rejects.append("Can't read `%s'. [permission denied]" % (f))
1074                     else:
1075                         # Don't directly reject, mark to check later to deal with orig's
1076                         # we can find in the pool
1077                         self.later_check_files.append(f)
1078                 entry["type"] = "unreadable"
1079                 continue
1080
1081             # If it's byhand skip remaining checks
1082             if entry["section"] == "byhand" or entry["section"][:4] == "raw-":
1083                 entry["byhand"] = 1
1084                 entry["type"] = "byhand"
1085
1086             # Checks for a binary package...
1087             elif re_isadeb.match(f):
1088                 has_binaries = True
1089                 entry["type"] = "deb"
1090
1091                 # This routine appends to self.rejects/warnings as appropriate
1092                 self.binary_file_checks(f, session)
1093
1094             # Checks for a source package...
1095             elif re_issource.match(f):
1096                 has_source = True
1097
1098                 # This routine appends to self.rejects/warnings as appropriate
1099                 self.source_file_checks(f, session)
1100
1101             # Not a binary or source package?  Assume byhand...
1102             else:
1103                 entry["byhand"] = 1
1104                 entry["type"] = "byhand"
1105
1106             # Per-suite file checks
1107             entry["oldfiles"] = {}
1108             for suite in self.pkg.changes["distribution"].keys():
1109                 self.per_suite_file_checks(f, suite, session)
1110
1111         session.close()
1112
1113         # If the .changes file says it has source, it must have source.
1114         if self.pkg.changes["architecture"].has_key("source"):
1115             if not has_source:
1116                 self.rejects.append("no source found and Architecture line in changes mention source.")
1117
1118             if (not has_binaries) and (not cnf.FindB("Dinstall::AllowSourceOnlyUploads")):
1119                 self.rejects.append("source only uploads are not supported.")
1120
1121     ###########################################################################
1122
1123     def __dsc_filename(self):
1124         """
1125         Returns: (Status, Dsc_Filename)
1126         where
1127           Status: Boolean; True when there was no error, False otherwise
1128           Dsc_Filename: String; name of the dsc file if Status is True, reason for the error otherwise
1129         """
1130         dsc_filename = None
1131
1132         # find the dsc
1133         for name, entry in self.pkg.files.items():
1134             if entry.has_key("type") and entry["type"] == "dsc":
1135                 if dsc_filename:
1136                     return False, "cannot process a .changes file with multiple .dsc's."
1137                 else:
1138                     dsc_filename = name
1139
1140         if not dsc_filename:
1141             return False, "source uploads must contain a dsc file"
1142
1143         return True, dsc_filename
1144
1145     def load_dsc(self, action=True, signing_rules=1):
1146         """
1147         Find and load the dsc from self.pkg.files into self.dsc
1148
1149         Returns: (Status, Reason)
1150         where
1151           Status: Boolean; True when there was no error, False otherwise
1152           Reason: String; When Status is False this describes the error
1153         """
1154
1155         # find the dsc
1156         (status, dsc_filename) = self.__dsc_filename()
1157         if not status:
1158             # If status is false, dsc_filename has the reason
1159             return False, dsc_filename
1160
1161         try:
1162             self.pkg.dsc.update(utils.parse_changes(dsc_filename, signing_rules=signing_rules, dsc_file=1))
1163         except CantOpenError:
1164             if not action:
1165                 return False, "%s: can't read file." % (dsc_filename)
1166         except ParseChangesError as line:
1167             return False, "%s: parse error, can't grok: %s." % (dsc_filename, line)
1168         except InvalidDscError as line:
1169             return False, "%s: syntax error on line %s." % (dsc_filename, line)
1170         except ChangesUnicodeError:
1171             return False, "%s: dsc file not proper utf-8." % (dsc_filename)
1172
1173         return True, None
1174
1175     ###########################################################################
1176
1177     def check_dsc(self, action=True, session=None):
1178         """Returns bool indicating whether or not the source changes are valid"""
1179         # Ensure there is source to check
1180         if not self.pkg.changes["architecture"].has_key("source"):
1181             return True
1182
1183         if session is None:
1184             session = DBConn().session()
1185
1186         (status, reason) = self.load_dsc(action=action)
1187         if not status:
1188             self.rejects.append(reason)
1189             return False
1190         (status, dsc_filename) = self.__dsc_filename()
1191         if not status:
1192             # If status is false, dsc_filename has the reason
1193             self.rejects.append(dsc_filename)
1194             return False
1195
1196         # Build up the file list of files mentioned by the .dsc
1197         try:
1198             self.pkg.dsc_files.update(utils.build_file_list(self.pkg.dsc, is_a_dsc=1))
1199         except NoFilesFieldError:
1200             self.rejects.append("%s: no Files: field." % (dsc_filename))
1201             return False
1202         except UnknownFormatError as format:
1203             self.rejects.append("%s: unknown format '%s'." % (dsc_filename, format))
1204             return False
1205         except ParseChangesError as line:
1206             self.rejects.append("%s: parse error, can't grok: %s." % (dsc_filename, line))
1207             return False
1208
1209         # Enforce mandatory fields
1210         for i in ("format", "source", "version", "binary", "maintainer", "architecture", "files"):
1211             if not self.pkg.dsc.has_key(i):
1212                 self.rejects.append("%s: missing mandatory field `%s'." % (dsc_filename, i))
1213                 return False
1214
1215         # Validate the source and version fields
1216         if not re_valid_pkg_name.match(self.pkg.dsc["source"]):
1217             self.rejects.append("%s: invalid source name '%s'." % (dsc_filename, self.pkg.dsc["source"]))
1218         if not re_valid_version.match(self.pkg.dsc["version"]):
1219             self.rejects.append("%s: invalid version number '%s'." % (dsc_filename, self.pkg.dsc["version"]))
1220
1221         # Only a limited list of source formats are allowed in each suite
1222         for dist in self.pkg.changes["distribution"].keys():
1223             suite = get_suite(dist, session=session)
1224             if not suite:
1225                 self.rejects.append("%s: cannot find suite %s when checking source formats" % (dsc_filename, dist))
1226                 continue
1227             allowed = [ x.format_name for x in suite.srcformats ]
1228             if self.pkg.dsc["format"] not in allowed:
1229                 self.rejects.append("%s: source format '%s' not allowed in %s (accepted: %s) " % (dsc_filename, self.pkg.dsc["format"], dist, ", ".join(allowed)))
1230
1231         # Validate the Maintainer field
1232         try:
1233             # We ignore the return value
1234             fix_maintainer(self.pkg.dsc["maintainer"])
1235         except ParseMaintError as msg:
1236             self.rejects.append("%s: Maintainer field ('%s') failed to parse: %s" \
1237                                  % (dsc_filename, self.pkg.dsc["maintainer"], msg))
1238
1239         # Validate the build-depends field(s)
1240         for field_name in [ "build-depends", "build-depends-indep" ]:
1241             field = self.pkg.dsc.get(field_name)
1242             if field:
1243                 # Have apt try to parse them...
1244                 try:
1245                     apt_pkg.ParseSrcDepends(field)
1246                 except:
1247                     self.rejects.append("%s: invalid %s field (can not be parsed by apt)." % (dsc_filename, field_name.title()))
1248
1249         # Ensure the version number in the .dsc matches the version number in the .changes
1250         epochless_dsc_version = re_no_epoch.sub('', self.pkg.dsc["version"])
1251         changes_version = self.pkg.files[dsc_filename]["version"]
1252
1253         if epochless_dsc_version != self.pkg.files[dsc_filename]["version"]:
1254             self.rejects.append("version ('%s') in .dsc does not match version ('%s') in .changes." % (epochless_dsc_version, changes_version))
1255
1256         # Ensure the Files field contain only what's expected
1257         self.rejects.extend(check_dsc_files(dsc_filename, self.pkg.dsc, self.pkg.dsc_files))
1258
1259         # Ensure source is newer than existing source in target suites
1260         session = DBConn().session()
1261         self.check_source_against_db(dsc_filename, session)
1262         self.check_dsc_against_db(dsc_filename, session)
1263
1264         dbchg = get_dbchange(self.pkg.changes_file, session)
1265
1266         # Finally, check if we're missing any files
1267         for f in self.later_check_files:
1268             print 'XXX: %s' % f
1269             # Check if we've already processed this file if we have a dbchg object
1270             ok = False
1271             if dbchg:
1272                 for pf in dbchg.files:
1273                     if pf.filename == f and pf.processed:
1274                         self.notes.append('%s was already processed so we can go ahead' % f)
1275                         ok = True
1276                         del self.pkg.files[f]
1277             if not ok:
1278                 self.rejects.append("Could not find file %s references in changes" % f)
1279
1280         session.close()
1281
1282         return (len(self.rejects) == 0)
1283
1284     ###########################################################################
1285
1286     def get_changelog_versions(self, source_dir):
1287         """Extracts a the source package and (optionally) grabs the
1288         version history out of debian/changelog for the BTS."""
1289
1290         cnf = Config()
1291
1292         # Find the .dsc (again)
1293         dsc_filename = None
1294         for f in self.pkg.files.keys():
1295             if self.pkg.files[f]["type"] == "dsc":
1296                 dsc_filename = f
1297
1298         # If there isn't one, we have nothing to do. (We have reject()ed the upload already)
1299         if not dsc_filename:
1300             return
1301
1302         # Create a symlink mirror of the source files in our temporary directory
1303         for f in self.pkg.files.keys():
1304             m = re_issource.match(f)
1305             if m:
1306                 src = os.path.join(source_dir, f)
1307                 # If a file is missing for whatever reason, give up.
1308                 if not os.path.exists(src):
1309                     return
1310                 ftype = m.group(3)
1311                 if re_is_orig_source.match(f) and self.pkg.orig_files.has_key(f) and \
1312                    self.pkg.orig_files[f].has_key("path"):
1313                     continue
1314                 dest = os.path.join(os.getcwd(), f)
1315                 os.symlink(src, dest)
1316
1317         # If the orig files are not a part of the upload, create symlinks to the
1318         # existing copies.
1319         for orig_file in self.pkg.orig_files.keys():
1320             if not self.pkg.orig_files[orig_file].has_key("path"):
1321                 continue
1322             dest = os.path.join(os.getcwd(), os.path.basename(orig_file))
1323             os.symlink(self.pkg.orig_files[orig_file]["path"], dest)
1324
1325         # Extract the source
1326         try:
1327             unpacked = UnpackedSource(dsc_filename)
1328         except Exception as e:
1329             self.rejects.append("'dpkg-source -x' failed for %s. (%s)" % (dsc_filename, str(e)))
1330             return
1331
1332         if not cnf.Find("Dir::BTSVersionTrack"):
1333             return
1334
1335         # Get the upstream version
1336         upstr_version = re_no_epoch.sub('', self.pkg.dsc["version"])
1337         if re_strip_revision.search(upstr_version):
1338             upstr_version = re_strip_revision.sub('', upstr_version)
1339
1340         # Ensure the changelog file exists
1341         changelog_file = unpacked.get_changelog_file()
1342         if changelog_file is None:
1343             self.rejects.append("%s: debian/changelog not found in extracted source." % (dsc_filename))
1344             return
1345
1346         # Parse the changelog
1347         self.pkg.dsc["bts changelog"] = ""
1348         for line in changelog_file.readlines():
1349             m = re_changelog_versions.match(line)
1350             if m:
1351                 self.pkg.dsc["bts changelog"] += line
1352         changelog_file.close()
1353         unpacked.cleanup()
1354
1355         # Check we found at least one revision in the changelog
1356         if not self.pkg.dsc["bts changelog"]:
1357             self.rejects.append("%s: changelog format not recognised (empty version tree)." % (dsc_filename))
1358
1359     def check_source(self):
1360         # Bail out if:
1361         #    a) there's no source
1362         if not self.pkg.changes["architecture"].has_key("source"):
1363             return
1364
1365         tmpdir = utils.temp_dirname()
1366
1367         # Move into the temporary directory
1368         cwd = os.getcwd()
1369         os.chdir(tmpdir)
1370
1371         # Get the changelog version history
1372         self.get_changelog_versions(cwd)
1373
1374         # Move back and cleanup the temporary tree
1375         os.chdir(cwd)
1376
1377         try:
1378             shutil.rmtree(tmpdir)
1379         except OSError as e:
1380             if e.errno != errno.EACCES:
1381                 print "foobar"
1382                 utils.fubar("%s: couldn't remove tmp dir for source tree." % (self.pkg.dsc["source"]))
1383
1384             self.rejects.append("%s: source tree could not be cleanly removed." % (self.pkg.dsc["source"]))
1385             # We probably have u-r or u-w directories so chmod everything
1386             # and try again.
1387             cmd = "chmod -R u+rwx %s" % (tmpdir)
1388             result = os.system(cmd)
1389             if result != 0:
1390                 utils.fubar("'%s' failed with result %s." % (cmd, result))
1391             shutil.rmtree(tmpdir)
1392         except Exception as e:
1393             print "foobar2 (%s)" % e
1394             utils.fubar("%s: couldn't remove tmp dir for source tree." % (self.pkg.dsc["source"]))
1395
1396     ###########################################################################
1397     def ensure_hashes(self):
1398         # Make sure we recognise the format of the Files: field in the .changes
1399         format = self.pkg.changes.get("format", "0.0").split(".", 1)
1400         if len(format) == 2:
1401             format = int(format[0]), int(format[1])
1402         else:
1403             format = int(float(format[0])), 0
1404
1405         # We need to deal with the original changes blob, as the fields we need
1406         # might not be in the changes dict serialised into the .dak anymore.
1407         orig_changes = utils.parse_deb822(self.pkg.changes['filecontents'])
1408
1409         # Copy the checksums over to the current changes dict.  This will keep
1410         # the existing modifications to it intact.
1411         for field in orig_changes:
1412             if field.startswith('checksums-'):
1413                 self.pkg.changes[field] = orig_changes[field]
1414
1415         # Check for unsupported hashes
1416         for j in utils.check_hash_fields(".changes", self.pkg.changes):
1417             self.rejects.append(j)
1418
1419         for j in utils.check_hash_fields(".dsc", self.pkg.dsc):
1420             self.rejects.append(j)
1421
1422         # We have to calculate the hash if we have an earlier changes version than
1423         # the hash appears in rather than require it exist in the changes file
1424         for hashname, hashfunc, version in utils.known_hashes:
1425             # TODO: Move _ensure_changes_hash into this class
1426             for j in utils._ensure_changes_hash(self.pkg.changes, format, version, self.pkg.files, hashname, hashfunc):
1427                 self.rejects.append(j)
1428             if "source" in self.pkg.changes["architecture"]:
1429                 # TODO: Move _ensure_dsc_hash into this class
1430                 for j in utils._ensure_dsc_hash(self.pkg.dsc, self.pkg.dsc_files, hashname, hashfunc):
1431                     self.rejects.append(j)
1432
1433     def check_hashes(self):
1434         for m in utils.check_hash(".changes", self.pkg.files, "md5", apt_pkg.md5sum):
1435             self.rejects.append(m)
1436
1437         for m in utils.check_size(".changes", self.pkg.files):
1438             self.rejects.append(m)
1439
1440         for m in utils.check_hash(".dsc", self.pkg.dsc_files, "md5", apt_pkg.md5sum):
1441             self.rejects.append(m)
1442
1443         for m in utils.check_size(".dsc", self.pkg.dsc_files):
1444             self.rejects.append(m)
1445
1446         self.ensure_hashes()
1447
1448     ###########################################################################
1449
1450     def ensure_orig(self, target_dir='.', session=None):
1451         """
1452         Ensures that all orig files mentioned in the changes file are present
1453         in target_dir. If they do not exist, they are symlinked into place.
1454
1455         An list containing the symlinks that were created are returned (so they
1456         can be removed).
1457         """
1458
1459         symlinked = []
1460         cnf = Config()
1461
1462         for filename, entry in self.pkg.dsc_files.iteritems():
1463             if not re_is_orig_source.match(filename):
1464                 # File is not an orig; ignore
1465                 continue
1466
1467             if os.path.exists(filename):
1468                 # File exists, no need to continue
1469                 continue
1470
1471             def symlink_if_valid(path):
1472                 f = utils.open_file(path)
1473                 md5sum = apt_pkg.md5sum(f)
1474                 f.close()
1475
1476                 fingerprint = (os.stat(path)[stat.ST_SIZE], md5sum)
1477                 expected = (int(entry['size']), entry['md5sum'])
1478
1479                 if fingerprint != expected:
1480                     return False
1481
1482                 dest = os.path.join(target_dir, filename)
1483
1484                 os.symlink(path, dest)
1485                 symlinked.append(dest)
1486
1487                 return True
1488
1489             session_ = session
1490             if session is None:
1491                 session_ = DBConn().session()
1492
1493             found = False
1494
1495             # Look in the pool
1496             for poolfile in get_poolfile_like_name('%s' % filename, session_):
1497                 poolfile_path = os.path.join(
1498                     poolfile.location.path, poolfile.filename
1499                 )
1500
1501                 if symlink_if_valid(poolfile_path):
1502                     found = True
1503                     break
1504
1505             if session is None:
1506                 session_.close()
1507
1508             if found:
1509                 continue
1510
1511             # Look in some other queues for the file
1512             queue_names = ['new', 'byhand',
1513                            'proposedupdates', 'oldproposedupdates',
1514                            'embargoed', 'unembargoed']
1515
1516             for queue_name in queue_names:
1517                 queue = get_policy_queue(queue_name, session)
1518                 if not queue:
1519                     continue
1520
1521                 queuefile_path = os.path.join(queue.path, filename)
1522
1523                 if not os.path.exists(queuefile_path):
1524                     # Does not exist in this queue
1525                     continue
1526
1527                 if symlink_if_valid(queuefile_path):
1528                     break
1529
1530         return symlinked
1531
1532     ###########################################################################
1533
1534     def check_lintian(self):
1535         """
1536         Extends self.rejects by checking the output of lintian against tags
1537         specified in Dinstall::LintianTags.
1538         """
1539
1540         cnf = Config()
1541
1542         # Don't reject binary uploads
1543         if not self.pkg.changes['architecture'].has_key('source'):
1544             return
1545
1546         # Only check some distributions
1547         for dist in ('unstable', 'experimental'):
1548             if dist in self.pkg.changes['distribution']:
1549                 break
1550         else:
1551             return
1552
1553         # If we do not have a tagfile, don't do anything
1554         tagfile = cnf.get("Dinstall::LintianTags")
1555         if not tagfile:
1556             return
1557
1558         # Parse the yaml file
1559         sourcefile = file(tagfile, 'r')
1560         sourcecontent = sourcefile.read()
1561         sourcefile.close()
1562
1563         try:
1564             lintiantags = yaml.load(sourcecontent)['lintian']
1565         except yaml.YAMLError as msg:
1566             utils.fubar("Can not read the lintian tags file %s, YAML error: %s." % (tagfile, msg))
1567             return
1568
1569         # Try and find all orig mentioned in the .dsc
1570         symlinked = self.ensure_orig()
1571
1572         # Setup the input file for lintian
1573         fd, temp_filename = utils.temp_filename()
1574         temptagfile = os.fdopen(fd, 'w')
1575         for tags in lintiantags.values():
1576             temptagfile.writelines(['%s\n' % x for x in tags])
1577         temptagfile.close()
1578
1579         try:
1580             cmd = "lintian --show-overrides --tags-from-file %s %s" % \
1581                 (temp_filename, self.pkg.changes_file)
1582
1583             result, output = commands.getstatusoutput(cmd)
1584         finally:
1585             # Remove our tempfile and any symlinks we created
1586             os.unlink(temp_filename)
1587
1588             for symlink in symlinked:
1589                 os.unlink(symlink)
1590
1591         if result == 2:
1592             utils.warn("lintian failed for %s [return code: %s]." % \
1593                 (self.pkg.changes_file, result))
1594             utils.warn(utils.prefix_multi_line_string(output, \
1595                 " [possible output:] "))
1596
1597         def log(*txt):
1598             if self.logger:
1599                 self.logger.log(
1600                     [self.pkg.changes_file, "check_lintian"] + list(txt)
1601                 )
1602
1603         # Generate messages
1604         parsed_tags = parse_lintian_output(output)
1605         self.rejects.extend(
1606             generate_reject_messages(parsed_tags, lintiantags, log=log)
1607         )
1608
1609     ###########################################################################
1610     def check_urgency(self):
1611         cnf = Config()
1612         if self.pkg.changes["architecture"].has_key("source"):
1613             if not self.pkg.changes.has_key("urgency"):
1614                 self.pkg.changes["urgency"] = cnf["Urgency::Default"]
1615             self.pkg.changes["urgency"] = self.pkg.changes["urgency"].lower()
1616             if self.pkg.changes["urgency"] not in cnf.ValueList("Urgency::Valid"):
1617                 self.warnings.append("%s is not a valid urgency; it will be treated as %s by testing." % \
1618                                      (self.pkg.changes["urgency"], cnf["Urgency::Default"]))
1619                 self.pkg.changes["urgency"] = cnf["Urgency::Default"]
1620
1621     ###########################################################################
1622
1623     # Sanity check the time stamps of files inside debs.
1624     # [Files in the near future cause ugly warnings and extreme time
1625     #  travel can cause errors on extraction]
1626
1627     def check_timestamps(self):
1628         Cnf = Config()
1629
1630         future_cutoff = time.time() + int(Cnf["Dinstall::FutureTimeTravelGrace"])
1631         past_cutoff = time.mktime(time.strptime(Cnf["Dinstall::PastCutoffYear"],"%Y"))
1632         tar = TarTime(future_cutoff, past_cutoff)
1633
1634         for filename, entry in self.pkg.files.items():
1635             if entry["type"] == "deb":
1636                 tar.reset()
1637                 try:
1638                     deb = apt_inst.DebFile(filename)
1639                     deb.control.go(tar.callback)
1640
1641                     future_files = tar.future_files.keys()
1642                     if future_files:
1643                         num_future_files = len(future_files)
1644                         future_file = future_files[0]
1645                         future_date = tar.future_files[future_file]
1646                         self.rejects.append("%s: has %s file(s) with a time stamp too far into the future (e.g. %s [%s])."
1647                                % (filename, num_future_files, future_file, time.ctime(future_date)))
1648
1649                     ancient_files = tar.ancient_files.keys()
1650                     if ancient_files:
1651                         num_ancient_files = len(ancient_files)
1652                         ancient_file = ancient_files[0]
1653                         ancient_date = tar.ancient_files[ancient_file]
1654                         self.rejects.append("%s: has %s file(s) with a time stamp too ancient (e.g. %s [%s])."
1655                                % (filename, num_ancient_files, ancient_file, time.ctime(ancient_date)))
1656                 except:
1657                     self.rejects.append("%s: deb contents timestamp check failed [%s: %s]" % (filename, sys.exc_type, sys.exc_value))
1658
1659     def check_if_upload_is_sponsored(self, uid_email, uid_name):
1660         uid_email = '@'.join(uid_email.split('@')[:2])
1661         if uid_email in [self.pkg.changes["maintaineremail"], self.pkg.changes["changedbyemail"]]:
1662             sponsored = False
1663         elif uid_name in [self.pkg.changes["maintainername"], self.pkg.changes["changedbyname"]]:
1664             sponsored = False
1665             if uid_name == "":
1666                 sponsored = True
1667         else:
1668             sponsored = True
1669             sponsor_addresses = utils.gpg_get_key_addresses(self.pkg.changes["fingerprint"])
1670             debian_emails = filter(lambda addr: addr.endswith('@debian.org'), sponsor_addresses)
1671             if uid_email not in debian_emails:
1672                 if debian_emails:
1673                     uid_email = debian_emails[0]
1674             if ("source" in self.pkg.changes["architecture"] and uid_email and utils.is_email_alias(uid_email)):
1675                 if (self.pkg.changes["maintaineremail"] not in sponsor_addresses and
1676                     self.pkg.changes["changedbyemail"] not in sponsor_addresses):
1677                         self.pkg.changes["sponsoremail"] = uid_email
1678
1679         return sponsored
1680
1681
1682     ###########################################################################
1683     # check_signed_by_key checks
1684     ###########################################################################
1685
1686     def check_signed_by_key(self):
1687         """Ensure the .changes is signed by an authorized uploader."""
1688         session = DBConn().session()
1689
1690         # First of all we check that the person has proper upload permissions
1691         # and that this upload isn't blocked
1692         fpr = get_fingerprint(self.pkg.changes['fingerprint'], session=session)
1693
1694         if fpr is None:
1695             self.rejects.append("Cannot find fingerprint %s" % self.pkg.changes["fingerprint"])
1696             return
1697
1698         # TODO: Check that import-keyring adds UIDs properly
1699         if not fpr.uid:
1700             self.rejects.append("Cannot find uid for fingerprint %s.  Please contact ftpmaster@debian.org" % fpr.fingerprint)
1701             return
1702
1703         # Check that the fingerprint which uploaded has permission to do so
1704         self.check_upload_permissions(fpr, session)
1705
1706         # Check that this package is not in a transition
1707         self.check_transition(session)
1708
1709         session.close()
1710
1711
1712     def check_upload_permissions(self, fpr, session):
1713         # Check any one-off upload blocks
1714         self.check_upload_blocks(fpr, session)
1715
1716         # If the source_acl is None, source is never allowed
1717         if fpr.source_acl is None:
1718             if self.pkg.changes["architecture"].has_key("source"):
1719                 rej = 'Fingerprint %s may not upload source' % fpr.fingerprint
1720                 rej += '\nPlease contact ftpmaster if you think this is incorrect'
1721                 self.rejects.append(rej)
1722                 return
1723         # Do DM as a special case
1724         # DM is a special case unfortunately, so we check it first
1725         # (keys with no source access get more access than DMs in one
1726         #  way; DMs can only upload for their packages whether source
1727         #  or binary, whereas keys with no access might be able to
1728         #  upload some binaries)
1729         elif fpr.source_acl.access_level == 'dm':
1730             self.check_dm_upload(fpr, session)
1731         else:
1732             # If not a DM, we allow full upload rights
1733             uid_email = "%s@debian.org" % (fpr.uid.uid)
1734             self.check_if_upload_is_sponsored(uid_email, fpr.uid.name)
1735
1736
1737         # Check binary upload permissions
1738         # By this point we know that DMs can't have got here unless they
1739         # are allowed to deal with the package concerned so just apply
1740         # normal checks
1741         if fpr.binary_acl.access_level == 'full':
1742             return
1743
1744         # Otherwise we're in the map case
1745         tmparches = self.pkg.changes["architecture"].copy()
1746         tmparches.pop('source', None)
1747
1748         for bam in fpr.binary_acl_map:
1749             tmparches.pop(bam.architecture.arch_string, None)
1750
1751         if len(tmparches.keys()) > 0:
1752             if fpr.binary_reject:
1753                 rej = "changes file contains files of architectures not permitted for fingerprint %s" % fpr.fingerprint
1754                 if len(tmparches.keys()) == 1:
1755                     rej += "\n\narchitecture involved is: %s" % ",".join(tmparches.keys())
1756                 else:
1757                     rej += "\n\narchitectures involved are: %s" % ",".join(tmparches.keys())
1758                 self.rejects.append(rej)
1759             else:
1760                 # TODO: This is where we'll implement reject vs throw away binaries later
1761                 rej = "Uhm.  I'm meant to throw away the binaries now but that's not implemented yet"
1762                 rej += "\nPlease complain to ftpmaster@debian.org as this shouldn't have been turned on"
1763                 rej += "\nFingerprint: %s", (fpr.fingerprint)
1764                 self.rejects.append(rej)
1765
1766
1767     def check_upload_blocks(self, fpr, session):
1768         """Check whether any upload blocks apply to this source, source
1769            version, uid / fpr combination"""
1770
1771         def block_rej_template(fb):
1772             rej = 'Manual upload block in place for package %s' % fb.source
1773             if fb.version is not None:
1774                 rej += ', version %s' % fb.version
1775             return rej
1776
1777         for fb in session.query(UploadBlock).filter_by(source = self.pkg.changes['source']).all():
1778             # version is None if the block applies to all versions
1779             if fb.version is None or fb.version == self.pkg.changes['version']:
1780                 # Check both fpr and uid - either is enough to cause a reject
1781                 if fb.fpr is not None:
1782                     if fb.fpr.fingerprint == fpr.fingerprint:
1783                         self.rejects.append(block_rej_template(fb) + ' for fingerprint %s\nReason: %s' % (fpr.fingerprint, fb.reason))
1784                 if fb.uid is not None:
1785                     if fb.uid == fpr.uid:
1786                         self.rejects.append(block_rej_template(fb) + ' for uid %s\nReason: %s' % (fb.uid.uid, fb.reason))
1787
1788
1789     def check_dm_upload(self, fpr, session):
1790         # Quoth the GR (http://www.debian.org/vote/2007/vote_003):
1791         ## none of the uploaded packages are NEW
1792         rej = False
1793         for f in self.pkg.files.keys():
1794             if self.pkg.files[f].has_key("byhand"):
1795                 self.rejects.append("%s may not upload BYHAND file %s" % (fpr.uid.uid, f))
1796                 rej = True
1797             if self.pkg.files[f].has_key("new"):
1798                 self.rejects.append("%s may not upload NEW file %s" % (fpr.uid.uid, f))
1799                 rej = True
1800
1801         if rej:
1802             return
1803
1804         r = get_newest_source(self.pkg.changes["source"], session)
1805
1806         if r is None:
1807             rej = "Could not find existing source package %s in unstable or experimental and this is a DM upload" % self.pkg.changes["source"]
1808             self.rejects.append(rej)
1809             return
1810
1811         if not r.dm_upload_allowed:
1812             rej = "Source package %s does not have 'DM-Upload-Allowed: yes' in its most recent version (%s)" % (self.pkg.changes["source"], r.version)
1813             self.rejects.append(rej)
1814             return
1815
1816         ## the Maintainer: field of the uploaded .changes file corresponds with
1817         ## the owner of the key used (ie, non-developer maintainers may not sponsor
1818         ## uploads)
1819         if self.check_if_upload_is_sponsored(fpr.uid.uid, fpr.uid.name):
1820             self.rejects.append("%s (%s) is not authorised to sponsor uploads" % (fpr.uid.uid, fpr.fingerprint))
1821
1822         ## the most recent version of the package uploaded to unstable or
1823         ## experimental lists the uploader in the Maintainer: or Uploaders: fields (ie,
1824         ## non-developer maintainers cannot NMU or hijack packages)
1825
1826         # uploader includes the maintainer
1827         accept = False
1828         for uploader in r.uploaders:
1829             (rfc822, rfc2047, name, email) = uploader.get_split_maintainer()
1830             # Eww - I hope we never have two people with the same name in Debian
1831             if email == fpr.uid.uid or name == fpr.uid.name:
1832                 accept = True
1833                 break
1834
1835         if not accept:
1836             self.rejects.append("%s is not in Maintainer or Uploaders of source package %s" % (fpr.uid.uid, self.pkg.changes["source"]))
1837             return
1838
1839         ## none of the packages are being taken over from other source packages
1840         for b in self.pkg.changes["binary"].keys():
1841             for suite in self.pkg.changes["distribution"].keys():
1842                 for s in get_source_by_package_and_suite(b, suite, session):
1843                     if s.source != self.pkg.changes["source"]:
1844                         self.rejects.append("%s may not hijack %s from source package %s in suite %s" % (fpr.uid.uid, b, s, suite))
1845
1846
1847
1848     def check_transition(self, session):
1849         cnf = Config()
1850
1851         sourcepkg = self.pkg.changes["source"]
1852
1853         # No sourceful upload -> no need to do anything else, direct return
1854         # We also work with unstable uploads, not experimental or those going to some
1855         # proposed-updates queue
1856         if "source" not in self.pkg.changes["architecture"] or \
1857            "unstable" not in self.pkg.changes["distribution"]:
1858             return
1859
1860         # Also only check if there is a file defined (and existant) with
1861         # checks.
1862         transpath = cnf.get("Dinstall::ReleaseTransitions", "")
1863         if transpath == "" or not os.path.exists(transpath):
1864             return
1865
1866         # Parse the yaml file
1867         sourcefile = file(transpath, 'r')
1868         sourcecontent = sourcefile.read()
1869         try:
1870             transitions = yaml.load(sourcecontent)
1871         except yaml.YAMLError as msg:
1872             # This shouldn't happen, there is a wrapper to edit the file which
1873             # checks it, but we prefer to be safe than ending up rejecting
1874             # everything.
1875             utils.warn("Not checking transitions, the transitions file is broken: %s." % (msg))
1876             return
1877
1878         # Now look through all defined transitions
1879         for trans in transitions:
1880             t = transitions[trans]
1881             source = t["source"]
1882             expected = t["new"]
1883
1884             # Will be None if nothing is in testing.
1885             current = get_source_in_suite(source, "testing", session)
1886             if current is not None:
1887                 compare = apt_pkg.VersionCompare(current.version, expected)
1888
1889             if current is None or compare < 0:
1890                 # This is still valid, the current version in testing is older than
1891                 # the new version we wait for, or there is none in testing yet
1892
1893                 # Check if the source we look at is affected by this.
1894                 if sourcepkg in t['packages']:
1895                     # The source is affected, lets reject it.
1896
1897                     rejectmsg = "%s: part of the %s transition.\n\n" % (
1898                         sourcepkg, trans)
1899
1900                     if current is not None:
1901                         currentlymsg = "at version %s" % (current.version)
1902                     else:
1903                         currentlymsg = "not present in testing"
1904
1905                     rejectmsg += "Transition description: %s\n\n" % (t["reason"])
1906
1907                     rejectmsg += "\n".join(textwrap.wrap("""Your package
1908 is part of a testing transition designed to get %s migrated (it is
1909 currently %s, we need version %s).  This transition is managed by the
1910 Release Team, and %s is the Release-Team member responsible for it.
1911 Please mail debian-release@lists.debian.org or contact %s directly if you
1912 need further assistance.  You might want to upload to experimental until this
1913 transition is done."""
1914                             % (source, currentlymsg, expected,t["rm"], t["rm"])))
1915
1916                     self.rejects.append(rejectmsg)
1917                     return
1918
1919     ###########################################################################
1920     # End check_signed_by_key checks
1921     ###########################################################################
1922
1923     def build_summaries(self):
1924         """ Build a summary of changes the upload introduces. """
1925
1926         (byhand, new, summary, override_summary) = self.pkg.file_summary()
1927
1928         short_summary = summary
1929
1930         # This is for direport's benefit...
1931         f = re_fdnic.sub("\n .\n", self.pkg.changes.get("changes", ""))
1932
1933         if byhand or new:
1934             summary += "Changes: " + f
1935
1936         summary += "\n\nOverride entries for your package:\n" + override_summary + "\n"
1937
1938         summary += self.announce(short_summary, 0)
1939
1940         return (summary, short_summary)
1941
1942     ###########################################################################
1943
1944     def close_bugs(self, summary, action):
1945         """
1946         Send mail to close bugs as instructed by the closes field in the changes file.
1947         Also add a line to summary if any work was done.
1948
1949         @type summary: string
1950         @param summary: summary text, as given by L{build_summaries}
1951
1952         @type action: bool
1953         @param action: Set to false no real action will be done.
1954
1955         @rtype: string
1956         @return: summary. If action was taken, extended by the list of closed bugs.
1957
1958         """
1959
1960         template = os.path.join(Config()["Dir::Templates"], 'process-unchecked.bug-close')
1961
1962         bugs = self.pkg.changes["closes"].keys()
1963
1964         if not bugs:
1965             return summary
1966
1967         bugs.sort()
1968         summary += "Closing bugs: "
1969         for bug in bugs:
1970             summary += "%s " % (bug)
1971             if action:
1972                 self.update_subst()
1973                 self.Subst["__BUG_NUMBER__"] = bug
1974                 if self.pkg.changes["distribution"].has_key("stable"):
1975                     self.Subst["__STABLE_WARNING__"] = """
1976 Note that this package is not part of the released stable Debian
1977 distribution.  It may have dependencies on other unreleased software,
1978 or other instabilities.  Please take care if you wish to install it.
1979 The update will eventually make its way into the next released Debian
1980 distribution."""
1981                 else:
1982                     self.Subst["__STABLE_WARNING__"] = ""
1983                 mail_message = utils.TemplateSubst(self.Subst, template)
1984                 utils.send_mail(mail_message)
1985
1986                 # Clear up after ourselves
1987                 del self.Subst["__BUG_NUMBER__"]
1988                 del self.Subst["__STABLE_WARNING__"]
1989
1990         if action and self.logger:
1991             self.logger.log(["closing bugs"] + bugs)
1992
1993         summary += "\n"
1994
1995         return summary
1996
1997     ###########################################################################
1998
1999     def announce(self, short_summary, action):
2000         """
2001         Send an announce mail about a new upload.
2002
2003         @type short_summary: string
2004         @param short_summary: Short summary text to include in the mail
2005
2006         @type action: bool
2007         @param action: Set to false no real action will be done.
2008
2009         @rtype: string
2010         @return: Textstring about action taken.
2011
2012         """
2013
2014         cnf = Config()
2015
2016         # Skip all of this if not sending mail to avoid confusing people
2017         if cnf.has_key("Dinstall::Options::No-Mail") and cnf["Dinstall::Options::No-Mail"]:
2018             return ""
2019
2020         # Only do announcements for source uploads with a recent dpkg-dev installed
2021         if float(self.pkg.changes.get("format", 0)) < 1.6 or not \
2022            self.pkg.changes["architecture"].has_key("source"):
2023             return ""
2024
2025         announcetemplate = os.path.join(cnf["Dir::Templates"], 'process-unchecked.announce')
2026
2027         lists_todo = {}
2028         summary = ""
2029
2030         # Get a unique list of target lists
2031         for dist in self.pkg.changes["distribution"].keys():
2032             suite = get_suite(dist)
2033             if suite is None: continue
2034             for tgt in suite.announce:
2035                 lists_todo[tgt] = 1
2036
2037         self.Subst["__SHORT_SUMMARY__"] = short_summary
2038
2039         for announce_list in lists_todo.keys():
2040             summary += "Announcing to %s\n" % (announce_list)
2041
2042             if action:
2043                 self.update_subst()
2044                 self.Subst["__ANNOUNCE_LIST_ADDRESS__"] = announce_list
2045                 if cnf.get("Dinstall::TrackingServer") and \
2046                    self.pkg.changes["architecture"].has_key("source"):
2047                     trackingsendto = "Bcc: %s@%s" % (self.pkg.changes["source"], cnf["Dinstall::TrackingServer"])
2048                     self.Subst["__ANNOUNCE_LIST_ADDRESS__"] += "\n" + trackingsendto
2049
2050                 mail_message = utils.TemplateSubst(self.Subst, announcetemplate)
2051                 utils.send_mail(mail_message)
2052
2053                 del self.Subst["__ANNOUNCE_LIST_ADDRESS__"]
2054
2055         if cnf.FindB("Dinstall::CloseBugs") and cnf.has_key("Dinstall::BugServer"):
2056             summary = self.close_bugs(summary, action)
2057
2058         del self.Subst["__SHORT_SUMMARY__"]
2059
2060         return summary
2061
2062     ###########################################################################
2063     @session_wrapper
2064     def accept (self, summary, short_summary, session=None):
2065         """
2066         Accept an upload.
2067
2068         This moves all files referenced from the .changes into the pool,
2069         sends the accepted mail, announces to lists, closes bugs and
2070         also checks for override disparities. If enabled it will write out
2071         the version history for the BTS Version Tracking and will finally call
2072         L{queue_build}.
2073
2074         @type summary: string
2075         @param summary: Summary text
2076
2077         @type short_summary: string
2078         @param short_summary: Short summary
2079         """
2080
2081         cnf = Config()
2082         stats = SummaryStats()
2083
2084         print "Installing."
2085         self.logger.log(["installing changes", self.pkg.changes_file])
2086
2087         binaries = []
2088         poolfiles = []
2089
2090         # Add the .dsc file to the DB first
2091         for newfile, entry in self.pkg.files.items():
2092             if entry["type"] == "dsc":
2093                 source, dsc_component, dsc_location_id, pfs = add_dsc_to_db(self, newfile, session)
2094                 for j in pfs:
2095                     poolfiles.append(j)
2096
2097         # Add .deb / .udeb files to the DB (type is always deb, dbtype is udeb/deb)
2098         for newfile, entry in self.pkg.files.items():
2099             if entry["type"] == "deb":
2100                 b, pf = add_deb_to_db(self, newfile, session)
2101                 binaries.append(b)
2102                 poolfiles.append(pf)
2103
2104         # If this is a sourceful diff only upload that is moving
2105         # cross-component we need to copy the .orig files into the new
2106         # component too for the same reasons as above.
2107         # XXX: mhy: I think this should be in add_dsc_to_db
2108         if self.pkg.changes["architecture"].has_key("source"):
2109             for orig_file in self.pkg.orig_files.keys():
2110                 if not self.pkg.orig_files[orig_file].has_key("id"):
2111                     continue # Skip if it's not in the pool
2112                 orig_file_id = self.pkg.orig_files[orig_file]["id"]
2113                 if self.pkg.orig_files[orig_file]["location"] == dsc_location_id:
2114                     continue # Skip if the location didn't change
2115
2116                 # Do the move
2117                 oldf = get_poolfile_by_id(orig_file_id, session)
2118                 old_filename = os.path.join(oldf.location.path, oldf.filename)
2119                 old_dat = {'size': oldf.filesize,   'md5sum': oldf.md5sum,
2120                            'sha1sum': oldf.sha1sum, 'sha256sum': oldf.sha256sum}
2121
2122                 new_filename = os.path.join(utils.poolify(self.pkg.changes["source"], dsc_component), os.path.basename(old_filename))
2123
2124                 # TODO: Care about size/md5sum collisions etc
2125                 (found, newf) = check_poolfile(new_filename, old_dat['size'], old_dat['md5sum'], dsc_location_id, session)
2126
2127                 # TODO: Uhm, what happens if newf isn't None - something has gone badly and we should cope
2128                 if newf is None:
2129                     utils.copy(old_filename, os.path.join(cnf["Dir::Pool"], new_filename))
2130                     newf = add_poolfile(new_filename, old_dat, dsc_location_id, session)
2131
2132                     session.flush()
2133
2134                     # Don't reference the old file from this changes
2135                     for p in poolfiles:
2136                         if p.file_id == oldf.file_id:
2137                             poolfiles.remove(p)
2138
2139                     poolfiles.append(newf)
2140
2141                     # Fix up the DSC references
2142                     toremove = []
2143
2144                     for df in source.srcfiles:
2145                         if df.poolfile.file_id == oldf.file_id:
2146                             # Add a new DSC entry and mark the old one for deletion
2147                             # Don't do it in the loop so we don't change the thing we're iterating over
2148                             newdscf = DSCFile()
2149                             newdscf.source_id = source.source_id
2150                             newdscf.poolfile_id = newf.file_id
2151                             session.add(newdscf)
2152
2153                             toremove.append(df)
2154
2155                     for df in toremove:
2156                         session.delete(df)
2157
2158                     # Flush our changes
2159                     session.flush()
2160
2161                     # Make sure that our source object is up-to-date
2162                     session.expire(source)
2163
2164         # Add changelog information to the database
2165         self.store_changelog()
2166
2167         # Install the files into the pool
2168         for newfile, entry in self.pkg.files.items():
2169             destination = os.path.join(cnf["Dir::Pool"], entry["pool name"], newfile)
2170             utils.move(newfile, destination)
2171             self.logger.log(["installed", newfile, entry["type"], entry["size"], entry["architecture"]])
2172             stats.accept_bytes += float(entry["size"])
2173
2174         # Copy the .changes file across for suite which need it.
2175         copy_changes = dict([(x.copychanges, '')
2176                              for x in session.query(Suite).filter(Suite.suite_name.in_(self.pkg.changes["distribution"].keys())).all()
2177                              if x.copychanges is not None])
2178
2179         for dest in copy_changes.keys():
2180             utils.copy(self.pkg.changes_file, os.path.join(cnf["Dir::Root"], dest))
2181
2182         # We're done - commit the database changes
2183         session.commit()
2184         # Our SQL session will automatically start a new transaction after
2185         # the last commit
2186
2187         # Now ensure that the metadata has been added
2188         # This has to be done after we copy the files into the pool
2189         # For source if we have it:
2190         if self.pkg.changes["architecture"].has_key("source"):
2191             import_metadata_into_db(source, session)
2192
2193         # Now for any of our binaries
2194         for b in binaries:
2195             import_metadata_into_db(b, session)
2196
2197         session.commit()
2198
2199         # Move the .changes into the 'done' directory
2200         ye, mo, da = time.gmtime()[0:3]
2201         donedir = os.path.join(cnf["Dir::Done"], str(ye), "%0.2d" % mo, "%0.2d" % da)
2202         if not os.path.isdir(donedir):
2203             os.makedirs(donedir)
2204
2205         utils.move(self.pkg.changes_file,
2206                    os.path.join(donedir, os.path.basename(self.pkg.changes_file)))
2207
2208         if self.pkg.changes["architecture"].has_key("source"):
2209             UrgencyLog().log(self.pkg.dsc["source"], self.pkg.dsc["version"], self.pkg.changes["urgency"])
2210
2211         self.update_subst()
2212         self.Subst["__SUMMARY__"] = summary
2213         mail_message = utils.TemplateSubst(self.Subst,
2214                                            os.path.join(cnf["Dir::Templates"], 'process-unchecked.accepted'))
2215         utils.send_mail(mail_message)
2216         self.announce(short_summary, 1)
2217
2218         ## Helper stuff for DebBugs Version Tracking
2219         if cnf.Find("Dir::BTSVersionTrack"):
2220             if self.pkg.changes["architecture"].has_key("source"):
2221                 (fd, temp_filename) = utils.temp_filename(cnf["Dir::BTSVersionTrack"], prefix=".")
2222                 version_history = os.fdopen(fd, 'w')
2223                 version_history.write(self.pkg.dsc["bts changelog"])
2224                 version_history.close()
2225                 filename = "%s/%s" % (cnf["Dir::BTSVersionTrack"],
2226                                       self.pkg.changes_file[:-8]+".versions")
2227                 os.rename(temp_filename, filename)
2228                 os.chmod(filename, 0644)
2229
2230             # Write out the binary -> source mapping.
2231             (fd, temp_filename) = utils.temp_filename(cnf["Dir::BTSVersionTrack"], prefix=".")
2232             debinfo = os.fdopen(fd, 'w')
2233             for name, entry in sorted(self.pkg.files.items()):
2234                 if entry["type"] == "deb":
2235                     line = " ".join([entry["package"], entry["version"],
2236                                      entry["architecture"], entry["source package"],
2237                                      entry["source version"]])
2238                     debinfo.write(line+"\n")
2239             debinfo.close()
2240             filename = "%s/%s" % (cnf["Dir::BTSVersionTrack"],
2241                                   self.pkg.changes_file[:-8]+".debinfo")
2242             os.rename(temp_filename, filename)
2243             os.chmod(filename, 0644)
2244
2245         session.commit()
2246
2247         # Set up our copy queues (e.g. buildd queues)
2248         for suite_name in self.pkg.changes["distribution"].keys():
2249             suite = get_suite(suite_name, session)
2250             for q in suite.copy_queues:
2251                 for f in poolfiles:
2252                     q.add_file_from_pool(f)
2253
2254         session.commit()
2255
2256         # Finally...
2257         stats.accept_count += 1
2258
2259     def check_override(self):
2260         """
2261         Checks override entries for validity. Mails "Override disparity" warnings,
2262         if that feature is enabled.
2263
2264         Abandons the check if
2265           - override disparity checks are disabled
2266           - mail sending is disabled
2267         """
2268
2269         cnf = Config()
2270
2271         # Abandon the check if override disparity checks have been disabled
2272         if not cnf.FindB("Dinstall::OverrideDisparityCheck"):
2273             return
2274
2275         summary = self.pkg.check_override()
2276
2277         if summary == "":
2278             return
2279
2280         overridetemplate = os.path.join(cnf["Dir::Templates"], 'process-unchecked.override-disparity')
2281
2282         self.update_subst()
2283         self.Subst["__SUMMARY__"] = summary
2284         mail_message = utils.TemplateSubst(self.Subst, overridetemplate)
2285         utils.send_mail(mail_message)
2286         del self.Subst["__SUMMARY__"]
2287
2288     ###########################################################################
2289
2290     def remove(self, from_dir=None):
2291         """
2292         Used (for instance) in p-u to remove the package from unchecked
2293
2294         Also removes the package from holding area.
2295         """
2296         if from_dir is None:
2297             from_dir = self.pkg.directory
2298         h = Holding()
2299
2300         for f in self.pkg.files.keys():
2301             os.unlink(os.path.join(from_dir, f))
2302             if os.path.exists(os.path.join(h.holding_dir, f)):
2303                 os.unlink(os.path.join(h.holding_dir, f))
2304
2305         os.unlink(os.path.join(from_dir, self.pkg.changes_file))
2306         if os.path.exists(os.path.join(h.holding_dir, self.pkg.changes_file)):
2307             os.unlink(os.path.join(h.holding_dir, self.pkg.changes_file))
2308
2309     ###########################################################################
2310
2311     def move_to_queue (self, queue):
2312         """
2313         Move files to a destination queue using the permissions in the table
2314         """
2315         h = Holding()
2316         utils.move(os.path.join(h.holding_dir, self.pkg.changes_file),
2317                    queue.path, perms=int(queue.change_perms, 8))
2318         for f in self.pkg.files.keys():
2319             utils.move(os.path.join(h.holding_dir, f), queue.path, perms=int(queue.perms, 8))
2320
2321     ###########################################################################
2322
2323     def force_reject(self, reject_files):
2324         """
2325         Forcefully move files from the current directory to the
2326         reject directory.  If any file already exists in the reject
2327         directory it will be moved to the morgue to make way for
2328         the new file.
2329
2330         @type reject_files: dict
2331         @param reject_files: file dictionary
2332
2333         """
2334
2335         cnf = Config()
2336
2337         for file_entry in reject_files:
2338             # Skip any files which don't exist or which we don't have permission to copy.
2339             if os.access(file_entry, os.R_OK) == 0:
2340                 continue
2341
2342             dest_file = os.path.join(cnf["Dir::Reject"], file_entry)
2343
2344             try:
2345                 dest_fd = os.open(dest_file, os.O_RDWR | os.O_CREAT | os.O_EXCL, 0644)
2346             except OSError as e:
2347                 # File exists?  Let's find a new name by adding a number
2348                 if e.errno == errno.EEXIST:
2349                     try:
2350                         dest_file = utils.find_next_free(dest_file, 255)
2351                     except NoFreeFilenameError:
2352                         # Something's either gone badly Pete Tong, or
2353                         # someone is trying to exploit us.
2354                         utils.warn("**WARNING** failed to find a free filename for %s in %s." % (file_entry, cnf["Dir::Reject"]))
2355                         return
2356
2357                     # Make sure we really got it
2358                     try:
2359                         dest_fd = os.open(dest_file, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0644)
2360                     except OSError as e:
2361                         # Likewise
2362                         utils.warn("**WARNING** failed to claim %s in the reject directory." % (file_entry))
2363                         return
2364                 else:
2365                     raise
2366             # If we got here, we own the destination file, so we can
2367             # safely overwrite it.
2368             utils.move(file_entry, dest_file, 1, perms=0660)
2369             os.close(dest_fd)
2370
2371     ###########################################################################
2372     def do_reject (self, manual=0, reject_message="", notes=""):
2373         """
2374         Reject an upload. If called without a reject message or C{manual} is
2375         true, spawn an editor so the user can write one.
2376
2377         @type manual: bool
2378         @param manual: manual or automated rejection
2379
2380         @type reject_message: string
2381         @param reject_message: A reject message
2382
2383         @return: 0
2384
2385         """
2386         # If we weren't given a manual rejection message, spawn an
2387         # editor so the user can add one in...
2388         if manual and not reject_message:
2389             (fd, temp_filename) = utils.temp_filename()
2390             temp_file = os.fdopen(fd, 'w')
2391             if len(notes) > 0:
2392                 for note in notes:
2393                     temp_file.write("\nAuthor: %s\nVersion: %s\nTimestamp: %s\n\n%s" \
2394                                     % (note.author, note.version, note.notedate, note.comment))
2395             temp_file.close()
2396             editor = os.environ.get("EDITOR","vi")
2397             answer = 'E'
2398             while answer == 'E':
2399                 os.system("%s %s" % (editor, temp_filename))
2400                 temp_fh = utils.open_file(temp_filename)
2401                 reject_message = "".join(temp_fh.readlines())
2402                 temp_fh.close()
2403                 print "Reject message:"
2404                 print utils.prefix_multi_line_string(reject_message,"  ",include_blank_lines=1)
2405                 prompt = "[R]eject, Edit, Abandon, Quit ?"
2406                 answer = "XXX"
2407                 while prompt.find(answer) == -1:
2408                     answer = utils.our_raw_input(prompt)
2409                     m = re_default_answer.search(prompt)
2410                     if answer == "":
2411                         answer = m.group(1)
2412                     answer = answer[:1].upper()
2413             os.unlink(temp_filename)
2414             if answer == 'A':
2415                 return 1
2416             elif answer == 'Q':
2417                 sys.exit(0)
2418
2419         print "Rejecting.\n"
2420
2421         cnf = Config()
2422
2423         reason_filename = self.pkg.changes_file[:-8] + ".reason"
2424         reason_filename = os.path.join(cnf["Dir::Reject"], reason_filename)
2425
2426         # Move all the files into the reject directory
2427         reject_files = self.pkg.files.keys() + [self.pkg.changes_file]
2428         self.force_reject(reject_files)
2429
2430         # If we fail here someone is probably trying to exploit the race
2431         # so let's just raise an exception ...
2432         if os.path.exists(reason_filename):
2433             os.unlink(reason_filename)
2434         reason_fd = os.open(reason_filename, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0644)
2435
2436         rej_template = os.path.join(cnf["Dir::Templates"], "queue.rejected")
2437
2438         self.update_subst()
2439         if not manual:
2440             self.Subst["__REJECTOR_ADDRESS__"] = cnf["Dinstall::MyEmailAddress"]
2441             self.Subst["__MANUAL_REJECT_MESSAGE__"] = ""
2442             self.Subst["__CC__"] = "X-DAK-Rejection: automatic (moo)"
2443             os.write(reason_fd, reject_message)
2444             reject_mail_message = utils.TemplateSubst(self.Subst, rej_template)
2445         else:
2446             # Build up the rejection email
2447             user_email_address = utils.whoami() + " <%s>" % (cnf["Dinstall::MyAdminAddress"])
2448             self.Subst["__REJECTOR_ADDRESS__"] = user_email_address
2449             self.Subst["__MANUAL_REJECT_MESSAGE__"] = reject_message
2450             self.Subst["__REJECT_MESSAGE__"] = ""
2451             self.Subst["__CC__"] = "Cc: " + cnf["Dinstall::MyEmailAddress"]
2452             reject_mail_message = utils.TemplateSubst(self.Subst, rej_template)
2453             # Write the rejection email out as the <foo>.reason file
2454             os.write(reason_fd, reject_mail_message)
2455
2456         del self.Subst["__REJECTOR_ADDRESS__"]
2457         del self.Subst["__MANUAL_REJECT_MESSAGE__"]
2458         del self.Subst["__CC__"]
2459
2460         os.close(reason_fd)
2461
2462         # Send the rejection mail
2463         utils.send_mail(reject_mail_message)
2464
2465         if self.logger:
2466             self.logger.log(["rejected", self.pkg.changes_file])
2467
2468         stats = SummaryStats()
2469         stats.reject_count += 1
2470         return 0
2471
2472     ################################################################################
2473     def in_override_p(self, package, component, suite, binary_type, filename, session):
2474         """
2475         Check if a package already has override entries in the DB
2476
2477         @type package: string
2478         @param package: package name
2479
2480         @type component: string
2481         @param component: database id of the component
2482
2483         @type suite: int
2484         @param suite: database id of the suite
2485
2486         @type binary_type: string
2487         @param binary_type: type of the package
2488
2489         @type filename: string
2490         @param filename: filename we check
2491
2492         @return: the database result. But noone cares anyway.
2493
2494         """
2495
2496         cnf = Config()
2497
2498         if binary_type == "": # must be source
2499             file_type = "dsc"
2500         else:
2501             file_type = binary_type
2502
2503         # Override suite name; used for example with proposed-updates
2504         oldsuite = get_suite(suite, session)
2505         if (not oldsuite is None) and oldsuite.overridesuite:
2506             suite = oldsuite.overridesuite
2507
2508         result = get_override(package, suite, component, file_type, session)
2509
2510         # If checking for a source package fall back on the binary override type
2511         if file_type == "dsc" and len(result) < 1:
2512             result = get_override(package, suite, component, ['deb', 'udeb'], session)
2513
2514         # Remember the section and priority so we can check them later if appropriate
2515         if len(result) > 0:
2516             result = result[0]
2517             self.pkg.files[filename]["override section"] = result.section.section
2518             self.pkg.files[filename]["override priority"] = result.priority.priority
2519             return result
2520
2521         return None
2522
2523     ################################################################################
2524     def get_anyversion(self, sv_list, suite):
2525         """
2526         @type sv_list: list
2527         @param sv_list: list of (suite, version) tuples to check
2528
2529         @type suite: string
2530         @param suite: suite name
2531
2532         Description: TODO
2533         """
2534         Cnf = Config()
2535         anyversion = None
2536         anysuite = [suite] + [ vc.reference.suite_name for vc in get_version_checks(suite, "Enhances") ]
2537         for (s, v) in sv_list:
2538             if s in [ x.lower() for x in anysuite ]:
2539                 if not anyversion or apt_pkg.VersionCompare(anyversion, v) <= 0:
2540                     anyversion = v
2541
2542         return anyversion
2543
2544     ################################################################################
2545
2546     def cross_suite_version_check(self, sv_list, filename, new_version, sourceful=False):
2547         """
2548         @type sv_list: list
2549         @param sv_list: list of (suite, version) tuples to check
2550
2551         @type filename: string
2552         @param filename: XXX
2553
2554         @type new_version: string
2555         @param new_version: XXX
2556
2557         Ensure versions are newer than existing packages in target
2558         suites and that cross-suite version checking rules as
2559         set out in the conf file are satisfied.
2560         """
2561
2562         cnf = Config()
2563
2564         # Check versions for each target suite
2565         for target_suite in self.pkg.changes["distribution"].keys():
2566             # Check we can find the target suite
2567             ts = get_suite(target_suite)
2568             if ts is None:
2569                 self.rejects.append("Cannot find target suite %s to perform version checks" % target_suite)
2570                 continue
2571
2572             must_be_newer_than = [ vc.reference.suite_name for vc in get_version_checks(target_suite, "MustBeNewerThan") ]
2573             must_be_older_than = [ vc.reference.suite_name for vc in get_version_checks(target_suite, "MustBeOlderThan") ]
2574
2575             # Enforce "must be newer than target suite" even if conffile omits it
2576             if target_suite not in must_be_newer_than:
2577                 must_be_newer_than.append(target_suite)
2578
2579             for (suite, existent_version) in sv_list:
2580                 vercmp = apt_pkg.VersionCompare(new_version, existent_version)
2581
2582                 if suite in must_be_newer_than and sourceful and vercmp < 1:
2583                     self.rejects.append("%s: old version (%s) in %s >= new version (%s) targeted at %s." % (filename, existent_version, suite, new_version, target_suite))
2584
2585                 if suite in must_be_older_than and vercmp > -1:
2586                     cansave = 0
2587
2588                     if self.pkg.changes.get('distribution-version', {}).has_key(suite):
2589                         # we really use the other suite, ignoring the conflicting one ...
2590                         addsuite = self.pkg.changes["distribution-version"][suite]
2591
2592                         add_version = self.get_anyversion(sv_list, addsuite)
2593                         target_version = self.get_anyversion(sv_list, target_suite)
2594
2595                         if not add_version:
2596                             # not add_version can only happen if we map to a suite
2597                             # that doesn't enhance the suite we're propup'ing from.
2598                             # so "propup-ver x a b c; map a d" is a problem only if
2599                             # d doesn't enhance a.
2600                             #
2601                             # i think we could always propagate in this case, rather
2602                             # than complaining. either way, this isn't a REJECT issue
2603                             #
2604                             # And - we really should complain to the dorks who configured dak
2605                             self.warnings.append("%s is mapped to, but not enhanced by %s - adding anyways" % (suite, addsuite))
2606                             self.pkg.changes.setdefault("propdistribution", {})
2607                             self.pkg.changes["propdistribution"][addsuite] = 1
2608                             cansave = 1
2609                         elif not target_version:
2610                             # not targets_version is true when the package is NEW
2611                             # we could just stick with the "...old version..." REJECT
2612                             # for this, I think.
2613                             self.rejects.append("Won't propogate NEW packages.")
2614                         elif apt_pkg.VersionCompare(new_version, add_version) < 0:
2615                             # propogation would be redundant. no need to reject though.
2616                             self.warnings.append("ignoring versionconflict: %s: old version (%s) in %s <= new version (%s) targeted at %s." % (filename, existent_version, suite, new_version, target_suite))
2617                             cansave = 1
2618                         elif apt_pkg.VersionCompare(new_version, add_version) > 0 and \
2619                              apt_pkg.VersionCompare(add_version, target_version) >= 0:
2620                             # propogate!!
2621                             self.warnings.append("Propogating upload to %s" % (addsuite))
2622                             self.pkg.changes.setdefault("propdistribution", {})
2623                             self.pkg.changes["propdistribution"][addsuite] = 1
2624                             cansave = 1
2625
2626                     if not cansave:
2627                         self.rejects.append("%s: old version (%s) in %s <= new version (%s) targeted at %s." % (filename, existent_version, suite, new_version, target_suite))
2628
2629     ################################################################################
2630     def check_binary_against_db(self, filename, session):
2631         # Ensure version is sane
2632         self.cross_suite_version_check( \
2633             get_suite_version_by_package(self.pkg.files[filename]["package"], \
2634                 self.pkg.files[filename]["architecture"], session),
2635             filename, self.pkg.files[filename]["version"], sourceful=False)
2636
2637         # Check for any existing copies of the file
2638         q = session.query(DBBinary).filter_by(package=self.pkg.files[filename]["package"])
2639         q = q.filter_by(version=self.pkg.files[filename]["version"])
2640         q = q.join(Architecture).filter_by(arch_string=self.pkg.files[filename]["architecture"])
2641
2642         if q.count() > 0:
2643             self.rejects.append("%s: can not overwrite existing copy already in the archive." % filename)
2644
2645     ################################################################################
2646
2647     def check_source_against_db(self, filename, session):
2648         source = self.pkg.dsc.get("source")
2649         version = self.pkg.dsc.get("version")
2650
2651         # Ensure version is sane
2652         self.cross_suite_version_check( \
2653             get_suite_version_by_source(source, session), filename, version,
2654             sourceful=True)
2655
2656     ################################################################################
2657     def check_dsc_against_db(self, filename, session):
2658         """
2659
2660         @warning: NB: this function can remove entries from the 'files' index [if
2661          the orig tarball is a duplicate of the one in the archive]; if
2662          you're iterating over 'files' and call this function as part of
2663          the loop, be sure to add a check to the top of the loop to
2664          ensure you haven't just tried to dereference the deleted entry.
2665
2666         """
2667
2668         Cnf = Config()
2669         self.pkg.orig_files = {} # XXX: do we need to clear it?
2670         orig_files = self.pkg.orig_files
2671
2672         # Try and find all files mentioned in the .dsc.  This has
2673         # to work harder to cope with the multiple possible
2674         # locations of an .orig.tar.gz.
2675         # The ordering on the select is needed to pick the newest orig
2676         # when it exists in multiple places.
2677         for dsc_name, dsc_entry in self.pkg.dsc_files.items():
2678             found = None
2679             if self.pkg.files.has_key(dsc_name):
2680                 actual_md5 = self.pkg.files[dsc_name]["md5sum"]
2681                 actual_size = int(self.pkg.files[dsc_name]["size"])
2682                 found = "%s in incoming" % (dsc_name)
2683
2684                 # Check the file does not already exist in the archive
2685                 ql = get_poolfile_like_name(dsc_name, session)
2686
2687                 # Strip out anything that isn't '%s' or '/%s$'
2688                 for i in ql:
2689                     if not i.filename.endswith(dsc_name):
2690                         ql.remove(i)
2691
2692                 # "[dak] has not broken them.  [dak] has fixed a
2693                 # brokenness.  Your crappy hack exploited a bug in
2694                 # the old dinstall.
2695                 #
2696                 # "(Come on!  I thought it was always obvious that
2697                 # one just doesn't release different files with
2698                 # the same name and version.)"
2699                 #                        -- ajk@ on d-devel@l.d.o
2700
2701                 if len(ql) > 0:
2702                     # Ignore exact matches for .orig.tar.gz
2703                     match = 0
2704                     if re_is_orig_source.match(dsc_name):
2705                         for i in ql:
2706                             if self.pkg.files.has_key(dsc_name) and \
2707                                int(self.pkg.files[dsc_name]["size"]) == int(i.filesize) and \
2708                                self.pkg.files[dsc_name]["md5sum"] == i.md5sum:
2709                                 self.warnings.append("ignoring %s, since it's already in the archive." % (dsc_name))
2710                                 # TODO: Don't delete the entry, just mark it as not needed
2711                                 # This would fix the stupidity of changing something we often iterate over
2712                                 # whilst we're doing it
2713                                 del self.pkg.files[dsc_name]
2714                                 dsc_entry["files id"] = i.file_id
2715                                 if not orig_files.has_key(dsc_name):
2716                                     orig_files[dsc_name] = {}
2717                                 orig_files[dsc_name]["path"] = os.path.join(i.location.path, i.filename)
2718                                 match = 1
2719
2720                                 # Don't bitch that we couldn't find this file later
2721                                 try:
2722                                     self.later_check_files.remove(dsc_name)
2723                                 except ValueError:
2724                                     pass
2725
2726
2727                     if not match:
2728                         self.rejects.append("can not overwrite existing copy of '%s' already in the archive." % (dsc_name))
2729
2730             elif re_is_orig_source.match(dsc_name):
2731                 # Check in the pool
2732                 ql = get_poolfile_like_name(dsc_name, session)
2733
2734                 # Strip out anything that isn't '%s' or '/%s$'
2735                 # TODO: Shouldn't we just search for things which end with our string explicitly in the SQL?
2736                 for i in ql:
2737                     if not i.filename.endswith(dsc_name):
2738                         ql.remove(i)
2739
2740                 if len(ql) > 0:
2741                     # Unfortunately, we may get more than one match here if,
2742                     # for example, the package was in potato but had an -sa
2743                     # upload in woody.  So we need to choose the right one.
2744
2745                     # default to something sane in case we don't match any or have only one
2746                     x = ql[0]
2747
2748                     if len(ql) > 1:
2749                         for i in ql:
2750                             old_file = os.path.join(i.location.path, i.filename)
2751                             old_file_fh = utils.open_file(old_file)
2752                             actual_md5 = apt_pkg.md5sum(old_file_fh)
2753                             old_file_fh.close()
2754                             actual_size = os.stat(old_file)[stat.ST_SIZE]
2755                             if actual_md5 == dsc_entry["md5sum"] and actual_size == int(dsc_entry["size"]):
2756                                 x = i
2757
2758                     old_file = os.path.join(i.location.path, i.filename)
2759                     old_file_fh = utils.open_file(old_file)
2760                     actual_md5 = apt_pkg.md5sum(old_file_fh)
2761                     old_file_fh.close()
2762                     actual_size = os.stat(old_file)[stat.ST_SIZE]
2763                     found = old_file
2764                     suite_type = x.location.archive_type
2765                     # need this for updating dsc_files in install()
2766                     dsc_entry["files id"] = x.file_id
2767                     # See install() in process-accepted...
2768                     if not orig_files.has_key(dsc_name):
2769                         orig_files[dsc_name] = {}
2770                     orig_files[dsc_name]["id"] = x.file_id
2771                     orig_files[dsc_name]["path"] = old_file
2772                     orig_files[dsc_name]["location"] = x.location.location_id
2773                 else:
2774                     # TODO: Determine queue list dynamically
2775                     # Not there? Check the queue directories...
2776                     for queue_name in [ "byhand", "new", "proposedupdates", "oldproposedupdates", "embargoed", "unembargoed" ]:
2777                         queue = get_policy_queue(queue_name, session)
2778                         if not queue:
2779                             continue
2780
2781                         in_otherdir = os.path.join(queue.path, dsc_name)
2782
2783                         if os.path.exists(in_otherdir):
2784                             in_otherdir_fh = utils.open_file(in_otherdir)
2785                             actual_md5 = apt_pkg.md5sum(in_otherdir_fh)
2786                             in_otherdir_fh.close()
2787                             actual_size = os.stat(in_otherdir)[stat.ST_SIZE]
2788                             found = in_otherdir
2789                             if not orig_files.has_key(dsc_name):
2790                                 orig_files[dsc_name] = {}
2791                             orig_files[dsc_name]["path"] = in_otherdir
2792
2793                     if not found:
2794                         self.rejects.append("%s refers to %s, but I can't find it in the queue or in the pool." % (filename, dsc_name))
2795                         continue
2796             else:
2797                 self.rejects.append("%s refers to %s, but I can't find it in the queue." % (filename, dsc_name))
2798                 continue
2799             if actual_md5 != dsc_entry["md5sum"]:
2800                 self.rejects.append("md5sum for %s doesn't match %s." % (found, filename))
2801             if actual_size != int(dsc_entry["size"]):
2802                 self.rejects.append("size for %s doesn't match %s." % (found, filename))
2803
2804     ################################################################################
2805     # This is used by process-new and process-holding to recheck a changes file
2806     # at the time we're running.  It mainly wraps various other internal functions
2807     # and is similar to accepted_checks - these should probably be tidied up
2808     # and combined
2809     def recheck(self, session):
2810         cnf = Config()
2811         for f in self.pkg.files.keys():
2812             # The .orig.tar.gz can disappear out from under us is it's a
2813             # duplicate of one in the archive.
2814             if not self.pkg.files.has_key(f):
2815                 continue
2816
2817             entry = self.pkg.files[f]
2818
2819             # Check that the source still exists
2820             if entry["type"] == "deb":
2821                 source_version = entry["source version"]
2822                 source_package = entry["source package"]
2823                 if not self.pkg.changes["architecture"].has_key("source") \
2824                    and not source_exists(source_package, source_version, \
2825                     suites = self.pkg.changes["distribution"].keys(), session = session):
2826                     source_epochless_version = re_no_epoch.sub('', source_version)
2827                     dsc_filename = "%s_%s.dsc" % (source_package, source_epochless_version)
2828                     found = False
2829                     for queue_name in ["embargoed", "unembargoed", "newstage"]:
2830                         queue = get_policy_queue(queue_name, session)
2831                         if queue and os.path.exists(os.path.join(queue.path, dsc_filename)):
2832                             found = True
2833                     if not found:
2834                         self.rejects.append("no source found for %s %s (%s)." % (source_package, source_version, f))
2835
2836             # Version and file overwrite checks
2837             if entry["type"] == "deb":
2838                 self.check_binary_against_db(f, session)
2839             elif entry["type"] == "dsc":
2840                 self.check_source_against_db(f, session)
2841                 self.check_dsc_against_db(f, session)
2842
2843     ################################################################################
2844     def accepted_checks(self, overwrite_checks, session):
2845         # Recheck anything that relies on the database; since that's not
2846         # frozen between accept and our run time when called from p-a.
2847
2848         # overwrite_checks is set to False when installing to stable/oldstable
2849
2850         propogate={}
2851         nopropogate={}
2852
2853         # Find the .dsc (again)
2854         dsc_filename = None
2855         for f in self.pkg.files.keys():
2856             if self.pkg.files[f]["type"] == "dsc":
2857                 dsc_filename = f
2858
2859         for checkfile in self.pkg.files.keys():
2860             # The .orig.tar.gz can disappear out from under us is it's a
2861             # duplicate of one in the archive.
2862             if not self.pkg.files.has_key(checkfile):
2863                 continue
2864
2865             entry = self.pkg.files[checkfile]
2866
2867             # Check that the source still exists
2868             if entry["type"] == "deb":
2869                 source_version = entry["source version"]
2870                 source_package = entry["source package"]
2871                 if not self.pkg.changes["architecture"].has_key("source") \
2872                    and not source_exists(source_package, source_version, \
2873                     suites = self.pkg.changes["distribution"].keys(), \
2874                     session = session):
2875                     self.rejects.append("no source found for %s %s (%s)." % (source_package, source_version, checkfile))
2876
2877             # Version and file overwrite checks
2878             if overwrite_checks:
2879                 if entry["type"] == "deb":
2880                     self.check_binary_against_db(checkfile, session)
2881                 elif entry["type"] == "dsc":
2882                     self.check_source_against_db(checkfile, session)
2883                     self.check_dsc_against_db(dsc_filename, session)
2884
2885             # propogate in the case it is in the override tables:
2886             for suite in self.pkg.changes.get("propdistribution", {}).keys():
2887                 if self.in_override_p(entry["package"], entry["component"], suite, entry.get("dbtype",""), checkfile, session):
2888                     propogate[suite] = 1
2889                 else:
2890                     nopropogate[suite] = 1
2891
2892         for suite in propogate.keys():
2893             if suite in nopropogate:
2894                 continue
2895             self.pkg.changes["distribution"][suite] = 1
2896
2897         for checkfile in self.pkg.files.keys():
2898             # Check the package is still in the override tables
2899             for suite in self.pkg.changes["distribution"].keys():
2900                 if not self.in_override_p(entry["package"], entry["component"], suite, entry.get("dbtype",""), checkfile, session):
2901                     self.rejects.append("%s is NEW for %s." % (checkfile, suite))
2902
2903     ################################################################################
2904     # If any file of an upload has a recent mtime then chances are good
2905     # the file is still being uploaded.
2906
2907     def upload_too_new(self):
2908         cnf = Config()
2909         too_new = False
2910         # Move back to the original directory to get accurate time stamps
2911         cwd = os.getcwd()
2912         os.chdir(self.pkg.directory)
2913         file_list = self.pkg.files.keys()
2914         file_list.extend(self.pkg.dsc_files.keys())
2915         file_list.append(self.pkg.changes_file)
2916         for f in file_list:
2917             try:
2918                 last_modified = time.time()-os.path.getmtime(f)
2919                 if last_modified < int(cnf["Dinstall::SkipTime"]):
2920                     too_new = True
2921                     break
2922             except:
2923                 pass
2924
2925         os.chdir(cwd)
2926         return too_new
2927
2928     def store_changelog(self):
2929
2930         # Skip binary-only upload if it is not a bin-NMU
2931         if not self.pkg.changes['architecture'].has_key('source'):
2932             from daklib.regexes import re_bin_only_nmu
2933             if not re_bin_only_nmu.search(self.pkg.changes['version']):
2934                 return
2935
2936         session = DBConn().session()
2937
2938         # Check if upload already has a changelog entry
2939         query = """SELECT changelog_id FROM changes WHERE source = :source
2940                    AND version = :version AND architecture = :architecture AND changelog_id != 0"""
2941         if session.execute(query, {'source': self.pkg.changes['source'], \
2942                                    'version': self.pkg.changes['version'], \
2943                                    'architecture': " ".join(self.pkg.changes['architecture'].keys())}).rowcount:
2944             session.commit()
2945             return
2946
2947         # Add current changelog text into changelogs_text table, return created ID
2948         query = "INSERT INTO changelogs_text (changelog) VALUES (:changelog) RETURNING id"
2949         ID = session.execute(query, {'changelog': self.pkg.changes['changes']}).fetchone()[0]
2950
2951         # Link ID to the upload available in changes table
2952         query = """UPDATE changes SET changelog_id = :id WHERE source = :source
2953                    AND version = :version AND architecture = :architecture"""
2954         session.execute(query, {'id': ID, 'source': self.pkg.changes['source'], \
2955                                 'version': self.pkg.changes['version'], \
2956                                 'architecture': " ".join(self.pkg.changes['architecture'].keys())})
2957
2958         session.commit()