]> git.donarmstrong.com Git - lilypond.git/commit
Don't use virtual base classes without apparent reason
authorDavid Kastrup <dak@gnu.org>
Sat, 28 Apr 2012 13:23:08 +0000 (15:23 +0200)
committerDavid Kastrup <dak@gnu.org>
Fri, 4 May 2012 15:54:19 +0000 (17:54 +0200)
commit77cd92ff6a0547403b3a524b5c4ec95a8d1cbdd9
tree05ce25af90fb9efecc39c10f4faba08c2f824018
parent76465a6d1c77ff1b30e5c61e9e06178b8d5290d4
Don't use virtual base classes without apparent reason

Virtual base classes are a tool for joining the representations of common
ancestors in a class lattice.  They come at a cost in computational,
conceptual, and usability complexity.

I can't see the purpose for the instances of virtual inheritance in
LilyPond (without multiple inheritance, there can't be much of an effect).
lily/include/engraver-group.hh
lily/include/global-context.hh
lily/include/performer-group.hh