From: David Kastrup <dak@gnu.org>
Date: Tue, 8 May 2012 13:30:05 +0000 (+0200)
Subject: Remove test numbering in display-lily-tests
X-Git-Tag: release/2.15.39-1~41
X-Git-Url: https://git.donarmstrong.com/lilypond.git?a=commitdiff_plain;h=c6933c1cf38de6dffbbcf7707be633b224891bd5;p=lilypond.git

Remove test numbering in display-lily-tests

Numbering the tests made it impossible to extend the tests in logical order
without causing regtest output differences in unrelated output.  Failing
tests are now instead flagged using warnings, thus giving accurate
pointers to the problematic line numbers instead of numbers without
conclusive source info.  Passing tests with verbose output don't contain
any line number info.  This is a prerequisite for extending the test suite
without causing false positives.
---

diff --git a/input/regression/display-lily-tests.ly b/input/regression/display-lily-tests.ly
index 22eaf893d3..fdec20519e 100644
--- a/input/regression/display-lily-tests.ly
+++ b/input/regression/display-lily-tests.ly
@@ -27,16 +27,16 @@
    (make-column-markup (string-split str #\NewLine)))
 
 test =
-#(let ((test-number 0))
-  (define-void-function (parser location result-info strings)
-   ((string? "BUG") pair?)
-   (let ((input (car strings))
-	 (output (cdr strings)))
-    (set! test-number (1+ test-number))
-    (if (not (equal? input output))
-     (ly:progress "Test ~a unequal: ~a. \nin  = ~a\nout = ~a\n"
-      test-number
-      result-info
+#(define-void-function (parser location harmless strings)
+  ((string?) pair?)
+  (let ((input (car strings))
+	(output (cdr strings))
+	(result-info (or harmless "BUG")))
+   (if (not (equal? input output))
+    (if harmless
+     (ly:progress "Test unequal: ~a.\nin  = ~a\nout = ~a\n"
+      harmless input output)
+     (ly:input-warning location "Test unequal: BUG.\nin  = ~a\nout = ~a\n"
       input output)))))
 
 %%%