]> git.donarmstrong.com Git - lilypond.git/commitdiff
Allow harmonic note heads to have dots.
authorNeil Puttock <n.puttock@gmail.com>
Wed, 27 Aug 2008 22:37:28 +0000 (23:37 +0100)
committerNeil Puttock <n.puttock@gmail.com>
Thu, 28 Aug 2008 21:53:23 +0000 (22:53 +0100)
Add context property harmonicDots to determine whether
dots should be visible.

input/regression/note-head-harmonic-dotted.ly [new file with mode: 0644]
lily/new-fingering-engraver.cc
scm/define-context-properties.scm

diff --git a/input/regression/note-head-harmonic-dotted.ly b/input/regression/note-head-harmonic-dotted.ly
new file mode 100644 (file)
index 0000000..f7e4f48
--- /dev/null
@@ -0,0 +1,14 @@
+\version "2.11.58"
+
+\header {
+  texidoc = "
+Dots on harmonic note heads can be shown by setting the property
+@code{harmonicDots}.
+"
+}
+
+\relative c'' {
+  r4 <bes es\harmonic>2.
+  \set harmonicDots = ##t
+  r4 <bes es\harmonic>2.
+}
index fe75842c0ffa29342119be223e8785219bcefce6..2749d5cb3f623d1c46fd050c2f5b03bf7c9ab784 100644 (file)
@@ -108,7 +108,7 @@ New_fingering_engraver::acknowledge_rhythmic_head (Grob_info inf)
        {
          inf.grob ()->set_property ("style", ly_symbol2scm ("harmonic"));
          Grob *d = unsmob_grob (inf.grob ()->get_object ("dot"));
-         if (d)
+         if (d && !to_boolean (get_property ("harmonicDots")))
            d->suicide ();
        }
     }
@@ -358,6 +358,7 @@ ADD_TRANSLATOR (New_fingering_engraver,
 
                /* read */
                "fingeringOrientations "
+               "harmonicDots "
                "strokeFingerOrientations "
                "stringNumberOrientations ",
                
index cbd0e1544b68f8b74c9e5dc2c13ea37efd1f682d..a7dd3ab14b7a49ba1596a6e189ede5b84c533de2 100644 (file)
@@ -234,6 +234,8 @@ for the full staff.")
 
      (harmonicAccidentals ,boolean? "If set, harmonic notes in chords
 get accidentals.")
+     (harmonicDots ,boolean? "If set, harmonic notes in dotted chords get
+dots.")
      (highStringOne ,boolean? "Whether the first string is the string
 with highest pitch on the instrument.  This used by the automatic
 string selector for tablature notation.")