]> git.donarmstrong.com Git - lilypond.git/commitdiff
* scm/define-context-properties.scm
authorHan-Wen Nienhuys <hanwen@xs4all.nl>
Fri, 22 Jul 2005 22:52:25 +0000 (22:52 +0000)
committerHan-Wen Nienhuys <hanwen@xs4all.nl>
Fri, 22 Jul 2005 22:52:25 +0000 (22:52 +0000)
(all-internal-translation-properties): remove acceptHashTable,
acknowledgeHashTable

* lily/translator-group.cc (mark_smob): idem for acceptHashTable.

* lily/engraver-group-engraver.cc (Engraver_group_engraver):
change acknowledgeHashTable to C++ member.

* lily/rest-collision.cc (do_shift): use extract_grob_set().

13 files changed:
ChangeLog
VERSION
lily/engraver-group-engraver.cc
lily/include/engraver-group-engraver.hh
lily/include/translator-group.hh
lily/include/translator.hh
lily/include/translator.icc
lily/rest-collision.cc
lily/translator-group.cc
lily/translator.cc
lily/type-swallow-translator.cc
scm/define-context-properties.scm
scm/page-layout.scm

index c13e26b40ebe3f0369c69325a1292cc4c2d74e7b..0598877d6d15b9f24f82b724915b78c94fb0a305 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+2005-07-23  Han-Wen Nienhuys  <hanwen@xs4all.nl>
+
+       * scm/define-context-properties.scm
+       (all-internal-translation-properties): remove acceptHashTable,
+       acknowledgeHashTable
+
+       * lily/translator-group.cc (mark_smob): idem for acceptHashTable.
+
+       * lily/engraver-group-engraver.cc (Engraver_group_engraver):
+       change acknowledgeHashTable to C++ member. 
+
+       * lily/rest-collision.cc (do_shift): use extract_grob_set().
+
 2005-07-22  Nicolas Sceaux  <nicolas.sceaux@free.fr>
 
        * scm/display-lily.scm: new file. Define a `display-lily-music'
@@ -40,7 +53,8 @@
 
        * Documentation/topdocs/NEWS.tely (Top): mention barNumberCheck
 
-       * Documentation/user/basic-notation.itely (Barnumber check): add section.
+       * Documentation/user/basic-notation.itely (Barnumber check): add
+       section.
 
        * scm/music-functions.scm (skip-to-last): new function. Show only
        last showLastLength part of the \score.
        * Documentation/user/instrument-notation.itely (Musica ficta
        accidentals): add section Musica ficta accidentals
 
-       * lily/accidental-engraver.cc (make_suggested_accidental): new function.
+       * lily/accidental-engraver.cc (make_suggested_accidental): new
+       function.
        (make_standard_accidental): move into new function.
        (create_accidental): new function.
 
-       * scm/define-grobs.scm (all-grob-descriptions): new Grob AccidentalSuggestion
+       * scm/define-grobs.scm (all-grob-descriptions): new Grob
+       AccidentalSuggestion
 
        * lily/output-def-scheme.cc (LY_DEFINE): take default  argument.
 
-       * lily/output-def.cc (lookup_variable): return SCM_UNDEFINED if undefined.
+       * lily/output-def.cc (lookup_variable): return SCM_UNDEFINED if
+       undefined.
 
        * Documentation/user/global.itely (Page formatting): document
        horizontalshift.
diff --git a/VERSION b/VERSION
index d07bd920b481d6d301abf7a8a0f6254b084de4db..02ad8f735d683baa5258de24506c9940146a23ae 100644 (file)
--- a/VERSION
+++ b/VERSION
@@ -1,6 +1,6 @@
 PACKAGE_NAME=LilyPond
 MAJOR_VERSION=2
 MINOR_VERSION=7
-PATCH_LEVEL=2
+PATCH_LEVEL=3
 MY_PATCH_LEVEL=
 
index ae3000aebfab989740fc651158cd01322c1d348b..6584aefed53047356172dc4cc09a05c03bf42fc8 100644 (file)
@@ -36,7 +36,6 @@ Engraver_group_engraver::acknowledge_grobs ()
   if (!announce_infos_.size ())
     return;
 
-  SCM tab = context_->get_property ("acknowledgeHashTable");
   SCM name_sym = ly_symbol2scm ("name");
   SCM meta_sym = ly_symbol2scm ("meta");
 
@@ -62,11 +61,11 @@ Engraver_group_engraver::acknowledge_grobs ()
          continue;
        }
 
-      SCM acklist = scm_hashq_ref (tab, nm, SCM_UNDEFINED);
+      SCM acklist = scm_hashq_ref (acknowledge_hash_table_, nm, SCM_UNDEFINED);
       if (acklist == SCM_BOOL_F)
        {
          acklist = find_acknowledge_engravers (get_simple_trans_list (), meta);
-         scm_hashq_set_x (tab, nm, acklist);
+         scm_hashq_set_x (acknowledge_hash_table_, nm, acklist);
        }
 
       for (SCM p = acklist; scm_is_pair (p); p = scm_cdr (p))
@@ -128,17 +127,11 @@ Engraver_group_engraver::do_announces ()
   while (pending_grob_count () > 0);
 }
 
-void
-Engraver_group_engraver::initialize ()
-{
-  SCM tab = scm_make_vector (scm_int2num (61), SCM_BOOL_F);
-  context ()->set_property ("acknowledgeHashTable", tab);
-
-  Translator_group::initialize ();
-}
 
 Engraver_group_engraver::Engraver_group_engraver ()
 {
+  acknowledge_hash_table_ = SCM_EOL;
+  acknowledge_hash_table_ = scm_c_make_hash_table (61);
 }
 
 #include "translator.icc"
@@ -179,3 +172,9 @@ find_acknowledge_engravers (SCM gravlist, SCM meta_alist)
 
   return l;
 }
+
+void
+Engraver_group_engraver::derived_mark () const
+{
+  scm_gc_mark (acknowledge_hash_table_);
+}
index e235b9673194ac15dfbf666c1e86d2757fd183d3..c34de1c452921b3792667a72fa1c117ca023a37e 100644 (file)
@@ -17,12 +17,11 @@ class Engraver_group_engraver : public virtual Translator_group
 {
 protected:
   Array<Grob_info> announce_infos_;
-
+  SCM acknowledge_hash_table_;
 public:
   VIRTUAL_COPY_CONSTRUCTOR ( Translator_group, Engraver_group_engraver);
   Engraver_group_engraver ();
-
-  virtual void initialize ();
+  virtual void derived_mark () const;
   PRECOMPUTED_VIRTUAL void do_announces ();
   virtual void announce_grob (Grob_info);
   int pending_grob_count () const;
index 5f8a93ab3ec45a99b8cd992513fe9bef5432851a..d5330dbeb83a336206be24128450e56b3f858ca0 100644 (file)
@@ -72,6 +72,7 @@ public:
   Context * context () const { return context_; }
 protected:
   SCM simple_trans_list_;
+  SCM accept_hash_table_;
   Context *context_;
   
   friend class Context_def;
index af21e10ab95c45b44c901793d471f7cf5441495b..d938f52aa8f3b0a8e6b55522f88f81d4cf76b50b 100644 (file)
 
 typedef void (*Translator_void_method_ptr)(Translator*);
 
+
+struct Acknowledge_information
+{
+  SCM symbol_;
+  Translator_void_method_ptr function_;
+};
+
+
 #define TRANSLATOR_DECLARATIONS(NAME)                  \
   public:                                              \
   NAME ();                                             \
   VIRTUAL_COPY_CONSTRUCTOR (Translator, NAME);         \
   static SCM static_description_;                      \
+  static Array<Acknowledge_information> acknowledge_static_array_; \
   virtual void fetch_precomputable_methods (Translator_void_method_ptr methods[]);\
   virtual SCM static_translator_description () const;  \
-  virtual SCM translator_description () const;
-
+  virtual SCM translator_description () const; \
+  virtual Translator_void_method_ptr get_acknowledger (SCM sym) { \
+    return static_get_acknowledger (sym);\
+  }\
+  static Translator_void_method_ptr static_get_acknowledger (SCM sym);
 
 enum Translator_precompute_index {
   START_TRANSLATION_TIMESTEP,
@@ -48,7 +60,7 @@ enum Translator_precompute_index {
 class Translator
 {
   void init ();
-
+  
 protected:
   bool must_be_last_;
 
@@ -73,7 +85,6 @@ public:
   PRECOMPUTED_VIRTUAL void start_translation_timestep ();
   PRECOMPUTED_VIRTUAL void process_music ();
   PRECOMPUTED_VIRTUAL void process_acknowledged ();
-
   
   Score_context *get_score_context () const;
   Global_context *get_global_context () const;
index ce57a3c4d6ba3705a99a8912ab3911b183534c8a..b90b1fd7535d2a44642baf68d201a3c7175b316d 100644 (file)
@@ -10,6 +10,8 @@
 #ifndef TRANSLATOR_ICC
 #define TRANSLATOR_ICC
 
+#include "array.hh"
+
 /**
    A macro to automate administration of translators.
 */
   ADD_GLOBAL_CTOR (_ ## T ## _adder);
 
 #define ADD_TRANSLATOR(classname, desc, grobs, accepted, acked, read, write) \
+  Array<Acknowledge_information> classname::acknowledge_static_array_;\
   IMPLEMENT_FETCH_PRECOMPUTABLE_METHODS(classname); \
   ADD_THIS_TRANSLATOR (classname);                                     \
+  Translator_void_method_ptr\
+  classname::static_get_acknowledger (SCM sym)                         \
+  {\
+    return generic_get_acknowledger (sym, &acknowledge_static_array_);\
+  }\
   SCM                                                                  \
   classname::static_translator_description () const                    \
   {                                                                    \
@@ -84,6 +92,18 @@ T::fetch_precomputable_methods (Translator_void_method_ptr ptrs[])\
     : (Translator_void_method_ptr) &T::process_acknowledged;           \
 }
 
+void add_acknowledger (Translator_void_method_ptr ptr, const char *func_name, Array<Acknowledge_information> *ack_array);
+Translator_void_method_ptr
+generic_get_acknowledger (SCM sym, Array<Acknowledge_information> const *ack_array);
+
+#define ADD_ACKNOWLEDGER(CLASS,NAME)           \
+void CLASS ## NAME ## _ack_adder () \
+{\
+  add_acknowledger ((Translator_void_method_ptr) &CLASS::NAME, #NAME, &CLASS::acknowledge_static_array_);\
+}\
+ADD_SCM_INIT_FUNC(CLASS ## NAME ## _ack_adder);\
+
+
 
 #endif /* TRANSLATOR_ICC */
 
index 09aadd7a8e5cce2181e201ed7239dfeab7181140..78f55a46f84a7f85e3fab5efc9667384a4fe645d 100644 (file)
@@ -86,14 +86,14 @@ Rest_collision::add_column (Grob *me, Grob *p)
 SCM
 Rest_collision::do_shift (Grob *me)
 {
-  SCM elts = me->get_object ("elements");
+  extract_grob_set (me, "elements", elts);
 
   Link_array<Grob> rests;
   Link_array<Grob> notes;
 
-  for (SCM s = elts; scm_is_pair (s); s = scm_cdr (s))
+  for (int i = 0; i < elts.size (); i++)
     {
-      Grob *e = unsmob_grob (scm_car (s));
+      Grob *e = elts[i];
       if (unsmob_grob (e->get_object ("rest")))
        {
          /*
index c05c6226f9201b896bce152306f0a662abff448d..304cf9dea88dd481934eea90ff9964fc0958b46b 100644 (file)
@@ -34,9 +34,6 @@ void
 Translator_group::initialize ()
 {
   precompute_method_bindings ();
-
-  SCM tab = scm_make_vector (scm_int2num (19), SCM_BOOL_F);
-  context ()->set_property ("acceptHashTable", tab);
 }
 
 void
@@ -74,7 +71,6 @@ find_accept_translators (SCM gravlist, SCM ifaces)
 bool
 Translator_group::try_music (Music *m)
 {
-  SCM tab = context ()->get_property ("acceptHashTable");
   SCM name = scm_sloppy_assq (ly_symbol2scm ("name"),
                              m->get_property_alist (false));
 
@@ -82,12 +78,12 @@ Translator_group::try_music (Music *m)
     return false;
 
   name = scm_cdr (name);
-  SCM accept_list = scm_hashq_ref (tab, name, SCM_UNDEFINED);
+  SCM accept_list = scm_hashq_ref (accept_hash_table_, name, SCM_UNDEFINED);
   if (accept_list == SCM_BOOL_F)
     {
       accept_list = find_accept_translators (get_simple_trans_list (),
                                             m->get_property ("types"));
-      scm_hashq_set_x (tab, name, accept_list);
+      scm_hashq_set_x (accept_hash_table_, name, accept_list);
     }
 
   for (SCM p = accept_list; scm_is_pair (p); p = scm_cdr (p))
@@ -162,8 +158,11 @@ recurse_over_translators (Context *c, Translator_method ptr, Translator_group_me
 Translator_group::Translator_group ()
 {
   simple_trans_list_ = SCM_EOL;
+  accept_hash_table_ = SCM_EOL;
   context_ = 0;
   smobify_self ();
+
+  accept_hash_table_ = scm_c_make_hash_table (19);
 }
 
 void
@@ -248,7 +247,7 @@ Translator_group::mark_smob (SCM smob)
   Translator_group *me = (Translator_group*)SCM_CELL_WORD_1 (smob);
 
   me->derived_mark ();
-  
+  scm_gc_mark (me->accept_hash_table_);
   return me->simple_trans_list_;
 }
 
index e67ffcda221bceef24705d1e2fad3851adb85f55..d7c5fdf29c965653fcee357262d7091f7c5f61d4 100644 (file)
@@ -120,12 +120,6 @@ Translator::mark_smob (SCM sm)
   return SCM_EOL;
 }
 
-SCM
-Translator::translator_description () const
-{
-  return SCM_EOL;
-}
-
 Global_context *
 Translator::get_global_context () const
 {
@@ -138,12 +132,6 @@ Translator::get_score_context () const
   return daddy_context_->get_score_context ();
 }
 
-SCM
-Translator::static_translator_description ()const
-{
-  return SCM_EOL;
-}
-
 IMPLEMENT_SMOBS (Translator);
 IMPLEMENT_DEFAULT_EQUAL_P (Translator);
 IMPLEMENT_TYPE_P (Translator, "ly:translator?");
@@ -159,13 +147,6 @@ Translator::derived_mark () const
 {
 }
 
-void
-Translator::fetch_precomputable_methods (Translator_void_method_ptr ptrs[])
-{
-  for (int i = 0; i < TRANSLATOR_METHOD_PRECOMPUTE_COUNT; i++)
-    ptrs[i] = 0;
-}
-
 int
 Translator::print_smob (SCM s, SCM port, scm_print_state *)
 {
@@ -176,3 +157,41 @@ Translator::print_smob (SCM s, SCM port, scm_print_state *)
   return 1;
 }
 
+void
+add_acknowledger (Translator_void_method_ptr ptr,
+                 const char *func_name,
+                 Array<Acknowledge_information> *ack_array)
+{
+  Acknowledge_information inf;
+  inf.function_ = ptr;
+
+  String interface_name(func_name);
+
+  interface_name = interface_name.substitute ("acknowledge_", "");
+  interface_name = interface_name.substitute ('_', '-');
+  interface_name += "-interface";
+
+  inf.symbol_ = scm_gc_protect_object (ly_symbol2scm (interface_name.to_str0 ()));
+  ack_array->push (inf);
+}
+
+Translator_void_method_ptr 
+generic_get_acknowledger (SCM sym, Array<Acknowledge_information> const *ack_array)
+{
+  for (int i = 0; i < ack_array->size(); i++)
+    {
+      if (ack_array->elem (i).symbol_ == sym)
+       {
+         return ack_array->elem(i).function_;
+       }
+    }
+  return 0;
+}
+
+ADD_TRANSLATOR(Translator,
+              "Base class. Unused",
+              "",
+              "",
+              "",
+              "",
+              "");
index 2c2924072749121c310d9e31588bd77f664868ea..11f79a70cb372c0508d3a76442230325a91b8147 100644 (file)
@@ -29,7 +29,9 @@ public:
   TRANSLATOR_DECLARATIONS (Rest_swallow_translator);
 };
 
-Skip_event_swallow_translator::Skip_event_swallow_translator (){}
+Skip_event_swallow_translator::Skip_event_swallow_translator ()
+{
+}
 
 ADD_TRANSLATOR (Skip_event_swallow_translator,
                "Swallow \\skip.",
index d01608205f5f8f594c9e4ef6b56ff5128342e857..5a68721d4e48d76bb4f69c6b5b4390b850d87f5b 100644 (file)
@@ -484,12 +484,6 @@ the grobs which are still busy (e.g. note heads, spanners, etc.)
 ")
      (barCheckLastFail ,ly:moment? "Where in the measure did the last barcheck fail?") 
      (associatedVoiceContext ,ly:context? "The context object of the Voice that has the melody for this Lyrics.")
-     (acceptHashTable ,vector? "Internal
-variable: store table with MusicName to Engraver entries.")
-     (acknowledgeHashTable ,vector?
-                          "Internal variable: store interface to engraver smob table for current
-context.")
-
      (beamMelismaBusy ,boolean? "Signal if a beam is present.")
      (dynamicAbsoluteVolumeFunction ,procedure? "[DOCUMENT-ME]")
 
index 5b3f01a5661df59c0f1c6894d5a96e94a28bb0c0..98044b870ddbaef42965d03c6a57f652eb9f07ac 100644 (file)
@@ -194,6 +194,7 @@ of lines. "
   (define MAXPENALTY 1e9)
   (define paper (ly:paper-book-paper paper-book))
   (define scopes (ly:paper-book-scopes paper-book))
+  (define force-equalization-factor #f)
 
   (define (page-height page-number last?)
     (let ((p (ly:output-def-lookup paper 'page-music-height)))
@@ -218,14 +219,14 @@ is what have collected so far, and has ascending page numbers."
                             0.0
                             (node-penalty (car best-paths))))
         (inter-system-space (ly:output-def-lookup paper 'betweensystemspace))
-        (force-equalization-factor 0.3)
         (relative-force (/ force inter-system-space))
         (abs-relative-force (abs relative-force)))
 
 
       (+ (* abs-relative-force (+ abs-relative-force 1))
         prev-penalty
-        (* force-equalization-factor (/ (abs (- prev-force force)) inter-system-space))
+        (* force-equalization-factor (/ (abs (- prev-force force))
+                                        inter-system-space))
         user)))
 
   (define (space-systems page-height lines ragged?)
@@ -335,6 +336,7 @@ corresponding to DONE-LINES.
 
 CURRENT-BEST is the best result sofar, or #f."
 
+
     (let* ((this-page-num (if (null? best-paths)
                               (ly:output-def-lookup paper 'firstpagenumber)
                               (1+ (node-page-number (car best-paths)))))
@@ -382,6 +384,7 @@ CURRENT-BEST is the best result sofar, or #f."
                           #:penalty total-penalty)
                          current-best)))
 
+;;      (display total-penalty) (newline)
       (if #f ;; debug
           (display
            (list
@@ -428,6 +431,8 @@ DONE."
     (ly:paper-system-number (car (node-lines node))))
 
   (ly:message (_ "Calculating page breaks..."))
+  (set! force-equalization-factor
+       (ly:output-def-lookup paper 'verticalequalizationfactor 0.3))
 
   (let* ((best-break-node (walk-lines '() '() lines))
         (break-nodes (get-path best-break-node '()))