]> git.donarmstrong.com Git - lilypond.git/commitdiff
MusicXML: Minor change: Add TODO comment and Fix regtest title
authorReinhold Kainhofer <reinhold@kainhofer.com>
Tue, 11 Nov 2008 23:22:02 +0000 (00:22 +0100)
committerReinhold Kainhofer <reinhold@kainhofer.com>
Tue, 11 Nov 2008 23:28:41 +0000 (00:28 +0100)
input/regression/musicxml/00m-MultimeasureRests-TimeSignatures.xml
scripts/musicxml2ly.py

index 30b51548dbc7213259a3193da32653df8cb3cdf1..3a077c3c0c02197292b4b0ec603c8e176184b315 100644 (file)
@@ -2,7 +2,7 @@
 <!DOCTYPE score-partwise PUBLIC "-//Recordare//DTD MusicXML 1.1 Partwise//EN"\r
                                 "http://www.musicxml.org/dtds/partwise.dtd">\r
 <score-partwise version="1.1">\r
-  <movement-title>Multi-bar formatting (different time signatures)</movement-title>\r
+  <movement-title>Multi-measure rests (different time signatures)</movement-title>\r
   <identification>\r
     <creator type="composer">Reinhold Kainhofer</creator>\r
     <rights>Public Domain</rights>\r
index a55ae8e4302bc3b81f445dd1caf714d92ba902bc..695f855d4996f3ec34ce2994c416a2b13ed14e73 100644 (file)
@@ -1639,6 +1639,8 @@ class LilyPondVoiceBuilder:
             duration_factor = 1
             duration_log = {1: 0, 2: 1, 4:2, 8:3, 16:4, 32:5, 64:6, 128:7, 256:8, 512:9}.get (diff.denominator (), -1)
             duration_dots = 0
+            # TODO: Use the time signature for skips, too. Problem: The skip 
+            #       might not start at a measure boundary!
             if duration_log > 0: # denominator is a power of 2...
                 if diff.numerator () == 3:
                     duration_log -= 1