Fix 881, with Neil's suggestion

Make laisser-vibrez::print a pure function

Add regression test for issue 881

diff --git a/input/regression/laissez-vibrer-arpeggio.ly b/input/regression/laissez-vibrer-arpeggio.ly
new file mode 100644 (file)
index 0000000..03fcd8e
--- /dev/null
+++ b/input/regression/laissez-vibrer-arpeggio.ly
@@ -0,0 +1,15 @@
+\header {
+
+  texidoc = "
+l.v. ties should not collide with arpeggio indications.
+"
+}
+
+\version "2.12.1" % regression: 2.10.33 and 2.8.8 are ok
+
+{
+ <e'>\laissezVibrer <f  f'> \arpeggio
+ <e'>\laissezVibrer <g  f'> \arpeggio \mark "Ties should not collide"
+ <e'>\laissezVibrer <a  f'> \arpeggio
+ <e'>\laissezVibrer <b  f'> \arpeggio
+ }

diff --git a/input/regression/laissez-vibrer-ties.ly b/input/regression/laissez-vibrer-ties.ly
index ddb36f1dd7bc245f05b7f2f43e743cf9226f09fe..681fdaf7ef11ccfb6ad825ac560fede1a050f82c 100644 (file)
--- a/input/regression/laissez-vibrer-ties.ly
+++ b/input/regression/laissez-vibrer-ties.ly
@@ -19,7 +19,7 @@ They have fixed size. Their formatting can be tuned with
   <c e g>\laissezVibrer r4
   <c f g>\laissezVibrer r
   <c d f g>\laissezVibrer r
-  <c d f g>4.\laissezVibrer r
+  <c d f g>4.\laissezVibrer r8
 
   <c d e f>4\laissezVibrer r
   \override LaissezVibrerTieColumn #'tie-configuration

diff --git a/scm/define-grobs.scm b/scm/define-grobs.scm
index 4d165678046fca764e5c1e980b2d3e8213edaa95..7be62f1c82cb0ccf5f810ffce2d18be47472d10c 100644 (file)
--- a/scm/define-grobs.scm
+++ b/scm/define-grobs.scm
@@ -977,7 +977,7 @@
                    (height-limit . 1.0)))
        (direction . ,ly:tie::calc-direction)
        (head-direction . ,LEFT)
-       (stencil  . ,ly:tie::print)
+       (stencil  . ,laissez-vibrer::print)
        (thickness . 1.0)
        (meta . ((class . Item)
                 (interfaces . (semi-tie-interface))))))
@@ -2350,6 +2350,7 @@
    fret-board::calc-stencil
    note-head::brew-ez-stencil
    print-circled-text-callback
+   laissez-vibrer::print
    lyric-text::print
    ly:bar-line::print
    ly:mensural-ligature::brew-ligature-primitive
@@ -2399,6 +2400,7 @@
 (define pure-functions
   (list
    parenthesize-elements
+   laissez-vibrer::print
    ly:rest::y-offset-callback
    ly:staff-symbol-referencer::callback
    ly:staff-symbol::height))

diff --git a/scm/output-lib.scm b/scm/output-lib.scm
index 8e4697dd66b26a8d02b3289bd3312b58eda8e83e..d29e26498c7f4b7bd4138530e1fed71d61087369 100644 (file)
--- a/scm/output-lib.scm
+++ b/scm/output-lib.scm
@@ -882,3 +882,11 @@ between the two text elements."
        (begin
          (ly:grob-suicide! grob)
          (list)))))
+
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+;;  laissez-vibrer tie
+;;
+;;  needed so we can make laissez-vibrer a pure print
+;;
+(define-public (laissez-vibrer::print grob)
+ (ly:tie::print grob))