* Documentation/user/notation.itely (ancient flags): documented

	flags-related known bugs

	* lily/include/ligature-engraver.hh: added comment about why and
	how of (non-)use of abstract virtual methods

	* ly/engraver-init.ly (VaticanaVoice,
	GregorianTranscriptionVoice): bugfix (workaround): TextSpanner:
	unset dash-fraction property in order to get solid lines

	* ly/engraver-init.ly (MensuralStaff): fixed bad comment

diff --git a/ChangeLog b/ChangeLog
index 5c078f5577fcd8bab83dbabec27ce9e9f5e4f351..b8f8b3caf400f7f2a5c14f58409aa088b75342a7 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,17 @@
+2004-09-21  Juergen Reuter  <reuter@ipd.uka.de>
+
+       * Documentation/user/notation.itely (ancient flags): documented
+       flags-related known bugs
+
+       * lily/include/ligature-engraver.hh: added comment about why and
+       how of (non-)use of abstract virtual methods
+
+       * ly/engraver-init.ly (VaticanaVoice,
+       GregorianTranscriptionVoice): bugfix (workaround): TextSpanner:
+       unset dash-fraction property in order to get solid lines
+
+       * ly/engraver-init.ly (MensuralStaff): fixed bad comment
+

 2004-09-21  Mats Bengtsson  <mabe@drongo.s3.kth.se>
 
        * scripts/convert-ly.py (ly): Corrected replacement of \scriptBoth
 2004-09-21  Mats Bengtsson  <mabe@drongo.s3.kth.se>
 
        * scripts/convert-ly.py (ly): Corrected replacement of \scriptBoth

diff --git a/Documentation/user/notation.itely b/Documentation/user/notation.itely
index 89e6154123c356dc8b5c9bec790195f598e6f1f2..9e3e231e760006783c40aeb9c29f58d2ddfaa25e 100644 (file)
--- a/Documentation/user/notation.itely
+++ b/Documentation/user/notation.itely
@@ -6016,6 +6016,16 @@ when typesetting the incipit of a transcribed piece of mensural
 music, the default flag style should be used.  There are no flags in
 Gregorian Chant notation.
 
 music, the default flag style should be used.  There are no flags in
 Gregorian Chant notation.
 

+@refbugs
+
+The attachment of ancient flags to stems is slightly off due to a
+change in early 2.3.x.
+
+Vertically aligning each flag with a staff line assumes that stems
+always end either exactly on or exactly in the middle between two
+staff lines.  This may not always be true when using advanced layout
+features of classical notation (which however are typically out of
+scope for mensural notation).

 
 @node Ancient time signatures
 @subsection Ancient time signatures
 
 @node Ancient time signatures
 @subsection Ancient time signatures

diff --git a/lily/include/ligature-engraver.hh b/lily/include/ligature-engraver.hh
index a63920598f9f8fa57ea9bac2ea86f28b287eaabe..51fbf316338b8934a4cdd65759b53cc2013b5c51 100644 (file)
--- a/lily/include/ligature-engraver.hh
+++ b/lily/include/ligature-engraver.hh
@@ -11,6 +11,21 @@
 
 #include "engraver.hh"
 
 
 #include "engraver.hh"
 

+/*
+ * FIXME: Spanner *create_ligature_spanner () and virtual void
+ * typeset_ligature (...) are abstract methods, such that we would
+ * like to declare them abstract:
+ *
+ *    virtual Spanner *create_ligature_spanner () = 0;
+ *    virtual void typeset_ligature (...) = 0;
+ *
+ * Unfortunately, clone_const_helper() (as expanded from the
+ * TRANSLATOR_DECLARATIONS macro) requires this class to be
+ * instantiatable, such that it may not have any abstract virtual
+ * functions.  As a workaround, the actually abstract methods are
+ * implemented, but produce a programming_error whenever called. --jr
+ */
+

 class Ligature_engraver : public Engraver
 {
 protected:
 class Ligature_engraver : public Engraver
 {
 protected:

diff --git a/ly/engraver-init.ly b/ly/engraver-init.ly
index fa8da2751262e66ab5ffe1754948a527ce68aa73..0f288016fc20eb92ff834d4213069f385024d7f0 100644 (file)
--- a/ly/engraver-init.ly
+++ b/ly/engraver-init.ly
@@ -675,6 +675,11 @@ EasyNotation = \context {  % TODO: why \context override?
   autoBeaming = ##f
 
   % Prepare TextSpanner for \episem{Initium|Finis} use.
   autoBeaming = ##f
 
   % Prepare TextSpanner for \episem{Initium|Finis} use.

+  %
+  % N.B.: dash-fraction MUST be unset; otherwise, TextSpanner will
+  % always produce dashed lines, regardless of the style property.
+  %
+  \override TextSpanner #'dash-fraction = #'()

   \override TextSpanner #'style = #'line
   \override TextSpanner #'edge-height = #'(0 . 0)
   \override TextSpanner #'padding = #0.5
   \override TextSpanner #'style = #'line
   \override TextSpanner #'edge-height = #'(0 . 0)
   \override TextSpanner #'padding = #0.5


@@ -740,6 +745,11 @@ EasyNotation = \context {  % TODO: why \context override?
   autoBeaming = ##f
 
   % Prepare TextSpanner for \episem{Initium|Finis} use.
   autoBeaming = ##f
 
   % Prepare TextSpanner for \episem{Initium|Finis} use.

+  %
+  % N.B.: dash-fraction MUST be unset; otherwise, TextSpanner will
+  % always produce dashed lines, regardless of the style property.
+  %
+  \override TextSpanner #'dash-fraction = #'()

   \override TextSpanner #'style = #'line
   \override TextSpanner #'edge-height = #'(0 . 0)
   \override TextSpanner #'padding = #0.5
   \override TextSpanner #'style = #'line
   \override TextSpanner #'edge-height = #'(0 . 0)
   \override TextSpanner #'padding = #0.5


@@ -796,7 +806,7 @@ EasyNotation = \context {   % TODO: why \context override?
   % FIXME: unit on StaffSymbol's width should be \linewidth.
   % \override StaffSymbol #'width = #60.0
 
   % FIXME: unit on StaffSymbol's width should be \linewidth.
   % \override StaffSymbol #'width = #60.0
 

-  % Choose vaticana do clef on 3rd line as default.
+  % Choose petrucci g clef on 2nd line as default.

   clefGlyph = #"clefs-petrucci-g"
   middleCPosition = #-6
   clefPosition = #-2
   clefGlyph = #"clefs-petrucci-g"
   middleCPosition = #-6
   clefPosition = #-2