From 1f81df46999fc3699ce73aeba95af5095a5a413a Mon Sep 17 00:00:00 2001 From: Niels Thykier Date: Wed, 3 Aug 2016 21:10:30 +0000 Subject: [PATCH] Prefer "use Exporter qw(import)" to inheriting from it Signed-off-by: Niels Thykier --- Debbugs/Bugs.pm | 2 +- Debbugs/CGI.pm | 2 +- Debbugs/CGI/Bugreport.pm | 2 +- Debbugs/CGI/Pkgreport.pm | 2 +- Debbugs/Common.pm | 2 +- Debbugs/Control.pm | 2 +- Debbugs/Control/Service.pm | 2 +- Debbugs/Estraier.pm | 2 +- Debbugs/Libravatar.pm | 2 +- Debbugs/Log.pm | 2 +- Debbugs/MIME.pm | 2 +- Debbugs/Mail.pm | 2 +- Debbugs/Packages.pm | 2 +- Debbugs/Recipients.pm | 2 +- Debbugs/SOAP.pm | 3 ++- Debbugs/Status.pm | 2 +- Debbugs/Text.pm | 2 +- Debbugs/UTF8.pm | 2 +- Debbugs/User.pm | 2 +- 19 files changed, 20 insertions(+), 19 deletions(-) diff --git a/Debbugs/Bugs.pm b/Debbugs/Bugs.pm index e4f8cc8..e678aff 100644 --- a/Debbugs/Bugs.pm +++ b/Debbugs/Bugs.pm @@ -38,7 +38,7 @@ incomplete) to slowest (and most complete).] use warnings; use strict; use vars qw($VERSION $DEBUG %EXPORT_TAGS @EXPORT_OK @EXPORT); -use base qw(Exporter); +use Exporter qw(import); BEGIN{ $VERSION = 1.00; diff --git a/Debbugs/CGI.pm b/Debbugs/CGI.pm index 34646b8..d97dc2b 100644 --- a/Debbugs/CGI.pm +++ b/Debbugs/CGI.pm @@ -34,7 +34,7 @@ None known. use warnings; use strict; use vars qw($VERSION $DEBUG %EXPORT_TAGS @EXPORT_OK @EXPORT); -use base qw(Exporter); +use Exporter qw(import); use Debbugs::URI; use HTML::Entities; diff --git a/Debbugs/CGI/Bugreport.pm b/Debbugs/CGI/Bugreport.pm index 8ebbfe8..9ca67ed 100644 --- a/Debbugs/CGI/Bugreport.pm +++ b/Debbugs/CGI/Bugreport.pm @@ -28,7 +28,7 @@ None known. use warnings; use strict; use vars qw($VERSION $DEBUG %EXPORT_TAGS @EXPORT_OK @EXPORT); -use base qw(Exporter); +use Exporter qw(import); use IO::Scalar; use Params::Validate qw(validate_with :types); diff --git a/Debbugs/CGI/Pkgreport.pm b/Debbugs/CGI/Pkgreport.pm index 3b96744..3e9cb3f 100644 --- a/Debbugs/CGI/Pkgreport.pm +++ b/Debbugs/CGI/Pkgreport.pm @@ -28,7 +28,7 @@ None known. use warnings; use strict; use vars qw($VERSION $DEBUG %EXPORT_TAGS @EXPORT_OK @EXPORT); -use base qw(Exporter); +use Exporter qw(import); use IO::Scalar; use Params::Validate qw(validate_with :types); diff --git a/Debbugs/Common.pm b/Debbugs/Common.pm index 6deaf4a..2bc3e0d 100644 --- a/Debbugs/Common.pm +++ b/Debbugs/Common.pm @@ -31,7 +31,7 @@ with equivalent (or better) functionality here. use warnings; use strict; use vars qw($VERSION $DEBUG %EXPORT_TAGS @EXPORT_OK @EXPORT); -use base qw(Exporter); +use Exporter qw(import); BEGIN{ $VERSION = 1.00; diff --git a/Debbugs/Control.pm b/Debbugs/Control.pm index 49b902e..226cd1f 100644 --- a/Debbugs/Control.pm +++ b/Debbugs/Control.pm @@ -75,7 +75,7 @@ is true, the above options must be present, and their values are used. use warnings; use strict; use vars qw($VERSION $DEBUG %EXPORT_TAGS @EXPORT_OK @EXPORT); -use base qw(Exporter); +use Exporter qw(import); BEGIN{ $VERSION = 1.00; diff --git a/Debbugs/Control/Service.pm b/Debbugs/Control/Service.pm index 520db3e..42f3801 100644 --- a/Debbugs/Control/Service.pm +++ b/Debbugs/Control/Service.pm @@ -75,7 +75,7 @@ is true, the above options must be present, and their values are used. use warnings; use strict; use vars qw($VERSION $DEBUG %EXPORT_TAGS @EXPORT_OK @EXPORT); -use base qw(Exporter); +use Exporter qw(import); BEGIN{ $VERSION = 1.00; diff --git a/Debbugs/Estraier.pm b/Debbugs/Estraier.pm index 5987fe9..7ada02d 100644 --- a/Debbugs/Estraier.pm +++ b/Debbugs/Estraier.pm @@ -28,7 +28,7 @@ None known. use warnings; use strict; use vars qw($VERSION $DEBUG %EXPORT_TAGS @EXPORT_OK @EXPORT); -use base qw(Exporter); +use Exporter qw(import); use Debbugs::Log; use Search::Estraier; use Debbugs::Common qw(getbuglocation getbugcomponent make_list); diff --git a/Debbugs/Libravatar.pm b/Debbugs/Libravatar.pm index 8dcbad0..d051090 100644 --- a/Debbugs/Libravatar.pm +++ b/Debbugs/Libravatar.pm @@ -31,7 +31,7 @@ None known. use warnings; use strict; use vars qw($VERSION $DEBUG %EXPORT_TAGS @EXPORT_OK @EXPORT); -use base qw(Exporter); +use Exporter qw(import); use Debbugs::Config qw(:config); use Debbugs::Common qw(:lock); diff --git a/Debbugs/Log.pm b/Debbugs/Log.pm index 6ff8ab2..5a7306d 100644 --- a/Debbugs/Log.pm +++ b/Debbugs/Log.pm @@ -16,7 +16,7 @@ use warnings; use strict; use vars qw($VERSION $DEBUG @EXPORT @EXPORT_OK %EXPORT_TAGS); -use base qw(Exporter); +use Exporter qw(import); BEGIN { $VERSION = 1.00; diff --git a/Debbugs/MIME.pm b/Debbugs/MIME.pm index aae3b58..f114c68 100644 --- a/Debbugs/MIME.pm +++ b/Debbugs/MIME.pm @@ -32,7 +32,7 @@ None known. use warnings; use strict; -use base qw(Exporter); +use Exporter qw(import); use vars qw($DEBUG $VERSION @EXPORT_OK %EXPORT_TAGS @EXPORT); BEGIN { diff --git a/Debbugs/Mail.pm b/Debbugs/Mail.pm index 68e88a1..01ae327 100644 --- a/Debbugs/Mail.pm +++ b/Debbugs/Mail.pm @@ -39,7 +39,7 @@ END use warnings; use strict; use vars qw($VERSION $DEBUG %EXPORT_TAGS @EXPORT_OK @EXPORT); -use base qw(Exporter); +use Exporter qw(import); use IPC::Open3; use POSIX qw(:sys_wait_h strftime); diff --git a/Debbugs/Packages.pm b/Debbugs/Packages.pm index 62d2682..f2ba789 100644 --- a/Debbugs/Packages.pm +++ b/Debbugs/Packages.pm @@ -12,7 +12,7 @@ package Debbugs::Packages; use warnings; use strict; -use base qw(Exporter); +use Exporter qw(import); use vars qw($VERSION @EXPORT_OK %EXPORT_TAGS @EXPORT); use Carp; diff --git a/Debbugs/Recipients.pm b/Debbugs/Recipients.pm index ae739e9..f9b2c73 100644 --- a/Debbugs/Recipients.pm +++ b/Debbugs/Recipients.pm @@ -25,7 +25,7 @@ None known. use warnings; use strict; use vars qw($VERSION $DEBUG %EXPORT_TAGS @EXPORT_OK @EXPORT); -use base qw(Exporter); +use Exporter qw(import); BEGIN{ ($VERSION) = q$Revision: 1221 $ =~ /^Revision:\s+([^\s+])/; diff --git a/Debbugs/SOAP.pm b/Debbugs/SOAP.pm index f87581e..7508e94 100644 --- a/Debbugs/SOAP.pm +++ b/Debbugs/SOAP.pm @@ -25,7 +25,8 @@ use warnings; use strict; use vars qw($DEBUG %EXPORT_TAGS @EXPORT_OK @EXPORT); use Debbugs::SOAP::Server; -use base qw(Exporter SOAP::Server::Parameters); +use Exporter qw(import); +use base qw(SOAP::Server::Parameters); BEGIN{ $DEBUG = 0 unless defined $DEBUG; diff --git a/Debbugs/Status.pm b/Debbugs/Status.pm index 26fbcc2..72e9ae6 100644 --- a/Debbugs/Status.pm +++ b/Debbugs/Status.pm @@ -34,7 +34,7 @@ use warnings; use strict; use vars qw($VERSION $DEBUG %EXPORT_TAGS @EXPORT_OK @EXPORT); -use base qw(Exporter); +use Exporter qw(import); use Params::Validate qw(validate_with :types); use Debbugs::Common qw(:util :lock :quit :misc); diff --git a/Debbugs/Text.pm b/Debbugs/Text.pm index 3533920..21bde01 100644 --- a/Debbugs/Text.pm +++ b/Debbugs/Text.pm @@ -33,7 +33,7 @@ None known. use vars qw($DEBUG $VERSION @EXPORT_OK %EXPORT_TAGS @EXPORT @ISA); -use base qw(Exporter); +use Exporter qw(import); BEGIN { $VERSION = 1.00; diff --git a/Debbugs/UTF8.pm b/Debbugs/UTF8.pm index 0c4d336..c4067f5 100644 --- a/Debbugs/UTF8.pm +++ b/Debbugs/UTF8.pm @@ -28,7 +28,7 @@ charsets to UTF8. use warnings; use strict; use vars qw($VERSION $DEBUG %EXPORT_TAGS @EXPORT_OK @EXPORT); -use base qw(Exporter); +use Exporter qw(import); BEGIN{ $VERSION = 1.00; diff --git a/Debbugs/User.pm b/Debbugs/User.pm index 6ea171c..c25b35a 100644 --- a/Debbugs/User.pm +++ b/Debbugs/User.pm @@ -83,7 +83,7 @@ use warnings; use strict; use Fcntl ':flock'; use vars qw($VERSION $DEBUG %EXPORT_TAGS @EXPORT_OK @EXPORT); -use base qw(Exporter); +use Exporter qw(import); use Debbugs::Config qw(:config); use List::Util qw(min); -- 2.39.2