Prefer "use Exporter qw(import)" to inheriting from it

[debbugs.git] / Debbugs / UTF8.pm

diff --git a/Debbugs/UTF8.pm b/Debbugs/UTF8.pm
index 0ad284df16a6d37794098c5c67de37b70613b835..c4067f5e183cec5d2ae70f0fffc53682608fda48 100644 (file)
--- a/Debbugs/UTF8.pm
+++ b/Debbugs/UTF8.pm
@@ -28,7 +28,7 @@ charsets to UTF8.
 use warnings;
 use strict;
 use vars qw($VERSION $DEBUG %EXPORT_TAGS @EXPORT_OK @EXPORT);
-use base qw(Exporter);
+use Exporter qw(import);
 
 BEGIN{
      $VERSION = 1.00;
@@ -179,7 +179,8 @@ sub convert_to_utf8 {
             # if there's an à (0xC3), it's probably something
             # horrible, and we shouldn't try to convert it.
             if (defined $call_back_data and $call_back_data !~ /\x{C3}/) {
-                warn "failed to convert to utf8 (charset: $charset, data: $data), but succeeded with ISO8859-1: ".encode_utf8($call_back_data);
+                # this warning produces far too much useless output; elminating it
+                # warn "failed to convert to utf8 (charset: $charset, data: $data), but succeeded with ISO8859-1: ".encode_utf8($call_back_data);
                 return $call_back_data;
             }
         }