Add this missing dependency to get the number of Lintian errors to zero
so that builds and e.g. Salsa-CI passes. Several Lintian warnings still remain.
Having Salsa-CI in the package will make it less likely that new Lintian
errors are introduced, or at least their are caught immediately.
The post-build tests were failing on tens of errors like:
t/07_bugreport.t ..................... Can't locate Mail/Message/Field.pm in @INC (you may need to install the Mail::Message::Field module) (@INC entries checked: lib /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.38.2 /usr/local/share/perl/5.38.2 /usr/lib/x86_64-linux-gnu/perl5/5.38 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.38 /usr/share/perl/5.38 /usr/local/lib/site_perl .) at lib/Debbugs/MIME.pm line 57.
BEGIN failed--compilation aborted at lib/Debbugs/MIME.pm line 57.
Compilation failed in require at t/07_bugreport.t line 19.
BEGIN failed--compilation aborted at t/07_bugreport.t line 19.
Add the missing dependency to overcome this and get the tests passing.
Note that the tests still emit multiple times this warning which
warrants additional follow-up later:
t/07_bugreport.t ..................... 14/19
Text::Xslate: get_info_from_db not implemented without schema at lib/Debbugs/Package.pm line 196.
Debbugs::Package::_get_valid_version_info_from_db(Debbugs::Package={package=bar}) called at lib/Debbugs/Package.pm line 166
Debbugs::Package::_build_valid_version_info(Debbugs::Package={package=bar}) called at /usr/share/perl5/MouseX/NativeTraits/MethodProvider/ArrayRef.pm line 315
Debbugs::Package::_valid_version_info(Debbugs::Package={package=bar}) called at lib/Debbugs/Package.pm line 534
Debbugs::Package::source_names(Debbugs::Package={package=bar}) called at lib/Debbugs/Package.pm line 525
Debbugs::Package::_build_sources(Debbugs::Package={package=bar}) called at lib/Debbugs/Text.pm line 209
eval {...} called at lib/Debbugs/Text.pm line 209
Debbugs::Text::fill_in_template("template", "cgi/bugreport", "variables", HASH(0x559b9ebe1c10), "hole_var", HASH(0x559b9ebe2288)) called at ./cgi/bugreport.cgi line 403
Version 10 doesn't (seem to) exist at all and 9.6 and 11 are for very
old versions. Replace them with the versions included in recent Debian
versions:
- 13 in Bullseye
- 15 in Bookworm
- 16 in Trixie and current unstable
(cherry-picked from https://salsa.debian.org/debbugs-team/debbugs/-/merge_requests/16)
Otto Kekäläinen [Thu, 16 May 2024 06:26:14 +0000 (23:26 -0700)]
Enable Salsa-CI
This will help ensure easily machine detectable regressions don't slip
into the code base.
This also makes any future contribution process faster and more
reliable, as any contributor submitting a Merge Request will get
immediate feedback, and the maintainers save time by not having to point
out basic mistakes.
Paul Wise [Sun, 13 Nov 2022 01:00:39 +0000 (09:00 +0800)]
Allow exporting of debbugs responses to mbox format when requested
This makes mbox export of response messages consistent with HTML export.
The bts (from devscripts) cache mode of "full" requests all messages from the
bug, including debbugs response mails, in mbox format but debbugs always
ignores those messages when returning an mbox, leading to bts errors.
Paul Wise [Fri, 2 Dec 2022 01:16:49 +0000 (09:16 +0800)]
Prevent usertags created at submit time from including invalid trailing chars
There were two regex validating included characters but the one used at submit
time only checked for valid characters at the start of the usertag string.
Also factor the usertag validity regex into a function to reduce duplication.
Don Armstrong [Sun, 30 Jun 2019 17:04:18 +0000 (10:04 -0700)]
In Debbugs::Package, do not double search for binary packages
When we're given a source package to search for, do not bother to load all of
the data related to all binary packages which correspond to that source package.
[For a complicated source package with 5000 binary packages like linux, that
search can take more than 5 seconds.]
Don Armstrong [Sun, 30 Jun 2019 16:58:18 +0000 (09:58 -0700)]
Resolve issues with get_source_versions{,_distributions}
- Add documentation to Debbugs::Collection::Package
- Add sources and source_names methods
- Version regex was incorrect; fix it
- Return Debbugs::Collection::Version now