Fixed -fPIC issue for CentOS users.

 * Forced compiler flag that was not being automatically set by CMake on
that OS. Had previously set this on API library. Got feedback that it
worked there, so I added the flag to Utils & JsonCPP libs as well.

diff --git a/src/api/CMakeLists.txt b/src/api/CMakeLists.txt
index 9ba99632bd4594d189e6d024232969eda8019045..39864c707ec0ea196f573735d08cd2b22919720e 100644 (file)
--- a/src/api/CMakeLists.txt
+++ b/src/api/CMakeLists.txt
@@ -10,7 +10,7 @@ include_directories( ${BamTools_SOURCE_DIR}/src )
 
 # add compiler definitions 
 add_definitions( -DBAMTOOLS_API_LIBRARY ) # (for proper exporting of library symbols)
-add_definitions( -fPIC ) # (attempt to force PIC compiling on some archs)
+add_definitions( -fPIC ) # (attempt to force PIC compiling on CentOS, not being set on shared libs by CMake)
 
 # list of all BamTools API source (.cpp) files
 set( BamToolsAPISources

diff --git a/src/third_party/jsoncpp/CMakeLists.txt b/src/third_party/jsoncpp/CMakeLists.txt
index 3fc9ec47bd1786c58d98c52995ba0ff6c5eb6aea..9cc442ad9968f35359a8d884ec0408fba6f4e340 100644 (file)
--- a/src/third_party/jsoncpp/CMakeLists.txt
+++ b/src/third_party/jsoncpp/CMakeLists.txt
@@ -7,6 +7,7 @@
 
 # add compiler definitions 
 add_definitions(-DBAMTOOLS_JSONCPP_LIBRARY) # (for proper exporting of library symbols)
+add_definitions( -fPIC ) # (attempt to force PIC compiling on CentOS, not being set on shared libs by CMake)
 
 # create jsoncpp library
 add_library ( jsoncpp SHARED 

diff --git a/src/utils/CMakeLists.txt b/src/utils/CMakeLists.txt
index 5bbe6248cadf291fcc7132b5b1c3151e44723bbd..fab013a656264801caf75570d13b49a9f821f795 100644 (file)
--- a/src/utils/CMakeLists.txt
+++ b/src/utils/CMakeLists.txt
@@ -10,6 +10,7 @@ include_directories (${BamTools_SOURCE_DIR}/src/api)
 
 # add compiler definitions 
 add_definitions(-DBAMTOOLS_UTILS_LIBRARY) # (for proper exporting of library symbols)
+add_definitions( -fPIC ) # (attempt to force PIC compiling on CentOS, not being set on shared libs by CMake)
 
 # create BamTools utils library
 add_library ( BamTools-utils SHARED