* Add quotes around retitle'd titles (closes: #419202)

 * Fix usertag visible_cat code in service.in

diff --git a/debian/changelog b/debian/changelog
index 829afd299344de4e15250fbf13e239089c3a7b9b..ad298432ab9c35ed5cea40ef69cf31cdcd694f0f 100644 (file)
--- a/debian/changelog
+++ b/debian/changelog
@@ -166,6 +166,7 @@ debbugs (2.4.2) UNRELEASED; urgency=low
     - pkgindex.cgi limits its output with pagination (closes: #23018)
     - lc submitter address for comparsion in pkgreport.cgi
       (closes: #415628)
+    - Add quotes around retitle'd titles (closes: #419202)
 
   
  -- Colin Watson <cjwatson@debian.org>  Fri, 20 Jun 2003 18:57:25 +0100

diff --git a/scripts/service.in b/scripts/service.in
index 0ffcd202ae58433737586fd373b28d35629768bc..28b8cdbafed4526e0a46e0d57e3df8ce3b34c5e7 100755 (executable)
--- a/scripts/service.in
+++ b/scripts/service.in
@@ -336,11 +336,13 @@ END
        if (@cats) {
            &transcript("Added usercategory $catname.\n\n");
            $u->{"categories"}->{$catname} = [ @cats ];
-           $u->{visible_cats}{$catname} = $hidden;
+           if (not $hidden) {
+                push @{$u->{visible_cats}},$catname;
+           }
        } else {
            &transcript("Removed usercategory $catname.\n\n");
            delete $u->{"categories"}->{$catname};
-           delete $u->{visible_cats}{$catname};
+           @{$u->{visible_cats}} = grep {$_ ne $catname} @{$u->{visible_cats}};
        }
        $u->write();
     } elsif (m/^usertags?\s+\#?(-?\d+)\s+(([=+-])\s*)?(\S.*)?$/i) {
@@ -893,7 +895,7 @@ END
                 &addmaintainers($data);
                my $oldtitle = $data->{subject};
                 $data->{subject}= $newtitle;
-                $action= "Changed $gBug title to $newtitle from $oldtitle.";
+                $action= "Changed $gBug title to `$newtitle' from `$oldtitle'.";
                 &savebug;
                 &transcript("$action\n");
                 if (length($data->{done})) {